Patchwork [U-Boot,v3,1/2] mx31: make HSP clock for mx3fb driver available

login
register
mail settings
Submitter Anatolij Gustschin
Date Oct. 13, 2011, 9:16 a.m.
Message ID <1318497389-13726-1-git-send-email-agust@denx.de>
Download mbox | patch
Permalink /patch/119391/
State Accepted
Commit f00291985b231c5c1f05fc6d09488001d22ae7e3
Delegated to: Stefano Babic
Headers show

Comments

Anatolij Gustschin - Oct. 13, 2011, 9:16 a.m.
From: Helmut Raiger <helmut.raiger@hale.at>

This additionally updates mx31/generic.c by
- replacing __REG() macro accesses with readl() and writel()
- providing macros for PDR0 and PLL bit accesses

Signed-off-by: Helmut Raiger <helmut.raiger@hale.at>
Acked-by: Marek Vasut <marek.vasut@gmail.com>
Signed-off-by: Anatolij Gustschin <agust@denx.de>
Cc: Stefano Babic <sbabic@denx.de>
---
Changes since v2:
 - rebased to apply on current top of tree

 arch/arm/cpu/arm1136/mx31/generic.c       |   40 +++++++++++++++++++---------
 arch/arm/include/asm/arch-mx31/clock.h    |    1 +
 arch/arm/include/asm/arch-mx31/imx-regs.h |   14 ++++++++++
 3 files changed, 42 insertions(+), 13 deletions(-)
Anatolij Gustschin - Oct. 13, 2011, 9:23 a.m.
Hi Stefano,

On Thu, 13 Oct 2011 11:16:28 +0200
Anatolij Gustschin <agust@denx.de> wrote:

> From: Helmut Raiger <helmut.raiger@hale.at>
> 
> This additionally updates mx31/generic.c by
> - replacing __REG() macro accesses with readl() and writel()
> - providing macros for PDR0 and PLL bit accesses
> 
> Signed-off-by: Helmut Raiger <helmut.raiger@hale.at>
> Acked-by: Marek Vasut <marek.vasut@gmail.com>
> Signed-off-by: Anatolij Gustschin <agust@denx.de>
> Cc: Stefano Babic <sbabic@denx.de>
> ---
> Changes since v2:
>  - rebased to apply on current top of tree
> 
>  arch/arm/cpu/arm1136/mx31/generic.c       |   40 +++++++++++++++++++---------
>  arch/arm/include/asm/arch-mx31/clock.h    |    1 +
>  arch/arm/include/asm/arch-mx31/imx-regs.h |   14 ++++++++++
>  3 files changed, 42 insertions(+), 13 deletions(-)

Are you okay with this patch? Should I queue it with another
(video: Moving mx3fb.c to CONFIG_VIDEO) patch in my video tree?

Thanks,
Anatolij
--
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office@denx.de
Stefano Babic - Oct. 13, 2011, 9:40 a.m.
On 10/13/2011 11:23 AM, Anatolij Gustschin wrote:
> Hi Stefano,
> 
> On Thu, 13 Oct 2011 11:16:28 +0200
> Anatolij Gustschin <agust@denx.de> wrote:
> 
>> From: Helmut Raiger <helmut.raiger@hale.at>
>>
>> This additionally updates mx31/generic.c by
>> - replacing __REG() macro accesses with readl() and writel()
>> - providing macros for PDR0 and PLL bit accesses
>>
>> Signed-off-by: Helmut Raiger <helmut.raiger@hale.at>
>> Acked-by: Marek Vasut <marek.vasut@gmail.com>
>> Signed-off-by: Anatolij Gustschin <agust@denx.de>
>> Cc: Stefano Babic <sbabic@denx.de>
>> ---
>> Changes since v2:
>>  - rebased to apply on current top of tree
>>
>>  arch/arm/cpu/arm1136/mx31/generic.c       |   40 +++++++++++++++++++---------
>>  arch/arm/include/asm/arch-mx31/clock.h    |    1 +
>>  arch/arm/include/asm/arch-mx31/imx-regs.h |   14 ++++++++++
>>  3 files changed, 42 insertions(+), 13 deletions(-)
> 
> Are you okay with this patch?

Yes, they are ok - if not yet sent, here my:

Acked-by: Stefano Babic <sbabic@denx.de>


> Should I queue it with another
> (video: Moving mx3fb.c to CONFIG_VIDEO) patch in my video tree?

Yes, they belong together - we should assure that all three goes to
mainline in the same shot.

Thanks,
Stefano
Anatolij Gustschin - Oct. 14, 2011, 7:02 a.m.
On Thu, 13 Oct 2011 11:16:28 +0200
Anatolij Gustschin <agust@denx.de> wrote:

> From: Helmut Raiger <helmut.raiger@hale.at>
> 
> This additionally updates mx31/generic.c by
> - replacing __REG() macro accesses with readl() and writel()
> - providing macros for PDR0 and PLL bit accesses
> 
> Signed-off-by: Helmut Raiger <helmut.raiger@hale.at>
> Acked-by: Marek Vasut <marek.vasut@gmail.com>
> Signed-off-by: Anatolij Gustschin <agust@denx.de>
> Cc: Stefano Babic <sbabic@denx.de>
> ---
> Changes since v2:
>  - rebased to apply on current top of tree
> 
>  arch/arm/cpu/arm1136/mx31/generic.c       |   40 +++++++++++++++++++---------
>  arch/arm/include/asm/arch-mx31/clock.h    |    1 +
>  arch/arm/include/asm/arch-mx31/imx-regs.h |   14 ++++++++++
>  3 files changed, 42 insertions(+), 13 deletions(-)

Applied to u-boot-video master.

Anatolij

Patch

diff --git a/arch/arm/cpu/arm1136/mx31/generic.c b/arch/arm/cpu/arm1136/mx31/generic.c
index c6def5d..5524b23 100644
--- a/arch/arm/cpu/arm1136/mx31/generic.c
+++ b/arch/arm/cpu/arm1136/mx31/generic.c
@@ -28,10 +28,10 @@ 
 
 static u32 mx31_decode_pll(u32 reg, u32 infreq)
 {
-	u32 mfi = (reg >> 10) & 0xf;
-	u32 mfn = reg & 0x3ff;
-	u32 mfd = (reg >> 16) & 0x3ff;
-	u32 pd =  (reg >> 26) & 0xf;
+	u32 mfi = GET_PLL_MFI(reg);
+	u32 mfn = GET_PLL_MFN(reg);
+	u32 mfd = GET_PLL_MFD(reg);
+	u32 pd =  GET_PLL_PD(reg);
 
 	mfi = mfi <= 5 ? 5 : mfi;
 	mfd += 1;
@@ -45,12 +45,12 @@  static u32 mx31_get_mpl_dpdgck_clk(void)
 {
 	u32 infreq;
 
-	if ((__REG(CCM_CCMR) & CCMR_PRCS_MASK) == CCMR_FPM)
+	if ((readl(CCM_CCMR) & CCMR_PRCS_MASK) == CCMR_FPM)
 		infreq = CONFIG_MX31_CLK32 * 1024;
 	else
 		infreq = CONFIG_MX31_HCLK_FREQ;
 
-	return mx31_decode_pll(__REG(CCM_MPCTL), infreq);
+	return mx31_decode_pll(readl(CCM_MPCTL), infreq);
 }
 
 static u32 mx31_get_mcu_main_clk(void)
@@ -64,10 +64,21 @@  static u32 mx31_get_mcu_main_clk(void)
 static u32 mx31_get_ipg_clk(void)
 {
 	u32 freq = mx31_get_mcu_main_clk();
-	u32 pdr0 = __REG(CCM_PDR0);
+	u32 pdr0 = readl(CCM_PDR0);
 
-	freq /= ((pdr0 >> 3) & 0x7) + 1;
-	freq /= ((pdr0 >> 6) & 0x3) + 1;
+	freq /= GET_PDR0_MAX_PODF(pdr0) + 1;
+	freq /= GET_PDR0_IPG_PODF(pdr0) + 1;
+
+	return freq;
+}
+
+/* hsp is the clock for the ipu */
+static u32 mx31_get_hsp_clk(void)
+{
+	u32 freq = mx31_get_mcu_main_clk();
+	u32 pdr0 = readl(CCM_PDR0);
+
+	freq /= GET_PDR0_HSP_PODF(pdr0) + 1;
 
 	return freq;
 }
@@ -77,6 +88,7 @@  void mx31_dump_clocks(void)
 	u32 cpufreq = mx31_get_mcu_main_clk();
 	printf("mx31 cpu clock: %dMHz\n",cpufreq / 1000000);
 	printf("ipg clock     : %dHz\n", mx31_get_ipg_clk());
+	printf("hsp clock     : %dHz\n", mx31_get_hsp_clk());
 }
 
 unsigned int mxc_get_clock(enum mxc_clock clk)
@@ -89,6 +101,8 @@  unsigned int mxc_get_clock(enum mxc_clock clk)
 	case MXC_CSPI_CLK:
 	case MXC_UART_CLK:
 		return mx31_get_ipg_clk();
+	case MXC_IPU_CLK:
+		return mx31_get_hsp_clk();
 	}
 	return -1;
 }
@@ -105,10 +119,10 @@  void mx31_gpio_mux(unsigned long mode)
 	reg = IOMUXC_BASE + (mode & 0x1fc);
 	shift = (~mode & 0x3) * 8;
 
-	tmp = __REG(reg);
+	tmp = readl(reg);
 	tmp &= ~(0xff << shift);
 	tmp |= ((mode >> IOMUX_MODE_POS) & 0xff) << shift;
-	__REG(reg) = tmp;
+	writel(tmp, reg);
 }
 
 void mx31_set_pad(enum iomux_pins pin, u32 config)
@@ -119,10 +133,10 @@  void mx31_set_pad(enum iomux_pins pin, u32 config)
 	reg = (IOMUXC_BASE + 0x154) + (pin + 2) / 3 * 4;
 	field = (pin + 2) % 3;
 
-	l = __REG(reg);
+	l = readl(reg);
 	l &= ~(0x1ff << (field * 10));
 	l |= config << (field * 10);
-	__REG(reg) = l;
+	writel(l, reg);
 
 }
 
diff --git a/arch/arm/include/asm/arch-mx31/clock.h b/arch/arm/include/asm/arch-mx31/clock.h
index cc99a75..2e3bce2 100644
--- a/arch/arm/include/asm/arch-mx31/clock.h
+++ b/arch/arm/include/asm/arch-mx31/clock.h
@@ -30,6 +30,7 @@  enum mxc_clock {
 	MXC_IPG_PERCLK,
 	MXC_CSPI_CLK,
 	MXC_UART_CLK,
+	MXC_IPU_CLK
 };
 
 unsigned int mxc_get_clock(enum mxc_clock clk);
diff --git a/arch/arm/include/asm/arch-mx31/imx-regs.h b/arch/arm/include/asm/arch-mx31/imx-regs.h
index 0dcd9fe..f263e6b 100644
--- a/arch/arm/include/asm/arch-mx31/imx-regs.h
+++ b/arch/arm/include/asm/arch-mx31/imx-regs.h
@@ -513,6 +513,20 @@  enum iomux_pins {
 #define PLL_MFI(x)		(((x) & 0xf) << 10)
 #define PLL_MFN(x)		(((x) & 0x3ff) << 0)
 
+#define GET_PDR0_CSI_PODF(x)	(((x) >> 23) & 0x1ff)
+#define GET_PDR0_PER_PODF(x)	(((x) >> 16) & 0x1f)
+#define GET_PDR0_HSP_PODF(x)	(((x) >> 11) & 0x7)
+#define GET_PDR0_NFC_PODF(x)	(((x) >> 8) & 0x7)
+#define GET_PDR0_IPG_PODF(x)	(((x) >> 6) & 0x3)
+#define GET_PDR0_MAX_PODF(x)	(((x) >> 3) & 0x7)
+#define GET_PDR0_MCU_PODF(x)	((x) & 0x7)
+
+#define GET_PLL_PD(x)		(((x) >> 26) & 0xf)
+#define GET_PLL_MFD(x)		(((x) >> 16) & 0x3ff)
+#define GET_PLL_MFI(x)		(((x) >> 10) & 0xf)
+#define GET_PLL_MFN(x)		(((x) >> 0) & 0x3ff)
+
+
 #define WEIM_ESDCTL0	0xB8001000
 #define WEIM_ESDCFG0	0xB8001004
 #define WEIM_ESDCTL1	0xB8001008