| Message ID | 20191031134310.3072-16-sjg@chromium.org |
|---|---|
| State | Accepted |
| Headers | show |
| Series | scripts: Convert to Python 3 | expand |
On Thu, Oct 31, 2019 at 07:43:05AM -0600, Simon Glass wrote: > Update this tool to use Python 3 to meet the 2020 deadline. > > Unfortunately this introduces a test failure due to a problem in pylibfdt > on Python 3. I will investigate. > > Signed-off-by: Simon Glass <sjg@chromium.org> > --- > > Changes in v2: > - Add a few more patches to correct remaining problems Is there still a failure or did you fix it? If there still is, what board(s) make use of that feature? Thanks!
Hi Tom, On Thu, 31 Oct 2019 at 07:55, Tom Rini <trini@konsulko.com> wrote: > > On Thu, Oct 31, 2019 at 07:43:05AM -0600, Simon Glass wrote: > > > Update this tool to use Python 3 to meet the 2020 deadline. > > > > Unfortunately this introduces a test failure due to a problem in pylibfdt > > on Python 3. I will investigate. > > > > Signed-off-by: Simon Glass <sjg@chromium.org> > > --- > > > > Changes in v2: > > - Add a few more patches to correct remaining problems > > Is there still a failure or did you fix it? If there still is, what > board(s) make use of that feature? Thanks! > Everything works fine now, so far as I can tell. The pylibfdt fix was accepted upstream, too. Regards, Simon
On Thu, Oct 31, 2019 at 09:19:50AM -0600, Simon Glass wrote: > Hi Tom, > > On Thu, 31 Oct 2019 at 07:55, Tom Rini <trini@konsulko.com> wrote: > > > > On Thu, Oct 31, 2019 at 07:43:05AM -0600, Simon Glass wrote: > > > > > Update this tool to use Python 3 to meet the 2020 deadline. > > > > > > Unfortunately this introduces a test failure due to a problem in pylibfdt > > > on Python 3. I will investigate. > > > > > > Signed-off-by: Simon Glass <sjg@chromium.org> > > > --- > > > > > > Changes in v2: > > > - Add a few more patches to correct remaining problems > > > > Is there still a failure or did you fix it? If there still is, what > > board(s) make use of that feature? Thanks! > > > > Everything works fine now, so far as I can tell. The pylibfdt fix was > accepted upstream, too. OK, so a v3 to fix the commit message :) Do you want to pull all of this together in the end and give me a PR or do you want me to (and kick Azure/Travis/GitLab as needed) ?
Hi Tom, On Thu, 31 Oct 2019 at 09:50, Tom Rini <trini@konsulko.com> wrote: > > On Thu, Oct 31, 2019 at 09:19:50AM -0600, Simon Glass wrote: > > Hi Tom, > > > > On Thu, 31 Oct 2019 at 07:55, Tom Rini <trini@konsulko.com> wrote: > > > > > > On Thu, Oct 31, 2019 at 07:43:05AM -0600, Simon Glass wrote: > > > > > > > Update this tool to use Python 3 to meet the 2020 deadline. > > > > > > > > Unfortunately this introduces a test failure due to a problem in pylibfdt > > > > on Python 3. I will investigate. > > > > > > > > Signed-off-by: Simon Glass <sjg@chromium.org> > > > > --- > > > > > > > > Changes in v2: > > > > - Add a few more patches to correct remaining problems > > > > > > Is there still a failure or did you fix it? If there still is, what > > > board(s) make use of that feature? Thanks! > > > > > > > Everything works fine now, so far as I can tell. The pylibfdt fix was > > accepted upstream, too. > > OK, so a v3 to fix the commit message :) Do you want to pull all of > this together in the end and give me a PR or do you want me to (and kick > Azure/Travis/GitLab as needed) ? Ooops, OK, will do. I am happy to do either. I got a successful run. The latest one is going here, but only has commit-message changes: https://gitlab.denx.de/u-boot/custodians/u-boot-dm/pipelines/1181 Regards, Simon > > -- > Tom
On Thu, Oct 31, 2019 at 10:12:04AM -0600, Simon Glass wrote: > Hi Tom, > > On Thu, 31 Oct 2019 at 09:50, Tom Rini <trini@konsulko.com> wrote: > > > > On Thu, Oct 31, 2019 at 09:19:50AM -0600, Simon Glass wrote: > > > Hi Tom, > > > > > > On Thu, 31 Oct 2019 at 07:55, Tom Rini <trini@konsulko.com> wrote: > > > > > > > > On Thu, Oct 31, 2019 at 07:43:05AM -0600, Simon Glass wrote: > > > > > > > > > Update this tool to use Python 3 to meet the 2020 deadline. > > > > > > > > > > Unfortunately this introduces a test failure due to a problem in pylibfdt > > > > > on Python 3. I will investigate. > > > > > > > > > > Signed-off-by: Simon Glass <sjg@chromium.org> > > > > > --- > > > > > > > > > > Changes in v2: > > > > > - Add a few more patches to correct remaining problems > > > > > > > > Is there still a failure or did you fix it? If there still is, what > > > > board(s) make use of that feature? Thanks! > > > > > > > > > > Everything works fine now, so far as I can tell. The pylibfdt fix was > > > accepted upstream, too. > > > > OK, so a v3 to fix the commit message :) Do you want to pull all of > > this together in the end and give me a PR or do you want me to (and kick > > Azure/Travis/GitLab as needed) ? > > Ooops, OK, will do. > > I am happy to do either. I got a successful run. The latest one is > going here, but only has commit-message changes: > > https://gitlab.denx.de/u-boot/custodians/u-boot-dm/pipelines/1181 OK. Can you please put together a fdt PR with those changes and then I'll grab all of the rest of the Python stuff and make sure all the CIs pass? Thanks again!
On Thu, Oct 31, 2019 at 10:12:04AM -0600, Simon Glass wrote: > Hi Tom, > > On Thu, 31 Oct 2019 at 09:50, Tom Rini <trini@konsulko.com> wrote: > > > > On Thu, Oct 31, 2019 at 09:19:50AM -0600, Simon Glass wrote: > > > Hi Tom, > > > > > > On Thu, 31 Oct 2019 at 07:55, Tom Rini <trini@konsulko.com> wrote: > > > > > > > > On Thu, Oct 31, 2019 at 07:43:05AM -0600, Simon Glass wrote: > > > > > > > > > Update this tool to use Python 3 to meet the 2020 deadline. > > > > > > > > > > Unfortunately this introduces a test failure due to a problem in pylibfdt > > > > > on Python 3. I will investigate. > > > > > > > > > > Signed-off-by: Simon Glass <sjg@chromium.org> > > > > > --- > > > > > > > > > > Changes in v2: > > > > > - Add a few more patches to correct remaining problems > > > > > > > > Is there still a failure or did you fix it? If there still is, what > > > > board(s) make use of that feature? Thanks! > > > > > > > > > > Everything works fine now, so far as I can tell. The pylibfdt fix was > > > accepted upstream, too. > > > > OK, so a v3 to fix the commit message :) Do you want to pull all of > > this together in the end and give me a PR or do you want me to (and kick > > Azure/Travis/GitLab as needed) ? > > Ooops, OK, will do. > > I am happy to do either. I got a successful run. The latest one is > going here, but only has commit-message changes: > > https://gitlab.denx.de/u-boot/custodians/u-boot-dm/pipelines/1181 OK. Can you please put together a fdt PR with those changes and then I'll grab all of the rest of the Python stuff and make sure all the CIs pass? Thanks again!
diff --git a/tools/binman/binman.py b/tools/binman/binman.py index 8bd5868df2..9e6fd72117 100755 --- a/tools/binman/binman.py +++ b/tools/binman/binman.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python2 +#!/usr/bin/env python3 # SPDX-License-Identifier: GPL-2.0+ # Copyright (c) 2016 Google, Inc
Update this tool to use Python 3 to meet the 2020 deadline. Unfortunately this introduces a test failure due to a problem in pylibfdt on Python 3. I will investigate. Signed-off-by: Simon Glass <sjg@chromium.org> --- Changes in v2: - Add a few more patches to correct remaining problems tools/binman/binman.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)