| Message ID | ff5c26cdf3bb2d917704e8a3632b732615a98795.1571853833.git.bob.beckett@collabora.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Stefano Babic |
| Headers | show |
| Series | convert GE boards to DM | expand |
On Wed, Oct 23, 2019 at 3:36 PM Robert Beckett <bob.beckett@collabora.com> wrote: > > Add compatible string for imx53 and imx21. > > Signed-off-by: Robert Beckett <bob.beckett@collabora.com> > --- > drivers/serial/serial_mxc.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/serial/serial_mxc.c b/drivers/serial/serial_mxc.c > index 42abb96a26..8e19a89151 100644 > --- a/drivers/serial/serial_mxc.c > +++ b/drivers/serial/serial_mxc.c > @@ -348,6 +348,8 @@ static const struct udevice_id mxc_serial_ids[] = { > { .compatible = "fsl,imx6ul-uart" }, > { .compatible = "fsl,imx7d-uart" }, > { .compatible = "fsl,imx6q-uart" }, > + { .compatible = "fsl,imx53-uart" }, > + { .compatible = "fsl,imx21-uart" }, Looks like you are using an old codebase. U-Boot mainline already contains such compatible entries.
Hi Robert, > Add compatible string for imx53 and imx21. > > Signed-off-by: Robert Beckett <bob.beckett@collabora.com> > --- > drivers/serial/serial_mxc.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/serial/serial_mxc.c b/drivers/serial/serial_mxc.c > index 42abb96a26..8e19a89151 100644 > --- a/drivers/serial/serial_mxc.c > +++ b/drivers/serial/serial_mxc.c > @@ -348,6 +348,8 @@ static const struct udevice_id mxc_serial_ids[] = > { { .compatible = "fsl,imx6ul-uart" }, > { .compatible = "fsl,imx7d-uart" }, > { .compatible = "fsl,imx6q-uart" }, > + { .compatible = "fsl,imx53-uart" }, > + { .compatible = "fsl,imx21-uart" }, > { } > }; > #endif Thanks for your patch. However, please note that it shall be addressed also to i.MX maintainer (Stefano - CC'ed). To send patches to correct people (despite the assignment for reviewers in the patchwork) - please use patman python script. It generates list of relevant people to receive patch for review. Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
On Wed, 2019-10-23 at 15:38 -0300, Fabio Estevam wrote: > On Wed, Oct 23, 2019 at 3:36 PM Robert Beckett > <bob.beckett@collabora.com> wrote: > > Add compatible string for imx53 and imx21. > > > > Signed-off-by: Robert Beckett <bob.beckett@collabora.com> > > --- > > drivers/serial/serial_mxc.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/serial/serial_mxc.c > > b/drivers/serial/serial_mxc.c > > index 42abb96a26..8e19a89151 100644 > > --- a/drivers/serial/serial_mxc.c > > +++ b/drivers/serial/serial_mxc.c > > @@ -348,6 +348,8 @@ static const struct udevice_id mxc_serial_ids[] > > = { > > { .compatible = "fsl,imx6ul-uart" }, > > { .compatible = "fsl,imx7d-uart" }, > > { .compatible = "fsl,imx6q-uart" }, > > + { .compatible = "fsl,imx53-uart" }, > > + { .compatible = "fsl,imx21-uart" }, > > Looks like you are using an old codebase. > > U-Boot mainline already contains such compatible entries. huh, yeah. When it was originally written it didnt exist. During rebase to master while upstreaming, it applied cleanly because the added compatible strings were added at the top, so the existing patch context was still valid. Ill drop this patch.
On Thu, 2019-10-24 at 09:38 +0200, Lukasz Majewski wrote: > Hi Robert, > > > Add compatible string for imx53 and imx21. > > > > Signed-off-by: Robert Beckett <bob.beckett@collabora.com> > > --- > > drivers/serial/serial_mxc.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/serial/serial_mxc.c > > b/drivers/serial/serial_mxc.c > > index 42abb96a26..8e19a89151 100644 > > --- a/drivers/serial/serial_mxc.c > > +++ b/drivers/serial/serial_mxc.c > > @@ -348,6 +348,8 @@ static const struct udevice_id mxc_serial_ids[] > > = > > { { .compatible = "fsl,imx6ul-uart" }, > > { .compatible = "fsl,imx7d-uart" }, > > { .compatible = "fsl,imx6q-uart" }, > > + { .compatible = "fsl,imx53-uart" }, > > + { .compatible = "fsl,imx21-uart" }, > > { } > > }; > > #endif > > Thanks for your patch. However, please note that it shall be > addressed > also to i.MX maintainer (Stefano - CC'ed). > > To send patches to correct people (despite the assignment for > reviewers > in the patchwork) - please use patman python script. It generates > list > of relevant people to receive patch for review. Thanks. I used get_maintainer.pl as part of sending via git send-email. I did try setting up patman, but it crashes so much trying to find aliases that dont exist, I gave up adding dummy aliases, and just used get_maintainer. Perhaps I should try to figure out how to get it working before the next submission. > > Best regards, > > Lukasz Majewski > > -- > > DENX Software Engineering GmbH, Managing Director: Wolfgang Denk > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: > lukma@denx.de
Hi Robert, > On Thu, 2019-10-24 at 09:38 +0200, Lukasz Majewski wrote: > > Hi Robert, > > > > > Add compatible string for imx53 and imx21. > > > > > > Signed-off-by: Robert Beckett <bob.beckett@collabora.com> > > > --- > > > drivers/serial/serial_mxc.c | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/drivers/serial/serial_mxc.c > > > b/drivers/serial/serial_mxc.c > > > index 42abb96a26..8e19a89151 100644 > > > --- a/drivers/serial/serial_mxc.c > > > +++ b/drivers/serial/serial_mxc.c > > > @@ -348,6 +348,8 @@ static const struct udevice_id > > > mxc_serial_ids[] = > > > { { .compatible = "fsl,imx6ul-uart" }, > > > { .compatible = "fsl,imx7d-uart" }, > > > { .compatible = "fsl,imx6q-uart" }, > > > + { .compatible = "fsl,imx53-uart" }, > > > + { .compatible = "fsl,imx21-uart" }, > > > { } > > > }; > > > #endif > > > > Thanks for your patch. However, please note that it shall be > > addressed > > also to i.MX maintainer (Stefano - CC'ed). > > > > To send patches to correct people (despite the assignment for > > reviewers > > in the patchwork) - please use patman python script. It generates > > list > > of relevant people to receive patch for review. > > Thanks. I used get_maintainer.pl as part of sending via git > send-email. I did try setting up patman, but it crashes so much > trying to find aliases that dont exist, I gave up adding dummy > aliases, and just used get_maintainer. > Perhaps I should try to figure out how to get it working before the > next submission. I always use -i option (ignore bad tags) and -n (dry run). ./tools/patman/patman -c1 -s0 -t -i -s0 is to start from top of the HEAD -c1 to send one patch > > > > > Best regards, > > > > Lukasz Majewski > > > > -- > > > > DENX Software Engineering GmbH, Managing Director: Wolfgang > > Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, > > Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: > > lukma@denx.de > Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
diff --git a/drivers/serial/serial_mxc.c b/drivers/serial/serial_mxc.c index 42abb96a26..8e19a89151 100644 --- a/drivers/serial/serial_mxc.c +++ b/drivers/serial/serial_mxc.c @@ -348,6 +348,8 @@ static const struct udevice_id mxc_serial_ids[] = { { .compatible = "fsl,imx6ul-uart" }, { .compatible = "fsl,imx7d-uart" }, { .compatible = "fsl,imx6q-uart" }, + { .compatible = "fsl,imx53-uart" }, + { .compatible = "fsl,imx21-uart" }, { } }; #endif
Add compatible string for imx53 and imx21. Signed-off-by: Robert Beckett <bob.beckett@collabora.com> --- drivers/serial/serial_mxc.c | 2 ++ 1 file changed, 2 insertions(+)