| Message ID | 4E8D884A.7040405@gjlay.de |
|---|---|
| State | New |
| Headers | show |
On Thu, Oct 6, 2011 at 12:51 PM, Georg-Johann Lay <avr@gjlay.de> wrote: > Artem Shinkarov schrieb: >> Hi, Richard >> >> There is a problem with the testcases of the patch you have committed >> for me. The code in every test-case is doubled. Could you please, >> apply the following patch, otherwise it would fail all the tests from >> the vector-shuffle-patch would fail. >> >> Also, if it is possible, could you change my name from in the >> ChangeLog from "Artem Shinkarov" to "Artjoms Sinkarovs". The last >> version is the way I am spelled in the passport, and the name I use in >> the ChangeLog. >> >> Thanks, >> Artem. >> >> On Mon, Oct 3, 2011 at 4:13 PM, Richard Henderson <rth@redhat.com> wrote: >>> On 10/03/2011 05:14 AM, Artem Shinkarov wrote: >>>> Hi, can anyone commit it please? >>>> >>>> Richard? >>>> Or may be Richard? >>> Committed. >>> >>> r~ >>> >> Hi, Richard >> >> There is a problem with the testcases of the patch you have committed >> for me. The code in every test-case is doubled. Could you please, >> apply the following patch, otherwise it would fail all the tests from >> the vector-shuffle-patch would fail. >> >> Also, if it is possible, could you change my name from in the >> ChangeLog from "Artem Shinkarov" to "Artjoms Sinkarovs". The last >> version is the way I am spelled in the passport, and the name I use in >> the ChangeLog. >> >> >> Thanks, >> Artem. >> > > The following test cases cause FAILs because main cannot be found by the linker > because if __SIZEOF_INT__ != 4 you are trying to compile and run an empty file. > >> Index: gcc/testsuite/gcc.c-torture/execute/vect-shuffle-1.c > >> Index: gcc/testsuite/gcc.c-torture/execute/vect-shuffle-5.c > > The following patch avoids __SIZEOF_INT__. > > Ok by some maintainer to commit? On a general note, if you need to add .x files, consider moving the test to gcc.dg/torture instead. Richard. > Johann > > testsuite/ > * lib/target-supports.exp (check_effective_target_int32): New > function. > * gcc.c-torture/execute/vect-shuffle-1.c: Don't use > __SIZEOF_INT__. > * gcc.c-torture/execute/vect-shuffle-5.c: Ditto. > * gcc.c-torture/execute/vect-shuffle-1.x: New file. > * gcc.c-torture/execute/vect-shuffle-5.x: New file. > >
Richard Guenther schrieb: > On Thu, Oct 6, 2011 at 12:51 PM, Georg-Johann Lay <avr@gjlay.de> wrote: >> Artem Shinkarov schrieb: >>> Hi, Richard >>> >>> There is a problem with the testcases of the patch you have committed >>> for me. The code in every test-case is doubled. Could you please, >>> apply the following patch, otherwise it would fail all the tests from >>> the vector-shuffle-patch would fail. >>> >>> Also, if it is possible, could you change my name from in the >>> ChangeLog from "Artem Shinkarov" to "Artjoms Sinkarovs". The last >>> version is the way I am spelled in the passport, and the name I use in >>> the ChangeLog. >>> >>> Thanks, >>> Artem. >>> >>> On Mon, Oct 3, 2011 at 4:13 PM, Richard Henderson <rth@redhat.com> wrote: >>>> On 10/03/2011 05:14 AM, Artem Shinkarov wrote: >>>>> Hi, can anyone commit it please? >>>>> >>>>> Richard? >>>>> Or may be Richard? >>>> Committed. >>>> >>>> r~ >>>> >>> Hi, Richard >>> >>> There is a problem with the testcases of the patch you have committed >>> for me. The code in every test-case is doubled. Could you please, >>> apply the following patch, otherwise it would fail all the tests from >>> the vector-shuffle-patch would fail. >>> >>> Also, if it is possible, could you change my name from in the >>> ChangeLog from "Artem Shinkarov" to "Artjoms Sinkarovs". The last >>> version is the way I am spelled in the passport, and the name I use in >>> the ChangeLog. >>> >>> >>> Thanks, >>> Artem. >>> >> The following test cases cause FAILs because main cannot be found by the linker >> because if __SIZEOF_INT__ != 4 you are trying to compile and run an empty file. >> >>> Index: gcc/testsuite/gcc.c-torture/execute/vect-shuffle-1.c >>> Index: gcc/testsuite/gcc.c-torture/execute/vect-shuffle-5.c >> The following patch avoids __SIZEOF_INT__. >> >> Ok by some maintainer to commit? > > On a general note, if you need to add .x files, consider moving the > test to gcc.dg/torture instead. So should I move all vect-shuffle-*.c files so that they are kept together? Johann > Richard. > >> Johann >> >> testsuite/ >> * lib/target-supports.exp (check_effective_target_int32): New >> function. >> * gcc.c-torture/execute/vect-shuffle-1.c: Don't use >> __SIZEOF_INT__. >> * gcc.c-torture/execute/vect-shuffle-5.c: Ditto. >> * gcc.c-torture/execute/vect-shuffle-1.x: New file. >> * gcc.c-torture/execute/vect-shuffle-5.x: New file.
On Thu, Oct 6, 2011 at 1:03 PM, Georg-Johann Lay <avr@gjlay.de> wrote: > Richard Guenther schrieb: >> On Thu, Oct 6, 2011 at 12:51 PM, Georg-Johann Lay <avr@gjlay.de> wrote: >>> Artem Shinkarov schrieb: >>>> Hi, Richard >>>> >>>> There is a problem with the testcases of the patch you have committed >>>> for me. The code in every test-case is doubled. Could you please, >>>> apply the following patch, otherwise it would fail all the tests from >>>> the vector-shuffle-patch would fail. >>>> >>>> Also, if it is possible, could you change my name from in the >>>> ChangeLog from "Artem Shinkarov" to "Artjoms Sinkarovs". The last >>>> version is the way I am spelled in the passport, and the name I use in >>>> the ChangeLog. >>>> >>>> Thanks, >>>> Artem. >>>> >>>> On Mon, Oct 3, 2011 at 4:13 PM, Richard Henderson <rth@redhat.com> wrote: >>>>> On 10/03/2011 05:14 AM, Artem Shinkarov wrote: >>>>>> Hi, can anyone commit it please? >>>>>> >>>>>> Richard? >>>>>> Or may be Richard? >>>>> Committed. >>>>> >>>>> r~ >>>>> >>>> Hi, Richard >>>> >>>> There is a problem with the testcases of the patch you have committed >>>> for me. The code in every test-case is doubled. Could you please, >>>> apply the following patch, otherwise it would fail all the tests from >>>> the vector-shuffle-patch would fail. >>>> >>>> Also, if it is possible, could you change my name from in the >>>> ChangeLog from "Artem Shinkarov" to "Artjoms Sinkarovs". The last >>>> version is the way I am spelled in the passport, and the name I use in >>>> the ChangeLog. >>>> >>>> >>>> Thanks, >>>> Artem. >>>> >>> The following test cases cause FAILs because main cannot be found by the linker >>> because if __SIZEOF_INT__ != 4 you are trying to compile and run an empty file. >>> >>>> Index: gcc/testsuite/gcc.c-torture/execute/vect-shuffle-1.c >>>> Index: gcc/testsuite/gcc.c-torture/execute/vect-shuffle-5.c >>> The following patch avoids __SIZEOF_INT__. >>> >>> Ok by some maintainer to commit? >> >> On a general note, if you need to add .x files, consider moving the >> test to gcc.dg/torture instead. > > So should I move all vect-shuffle-*.c files so that they are kept together? Yes. > Johann > >> Richard. >> >>> Johann >>> >>> testsuite/ >>> * lib/target-supports.exp (check_effective_target_int32): New >>> function. >>> * gcc.c-torture/execute/vect-shuffle-1.c: Don't use >>> __SIZEOF_INT__. >>> * gcc.c-torture/execute/vect-shuffle-5.c: Ditto. >>> * gcc.c-torture/execute/vect-shuffle-1.x: New file. >>> * gcc.c-torture/execute/vect-shuffle-5.x: New file. >
On Thu, Oct 06, 2011 at 12:51:54PM +0200, Georg-Johann Lay wrote: > The following patch avoids __SIZEOF_INT__. > > Ok by some maintainer to commit? That is unnecessary. You can just add #else int main () { return 0; } before the final #endif in the files instead. Or move around the #ifdefs, so that it ifdefs out for weirdo targets just everything before main and then also main's body except for return 0; at the end. Jakub
Index: lib/target-supports.exp =================================================================== --- lib/target-supports.exp (revision 179599) +++ lib/target-supports.exp (working copy) @@ -1583,6 +1583,15 @@ proc check_effective_target_int16 { } { }] } +# Returns 1 if we're generating 32-bit integers with the +# default options, 0 otherwise. + +proc check_effective_target_int32 { } { + return [check_no_compiler_messages int32 object { + int dummy[sizeof (int) == 4 ? 1 : -1]; + }] +} + # Return 1 if we're generating 64-bit code using default options, 0 # otherwise. Index: gcc.c-torture/execute/vect-shuffle-1.c =================================================================== --- gcc.c-torture/execute/vect-shuffle-1.c (revision 179599) +++ gcc.c-torture/execute/vect-shuffle-1.c (working copy) @@ -1,4 +1,3 @@ -#if __SIZEOF_INT__ == 4 typedef unsigned int V __attribute__((vector_size(16), may_alias)); struct S @@ -64,5 +63,3 @@ int main() return 0; } - -#endif /* SIZEOF_INT */ Index: gcc.c-torture/execute/vect-shuffle-1.x =================================================================== --- gcc.c-torture/execute/vect-shuffle-1.x (revision 0) +++ gcc.c-torture/execute/vect-shuffle-1.x (revision 0) @@ -0,0 +1,7 @@ +load_lib target-supports.exp + +if { [check_effective_target_int32] } { + return 0 +} + +return 1; Index: gcc.c-torture/execute/vect-shuffle-5.c =================================================================== --- gcc.c-torture/execute/vect-shuffle-5.c (revision 179599) +++ gcc.c-torture/execute/vect-shuffle-5.c (working copy) @@ -1,4 +1,3 @@ -#if __SIZEOF_INT__ == 4 typedef unsigned int V __attribute__((vector_size(16), may_alias)); struct S @@ -60,5 +59,3 @@ int main() return 0; } - -#endif /* SIZEOF_INT */ Index: gcc.c-torture/execute/vect-shuffle-5.x =================================================================== --- gcc.c-torture/execute/vect-shuffle-5.x (revision 0) +++ gcc.c-torture/execute/vect-shuffle-5.x (revision 0) @@ -0,0 +1,7 @@ +load_lib target-supports.exp + +if { [check_effective_target_int32] } { + return 0 +} + +return 1;