From patchwork Thu Oct 6 10:51:54 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Georg-Johann Lay X-Patchwork-Id: 118040 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id B59A6B6FF5 for ; Thu, 6 Oct 2011 21:52:36 +1100 (EST) Received: (qmail 23352 invoked by alias); 6 Oct 2011 10:52:30 -0000 Received: (qmail 23341 invoked by uid 22791); 6 Oct 2011 10:52:28 -0000 X-SWARE-Spam-Status: No, hits=-1.5 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_NONE X-Spam-Check-By: sourceware.org Received: from mo-p00-ob.rzone.de (HELO mo-p00-ob.rzone.de) (81.169.146.161) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 06 Oct 2011 10:52:13 +0000 X-RZG-AUTH: :LXoWVUeid/7A29J/hMvvT2k715jHQaJercGObUOFkj18odoYNahU4Q== X-RZG-CLASS-ID: mo00 Received: from [192.168.0.22] (business-188-111-022-002.static.arcor-ip.net [188.111.22.2]) by smtp.strato.de (cohen mo21) (RZmta 26.10 AUTH) with ESMTPA id 603ebcn968weCR ; Thu, 6 Oct 2011 12:51:54 +0200 (MEST) Message-ID: <4E8D884A.7040405@gjlay.de> Date: Thu, 06 Oct 2011 12:51:54 +0200 From: Georg-Johann Lay User-Agent: Thunderbird 2.0.0.24 (X11/20100302) MIME-Version: 1.0 To: Artem Shinkarov CC: Richard Henderson , "Joseph S. Myers" , Richard Guenther , Duncan Sands , gcc-patches@gcc.gnu.org Subject: Re: Vector shuffling References: <4E724C78.6020006@redhat.com> <4E83332D.1010002@redhat.com> <4E848D45.5000001@redhat.com> <4E86080A.7000009@redhat.com> <4E863399.6020803@redhat.com> <4E89D11A.1020707@redhat.com> In-Reply-To: X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Artem Shinkarov schrieb: > Hi, Richard > > There is a problem with the testcases of the patch you have committed > for me. The code in every test-case is doubled. Could you please, > apply the following patch, otherwise it would fail all the tests from > the vector-shuffle-patch would fail. > > Also, if it is possible, could you change my name from in the > ChangeLog from "Artem Shinkarov" to "Artjoms Sinkarovs". The last > version is the way I am spelled in the passport, and the name I use in > the ChangeLog. > > Thanks, > Artem. > > On Mon, Oct 3, 2011 at 4:13 PM, Richard Henderson wrote: >> On 10/03/2011 05:14 AM, Artem Shinkarov wrote: >>> Hi, can anyone commit it please? >>> >>> Richard? >>> Or may be Richard? >> Committed. >> >> r~ >> > Hi, Richard > > There is a problem with the testcases of the patch you have committed > for me. The code in every test-case is doubled. Could you please, > apply the following patch, otherwise it would fail all the tests from > the vector-shuffle-patch would fail. > > Also, if it is possible, could you change my name from in the > ChangeLog from "Artem Shinkarov" to "Artjoms Sinkarovs". The last > version is the way I am spelled in the passport, and the name I use in > the ChangeLog. > > > Thanks, > Artem. > The following test cases cause FAILs because main cannot be found by the linker because if __SIZEOF_INT__ != 4 you are trying to compile and run an empty file. > Index: gcc/testsuite/gcc.c-torture/execute/vect-shuffle-1.c > Index: gcc/testsuite/gcc.c-torture/execute/vect-shuffle-5.c The following patch avoids __SIZEOF_INT__. Ok by some maintainer to commit? Johann testsuite/ * lib/target-supports.exp (check_effective_target_int32): New function. * gcc.c-torture/execute/vect-shuffle-1.c: Don't use __SIZEOF_INT__. * gcc.c-torture/execute/vect-shuffle-5.c: Ditto. * gcc.c-torture/execute/vect-shuffle-1.x: New file. * gcc.c-torture/execute/vect-shuffle-5.x: New file. Index: lib/target-supports.exp =================================================================== --- lib/target-supports.exp (revision 179599) +++ lib/target-supports.exp (working copy) @@ -1583,6 +1583,15 @@ proc check_effective_target_int16 { } { }] } +# Returns 1 if we're generating 32-bit integers with the +# default options, 0 otherwise. + +proc check_effective_target_int32 { } { + return [check_no_compiler_messages int32 object { + int dummy[sizeof (int) == 4 ? 1 : -1]; + }] +} + # Return 1 if we're generating 64-bit code using default options, 0 # otherwise. Index: gcc.c-torture/execute/vect-shuffle-1.c =================================================================== --- gcc.c-torture/execute/vect-shuffle-1.c (revision 179599) +++ gcc.c-torture/execute/vect-shuffle-1.c (working copy) @@ -1,4 +1,3 @@ -#if __SIZEOF_INT__ == 4 typedef unsigned int V __attribute__((vector_size(16), may_alias)); struct S @@ -64,5 +63,3 @@ int main() return 0; } - -#endif /* SIZEOF_INT */ Index: gcc.c-torture/execute/vect-shuffle-1.x =================================================================== --- gcc.c-torture/execute/vect-shuffle-1.x (revision 0) +++ gcc.c-torture/execute/vect-shuffle-1.x (revision 0) @@ -0,0 +1,7 @@ +load_lib target-supports.exp + +if { [check_effective_target_int32] } { + return 0 +} + +return 1; Index: gcc.c-torture/execute/vect-shuffle-5.c =================================================================== --- gcc.c-torture/execute/vect-shuffle-5.c (revision 179599) +++ gcc.c-torture/execute/vect-shuffle-5.c (working copy) @@ -1,4 +1,3 @@ -#if __SIZEOF_INT__ == 4 typedef unsigned int V __attribute__((vector_size(16), may_alias)); struct S @@ -60,5 +59,3 @@ int main() return 0; } - -#endif /* SIZEOF_INT */ Index: gcc.c-torture/execute/vect-shuffle-5.x =================================================================== --- gcc.c-torture/execute/vect-shuffle-5.x (revision 0) +++ gcc.c-torture/execute/vect-shuffle-5.x (revision 0) @@ -0,0 +1,7 @@ +load_lib target-supports.exp + +if { [check_effective_target_int32] } { + return 0 +} + +return 1;