Message ID | 20191001235552.17790-1-jsnow@redhat.com |
---|---|
State | New |
Headers | show |
Patchew URL: https://patchew.org/QEMU/20191001235552.17790-1-jsnow@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20191001235552.17790-1-jsnow@redhat.com Subject: [PULL 0/8] Ide patches === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 1f9b401 hd-geo-test: Add tests for lchs override 7bfdda4 bootdevice: FW_CFG interface for LCHS values b6feb64 bootdevice: Refactor get_boot_devices_list ab60aa0 bootdevice: Gather LCHS from all relevant devices e12a839 scsi: Propagate unrealize() callback to scsi-hd e6f21f3 bootdevice: Add interface to gather LCHS 40120f4 block: Support providing LCHS from user adcf56d block: Refactor macros - fix tabbing === OUTPUT BEGIN === 1/8 Checking commit adcf56d080c9 (block: Refactor macros - fix tabbing) ERROR: Macros with complex values should be enclosed in parenthesis #57: FILE: include/hw/block/block.h:65: +#define DEFINE_BLOCK_CHS_PROPERTIES(_state, _conf) \ + DEFINE_PROP_UINT32("cyls", _state, _conf.cyls, 0), \ + DEFINE_PROP_UINT32("heads", _state, _conf.heads, 0), \ DEFINE_PROP_UINT32("secs", _state, _conf.secs, 0) total: 1 errors, 0 warnings, 37 lines checked Patch 1/8 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/8 Checking commit 40120f44b44f (block: Support providing LCHS from user) 3/8 Checking commit e6f21f35debf (bootdevice: Add interface to gather LCHS) 4/8 Checking commit e12a839d2b12 (scsi: Propagate unrealize() callback to scsi-hd) 5/8 Checking commit ab60aa0f51a5 (bootdevice: Gather LCHS from all relevant devices) 6/8 Checking commit b6feb64ebaef (bootdevice: Refactor get_boot_devices_list) 7/8 Checking commit 7bfdda4eaaf4 (bootdevice: FW_CFG interface for LCHS values) 8/8 Checking commit 1f9b401195bc (hd-geo-test: Add tests for lchs override) WARNING: Block comments use a leading /* on a separate line #650: FILE: tests/hd-geo-test.c:1003: + "skipping hd-geo/override/* tests"); total: 0 errors, 1 warnings, 616 lines checked Patch 8/8 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20191001235552.17790-1-jsnow@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
On 10/2/19 1:52 AM, no-reply@patchew.org wrote: > Patchew URL: https://patchew.org/QEMU/20191001235552.17790-1-jsnow@redhat.com/ > > > > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Type: series > Message-id: 20191001235552.17790-1-jsnow@redhat.com > Subject: [PULL 0/8] Ide patches > > === TEST SCRIPT BEGIN === > #!/bin/bash > git rev-parse base > /dev/null || exit 0 > git config --local diff.renamelimit 0 > git config --local diff.renames True > git config --local diff.algorithm histogram > ./scripts/checkpatch.pl --mailback base.. > === TEST SCRIPT END === > > Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 > Switched to a new branch 'test' > 1f9b401 hd-geo-test: Add tests for lchs override > 7bfdda4 bootdevice: FW_CFG interface for LCHS values > b6feb64 bootdevice: Refactor get_boot_devices_list > ab60aa0 bootdevice: Gather LCHS from all relevant devices > e12a839 scsi: Propagate unrealize() callback to scsi-hd > e6f21f3 bootdevice: Add interface to gather LCHS > 40120f4 block: Support providing LCHS from user > adcf56d block: Refactor macros - fix tabbing > > === OUTPUT BEGIN === > 1/8 Checking commit adcf56d080c9 (block: Refactor macros - fix tabbing) > ERROR: Macros with complex values should be enclosed in parenthesis > #57: FILE: include/hw/block/block.h:65: > +#define DEFINE_BLOCK_CHS_PROPERTIES(_state, _conf) \ > + DEFINE_PROP_UINT32("cyls", _state, _conf.cyls, 0), \ > + DEFINE_PROP_UINT32("heads", _state, _conf.heads, 0), \ > DEFINE_PROP_UINT32("secs", _state, _conf.secs, 0) > Pre-existing -- we just fixed whitespace damage. (Does it want parentheses around _state?) > total: 1 errors, 0 warnings, 37 lines checked > > Patch 1/8 has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > > 2/8 Checking commit 40120f44b44f (block: Support providing LCHS from user) > 3/8 Checking commit e6f21f35debf (bootdevice: Add interface to gather LCHS) > 4/8 Checking commit e12a839d2b12 (scsi: Propagate unrealize() callback to scsi-hd) > 5/8 Checking commit ab60aa0f51a5 (bootdevice: Gather LCHS from all relevant devices) > 6/8 Checking commit b6feb64ebaef (bootdevice: Refactor get_boot_devices_list) > 7/8 Checking commit 7bfdda4eaaf4 (bootdevice: FW_CFG interface for LCHS values) > 8/8 Checking commit 1f9b401195bc (hd-geo-test: Add tests for lchs override) > WARNING: Block comments use a leading /* on a separate line > #650: FILE: tests/hd-geo-test.c:1003: > + "skipping hd-geo/override/* tests"); > Genuine false-positive. > total: 0 errors, 1 warnings, 616 lines checked > > Patch 8/8 has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > === OUTPUT END === > > Test command exited with code: 1 > > > The full log is available at > http://patchew.org/logs/20191001235552.17790-1-jsnow@redhat.com/testing.checkpatch/?type=message. > --- > Email generated automatically by Patchew [https://patchew.org/]. > Please send your feedback to patchew-devel@redhat.com >
On Wed, 2 Oct 2019 at 00:56, John Snow <jsnow@redhat.com> wrote: > > The following changes since commit 7f21573c822805a8e6be379d9bcf3ad9effef3dc: > > Merge remote-tracking branch 'remotes/huth-gitlab/tags/pull-request-2019-10-01' into staging (2019-10-01 13:13:38 +0100) > > are available in the Git repository at: > > https://github.com/jnsnow/qemu.git tags/ide-pull-request > > for you to fetch changes up to d5eedf4633376d22a34a17a061d3ed47ddb6fee0: > > hd-geo-test: Add tests for lchs override (2019-10-01 17:50:16 -0400) > > ---------------------------------------------------------------- > "IDE" Pull request. (CHS changes for SeaBios) > > ---------------------------------------------------------------- > > Sam Eiderman (8): > block: Refactor macros - fix tabbing > block: Support providing LCHS from user > bootdevice: Add interface to gather LCHS > scsi: Propagate unrealize() callback to scsi-hd > bootdevice: Gather LCHS from all relevant devices > bootdevice: Refactor get_boot_devices_list > bootdevice: FW_CFG interface for LCHS values > hd-geo-test: Add tests for lchs override Hi John -- it looks like you forgot to put your signed-off-by as the maintainer on the commits in this pullreq. Could you fix that and resend, please? thanks -- PMM
On 10/3/19 11:35 AM, Peter Maydell wrote: > On Wed, 2 Oct 2019 at 00:56, John Snow <jsnow@redhat.com> wrote: >> >> The following changes since commit 7f21573c822805a8e6be379d9bcf3ad9effef3dc: >> >> Merge remote-tracking branch 'remotes/huth-gitlab/tags/pull-request-2019-10-01' into staging (2019-10-01 13:13:38 +0100) >> >> are available in the Git repository at: >> >> https://github.com/jnsnow/qemu.git tags/ide-pull-request >> >> for you to fetch changes up to d5eedf4633376d22a34a17a061d3ed47ddb6fee0: >> >> hd-geo-test: Add tests for lchs override (2019-10-01 17:50:16 -0400) >> >> ---------------------------------------------------------------- >> "IDE" Pull request. (CHS changes for SeaBios) >> >> ---------------------------------------------------------------- >> >> Sam Eiderman (8): >> block: Refactor macros - fix tabbing >> block: Support providing LCHS from user >> bootdevice: Add interface to gather LCHS >> scsi: Propagate unrealize() callback to scsi-hd >> bootdevice: Gather LCHS from all relevant devices >> bootdevice: Refactor get_boot_devices_list >> bootdevice: FW_CFG interface for LCHS values >> hd-geo-test: Add tests for lchs override > > Hi John -- it looks like you forgot to put your signed-off-by > as the maintainer on the commits in this pullreq. Could you > fix that and resend, please? > > thanks > -- PMM > I knew I'd forget something after reconfiguring git-publish :) Sorry about that.
On 10/3/19 11:35 AM, Peter Maydell wrote: > On Wed, 2 Oct 2019 at 00:56, John Snow <jsnow@redhat.com> wrote: >> >> The following changes since commit 7f21573c822805a8e6be379d9bcf3ad9effef3dc: >> >> Merge remote-tracking branch 'remotes/huth-gitlab/tags/pull-request-2019-10-01' into staging (2019-10-01 13:13:38 +0100) >> >> are available in the Git repository at: >> >> https://github.com/jnsnow/qemu.git tags/ide-pull-request >> >> for you to fetch changes up to d5eedf4633376d22a34a17a061d3ed47ddb6fee0: >> >> hd-geo-test: Add tests for lchs override (2019-10-01 17:50:16 -0400) >> >> ---------------------------------------------------------------- >> "IDE" Pull request. (CHS changes for SeaBios) >> >> ---------------------------------------------------------------- >> >> Sam Eiderman (8): >> block: Refactor macros - fix tabbing >> block: Support providing LCHS from user >> bootdevice: Add interface to gather LCHS >> scsi: Propagate unrealize() callback to scsi-hd >> bootdevice: Gather LCHS from all relevant devices >> bootdevice: Refactor get_boot_devices_list >> bootdevice: FW_CFG interface for LCHS values >> hd-geo-test: Add tests for lchs override > > Hi John -- it looks like you forgot to put your signed-off-by > as the maintainer on the commits in this pullreq. Could you > fix that and resend, please? > ... I see what happened now, actually. The emails got signed but the commits didn't. I didn't sign them when I applied the patches, but I signed them when using git-publish --pull-request --signoff, and it applies the signature before send, but after mirroring. I'll try to fix that when I have the time to make sure it doesn't happen again. --js