diff mbox series

[OpenWrt-Devel,v2,2/2] ath79: Restore GL.iNet GL-AR300M-Lite first-boot connectivity

Message ID 20190928173958.20199-2-lede@allycomm.com
State Accepted, archived
Delegated to: Christian Lamparter
Headers show
Series None | expand

Commit Message

Jeff Kletsky Sept. 28, 2019, 5:39 p.m. UTC 
From: Jeff Kletsky <git-commits@allycomm.com>

The relationship between GMAC0 and GMAC1 and the kernel devices
eth0 and eth1 was reversed for many ath79 devices by commit 8dde11d521
ath79: dts: drop "simple-mfd" for gmacs in SoC dtsi

The GL-AR300M-Lite is a single-port device, with the "LAN" port of the
GL-AR300M board unpopulated and its sole port now referenced as eth1,
as a result of commit 8dde11d521. The device was unreachable on
first boot or fresh config.

By changing &eth1 (GMAC1) to an MFD, GMAC0 is able to associate with
the phy and is known by the kernel as "eth0".

Thanks to Chuanhong Guo for the suggestion of "simple-mfd"

Signed-off-by: Jeff Kletsky <git-commits@allycomm.com>
---
 target/linux/ath79/dts/qca9531_glinet_gl-ar300m-lite.dts | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

Comments

Alberto Bursi Sept. 28, 2019, 6:41 p.m. UTC | #1 
On 28/09/19 19:39, Jeff Kletsky wrote:
> From: Jeff Kletsky <git-commits@allycomm.com>
>
> The relationship between GMAC0 and GMAC1 and the kernel devices
> eth0 and eth1 was reversed for many ath79 devices by commit 8dde11d521
> ath79: dts: drop "simple-mfd" for gmacs in SoC dtsi
>
> The GL-AR300M-Lite is a single-port device, with the "LAN" port of the
> GL-AR300M board unpopulated and its sole port now referenced as eth1,
> as a result of commit 8dde11d521. The device was unreachable on
> first boot or fresh config.
>
> By changing &eth1 (GMAC1) to an MFD, GMAC0 is able to associate with
> the phy and is known by the kernel as "eth0".
>
> Thanks to Chuanhong Guo for the suggestion of "simple-mfd"
>
> Signed-off-by: Jeff Kletsky <git-commits@allycomm.com>
> ---
>   target/linux/ath79/dts/qca9531_glinet_gl-ar300m-lite.dts | 6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/target/linux/ath79/dts/qca9531_glinet_gl-ar300m-lite.dts b/target/linux/ath79/dts/qca9531_glinet_gl-ar300m-lite.dts
> index fba08e4295..e29af5411d 100644
> --- a/target/linux/ath79/dts/qca9531_glinet_gl-ar300m-lite.dts
> +++ b/target/linux/ath79/dts/qca9531_glinet_gl-ar300m-lite.dts
> @@ -7,7 +7,11 @@
>   	model = "GL.iNet GL-AR300M-Lite";
>   };
>   
> -// GL-AR300M-Lite has different LED colors than the non-Lite version
> +// "Disable" unpopulated GMAC1
> +
> +&eth1 {
> +	compatible = "syscon", "simple-mfd";
> +};
>   
>   &led_status {
>   	label = "gl-ar300m-lite:red:status";


Both these should be cherry picked to 19.07 branch too

as the swap of ethernet interfaces commit is also in 19.07.

-Alberto
diff mbox series

Patch

diff --git a/target/linux/ath79/dts/qca9531_glinet_gl-ar300m-lite.dts b/target/linux/ath79/dts/qca9531_glinet_gl-ar300m-lite.dts
index fba08e4295..e29af5411d 100644
--- a/target/linux/ath79/dts/qca9531_glinet_gl-ar300m-lite.dts
+++ b/target/linux/ath79/dts/qca9531_glinet_gl-ar300m-lite.dts
@@ -7,7 +7,11 @@ 
 	model = "GL.iNet GL-AR300M-Lite";
 };
 
-// GL-AR300M-Lite has different LED colors than the non-Lite version
+// "Disable" unpopulated GMAC1
+
+&eth1 {
+	compatible = "syscon", "simple-mfd";
+};
 
 &led_status {
 	label = "gl-ar300m-lite:red:status";