| Message ID | 1317123799-5480-3-git-send-email-r.sricharan@ti.com |
|---|---|
| State | Changes Requested |
| Headers | show |
Dear sricharan, Am 27.09.2011 um 13:43 schrieb sricharan: > The maximum size of SPL is set to 38K bytes. > But the maximum size of SPL cannot exceed 32k bytes in > case of HS devices. So restrict the size to 32k bytes > for compatability with both HS/GP devices. > > Signed-off-by: sricharan <r.sricharan@ti.com> > --- > include/configs/omap4_common.h | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/include/configs/omap4_common.h b/include/configs/omap4_common.h > index e10ab00..7346934 100644 > --- a/include/configs/omap4_common.h > +++ b/include/configs/omap4_common.h > @@ -246,7 +246,7 @@ > /* Defines for SPL */ > #define CONFIG_SPL > #define CONFIG_SPL_TEXT_BASE 0x40304350 can you please add one line commenting why we use 32k here? > -#define CONFIG_SPL_MAX_SIZE (38 * 1024) > +#define CONFIG_SPL_MAX_SIZE (32 * 1024) best regards Andreas Bießmann
Hi Andreas Bießmann, >-----Original Message----- >From: Andreas Bießmann [mailto:andreas.devel@googlemail.com] >Sent: Wednesday, September 28, 2011 1:39 PM >To: sricharan >Cc: u-boot@lists.denx.de; aneesh@ti.com >Subject: Re: [U-Boot] [PATCH 2/2] SPL: omap4: Reduce the maximum size of >SPL to 32K bytes. > >Dear sricharan, > >Am 27.09.2011 um 13:43 schrieb sricharan: > >> The maximum size of SPL is set to 38K bytes. >> But the maximum size of SPL cannot exceed 32k bytes in >> case of HS devices. So restrict the size to 32k bytes >> for compatability with both HS/GP devices. >> >> Signed-off-by: sricharan <r.sricharan@ti.com> >> --- >> include/configs/omap4_common.h | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/include/configs/omap4_common.h >b/include/configs/omap4_common.h >> index e10ab00..7346934 100644 >> --- a/include/configs/omap4_common.h >> +++ b/include/configs/omap4_common.h >> @@ -246,7 +246,7 @@ >> /* Defines for SPL */ >> #define CONFIG_SPL >> #define CONFIG_SPL_TEXT_BASE 0x40304350 > >can you please add one line commenting why we use 32k here? > Sure, I will add this comment. >> -#define CONFIG_SPL_MAX_SIZE (38 * 1024) >> +#define CONFIG_SPL_MAX_SIZE (32 * 1024) > >best regards > >Andreas Bießmann
diff --git a/include/configs/omap4_common.h b/include/configs/omap4_common.h index e10ab00..7346934 100644 --- a/include/configs/omap4_common.h +++ b/include/configs/omap4_common.h @@ -246,7 +246,7 @@ /* Defines for SPL */ #define CONFIG_SPL #define CONFIG_SPL_TEXT_BASE 0x40304350 -#define CONFIG_SPL_MAX_SIZE (38 * 1024) +#define CONFIG_SPL_MAX_SIZE (32 * 1024) #define CONFIG_SPL_STACK LOW_LEVEL_SRAM_STACK #define CONFIG_SPL_BSS_START_ADDR 0x80000000
The maximum size of SPL is set to 38K bytes. But the maximum size of SPL cannot exceed 32k bytes in case of HS devices. So restrict the size to 32k bytes for compatability with both HS/GP devices. Signed-off-by: sricharan <r.sricharan@ti.com> --- include/configs/omap4_common.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)