| Message ID | 1316996766-14248-4-git-send-email-marek.vasut@gmail.com |
|---|---|
| State | Accepted |
| Commit | 7fcd9bbd6f0a69fb41b097cc8fd11d1ef21519e8 |
| Headers | show |
Acked-by: Mike Frysinger <vapier@gentoo.org>
-mike
Acked-by: Mike Frysinger <vapier@gentoo.org>
-mike
On Sun, Sep 25, 2011 at 5:26 PM, Marek Vasut <marek.vasut@gmail.com> wrote: > cmd_nvedit.c: In function ‘do_env_edit’: > cmd_nvedit.c:463:6: warning: variable ‘len’ set but not used > [-Wunused-but-set-variable] > > Signed-off-by: Marek Vasut <marek.vasut@gmail.com> I need this also! Acked-by: Simon Glass <sjg@chromium.org> > --- > common/cmd_nvedit.c | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/common/cmd_nvedit.c b/common/cmd_nvedit.c > index e8b116d..101bc49 100644 > --- a/common/cmd_nvedit.c > +++ b/common/cmd_nvedit.c > @@ -460,7 +460,6 @@ int do_env_edit(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) > { > char buffer[CONFIG_SYS_CBSIZE]; > char *init_val; > - int len; > > if (argc < 2) > return cmd_usage(cmdtp); > @@ -468,7 +467,7 @@ int do_env_edit(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) > /* Set read buffer to initial value or empty sting */ > init_val = getenv(argv[1]); > if (init_val) > - len = sprintf(buffer, "%s", init_val); > + sprintf(buffer, "%s", init_val); > else > buffer[0] = '\0'; > > -- > 1.7.5.4 > > _______________________________________________ > U-Boot mailing list > U-Boot@lists.denx.de > http://lists.denx.de/mailman/listinfo/u-boot >
Dear Marek Vasut, In message <1316996766-14248-4-git-send-email-marek.vasut@gmail.com> you wrote: > cmd_nvedit.c: In function `do_env_edit´: > cmd_nvedit.c:463:6: warning: variable `len´ set but not used > [-Wunused-but-set-variable] > > Signed-off-by: Marek Vasut <marek.vasut@gmail.com> > --- > common/cmd_nvedit.c | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) Applied, thanks. Best regards, Wolfgang Denk
diff --git a/common/cmd_nvedit.c b/common/cmd_nvedit.c index e8b116d..101bc49 100644 --- a/common/cmd_nvedit.c +++ b/common/cmd_nvedit.c @@ -460,7 +460,6 @@ int do_env_edit(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) { char buffer[CONFIG_SYS_CBSIZE]; char *init_val; - int len; if (argc < 2) return cmd_usage(cmdtp); @@ -468,7 +467,7 @@ int do_env_edit(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) /* Set read buffer to initial value or empty sting */ init_val = getenv(argv[1]); if (init_val) - len = sprintf(buffer, "%s", init_val); + sprintf(buffer, "%s", init_val); else buffer[0] = '\0';
cmd_nvedit.c: In function ‘do_env_edit’: cmd_nvedit.c:463:6: warning: variable ‘len’ set but not used [-Wunused-but-set-variable] Signed-off-by: Marek Vasut <marek.vasut@gmail.com> --- common/cmd_nvedit.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)