diff mbox series

[U-Boot,2/3] ubi: Print skip_check in ubi_dump_vol_info()

Message ID 20190912144103.17261-2-sr@denx.de
State Accepted
Commit 524acec47cda4cfab66229e62d0d252b75fef297
Delegated to: Heiko Schocher
Headers show
Series [U-Boot,1/3] ubi: provide a way to skip CRC checks | expand

Commit Message

Stefan Roese Sept. 12, 2019, 2:41 p.m. UTC
It might be interesting, if "skip_check" is set of not, so lets print
this flag in ubi_dump_vol_info() as well.

Signed-off-by: Stefan Roese <sr@denx.de>
Cc: Quentin Schulz <quentin.schulz@bootlin.com>
Cc: Boris Brezillon <boris.brezillon@bootlin.com>
Cc: Heiko Schocher <hs@denx.de>
---
 drivers/mtd/ubi/debug.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Heiko Schocher Sept. 17, 2019, 5:39 a.m. UTC | #1
Hello Stefan,

Am 12.09.2019 um 16:41 schrieb Stefan Roese:
> It might be interesting, if "skip_check" is set of not, so lets print

s/of/or ?

> this flag in ubi_dump_vol_info() as well.
> 
> Signed-off-by: Stefan Roese <sr@denx.de>
> Cc: Quentin Schulz <quentin.schulz@bootlin.com>
> Cc: Boris Brezillon <boris.brezillon@bootlin.com>
> Cc: Heiko Schocher <hs@denx.de>
> ---
>   drivers/mtd/ubi/debug.c | 1 +
>   1 file changed, 1 insertion(+)

Reviewed-by: Heiko Schocher <hs@denx.de>

queued until next merge window opens. I corrected the commit message.

bye,
Heiko
Heiko Schocher Oct. 16, 2019, 8:59 a.m. UTC | #2
Hello Stefan,

Am 17.09.2019 um 07:39 schrieb Heiko Schocher:
> Hello Stefan,
> 
> Am 12.09.2019 um 16:41 schrieb Stefan Roese:
>> It might be interesting, if "skip_check" is set of not, so lets print
> 
> s/of/or ?
> 
>> this flag in ubi_dump_vol_info() as well.
>>
>> Signed-off-by: Stefan Roese <sr@denx.de>
>> Cc: Quentin Schulz <quentin.schulz@bootlin.com>
>> Cc: Boris Brezillon <boris.brezillon@bootlin.com>
>> Cc: Heiko Schocher <hs@denx.de>
>> ---
>>   drivers/mtd/ubi/debug.c | 1 +
>>   1 file changed, 1 insertion(+)
> 
> Reviewed-by: Heiko Schocher <hs@denx.de>
> 
> queued until next merge window opens. I corrected the commit message.

Thanks!

applied to u-boot-ubi.git master

bye,
Heiko
diff mbox series

Patch

diff --git a/drivers/mtd/ubi/debug.c b/drivers/mtd/ubi/debug.c
index 0a7427522c..f3d348da83 100644
--- a/drivers/mtd/ubi/debug.c
+++ b/drivers/mtd/ubi/debug.c
@@ -109,6 +109,7 @@  void ubi_dump_vol_info(const struct ubi_volume *vol)
 	printf("\tlast_eb_bytes   %d\n", vol->last_eb_bytes);
 	printf("\tcorrupted       %d\n", vol->corrupted);
 	printf("\tupd_marker      %d\n", vol->upd_marker);
+	printf("\tskip_check      %d\n", vol->skip_check);
 
 	if (vol->name_len <= UBI_VOL_NAME_MAX &&
 	    strnlen(vol->name, vol->name_len + 1) == vol->name_len) {