diff mbox series

[U-Boot,v2,3/4] env: add missing <compiler.h> header file

Message ID 1566817578-16750-4-git-send-email-pjtexier@koncepto.io
State Accepted
Commit 664689f1dcb178ccb36842d0564ea8a6e8a7e648
Delegated to: Tom Rini
Headers show
Series env: fix build error for envtools | expand

Commit Message

Pierre-Jean Texier Aug. 26, 2019, 11:06 a.m. UTC
Since commit af95f20 ("env: Create a new file for environment functions"),
a new header file exists.

So, this commit add a missing header file.

Fixes:

include/env.h:158:1: error: unknown type name ‘ulong’; did you mean ‘long’?
 ulong env_get_ulong(const char *name, int base, ulong default_val);
 ^~~~~
 long
include/env.h:158:49: error: unknown type name ‘ulong’; did you mean ‘long’?
 ulong env_get_ulong(const char *name, int base, ulong default_val);

Signed-off-by: Pierre-Jean Texier <pjtexier@koncepto.io>
Tested-by: Joris Offouga <offougajoris@gmail.com>
Tested-by: Heiko Schocher <hs@denx.de>
---
v1 -> v2:
 - None

 include/env.h | 1 +
 1 file changed, 1 insertion(+)

Comments

Joe Hershberger Sept. 3, 2019, 10:37 p.m. UTC | #1
On Mon, Aug 26, 2019 at 6:08 AM Pierre-Jean Texier <pjtexier@koncepto.io> wrote:
>
> Since commit af95f20 ("env: Create a new file for environment functions"),
> a new header file exists.
>
> So, this commit add a missing header file.
>
> Fixes:
>
> include/env.h:158:1: error: unknown type name ‘ulong’; did you mean ‘long’?
>  ulong env_get_ulong(const char *name, int base, ulong default_val);
>  ^~~~~
>  long
> include/env.h:158:49: error: unknown type name ‘ulong’; did you mean ‘long’?
>  ulong env_get_ulong(const char *name, int base, ulong default_val);
>
> Signed-off-by: Pierre-Jean Texier <pjtexier@koncepto.io>
> Tested-by: Joris Offouga <offougajoris@gmail.com>
> Tested-by: Heiko Schocher <hs@denx.de>

Acked-by: Joe Hershberger <joe.hershberger@ni.com>
Tom Rini Sept. 25, 2019, 11:39 p.m. UTC | #2
On Mon, Aug 26, 2019 at 01:06:17PM +0200, Pierre-Jean Texier wrote:

> Since commit af95f20 ("env: Create a new file for environment functions"),
> a new header file exists.
> 
> So, this commit add a missing header file.
> 
> Fixes:
> 
> include/env.h:158:1: error: unknown type name ‘ulong’; did you mean ‘long’?
>  ulong env_get_ulong(const char *name, int base, ulong default_val);
>  ^~~~~
>  long
> include/env.h:158:49: error: unknown type name ‘ulong’; did you mean ‘long’?
>  ulong env_get_ulong(const char *name, int base, ulong default_val);
> 
> Signed-off-by: Pierre-Jean Texier <pjtexier@koncepto.io>
> Tested-by: Joris Offouga <offougajoris@gmail.com>
> Tested-by: Heiko Schocher <hs@denx.de>
> Acked-by: Joe Hershberger <joe.hershberger@ni.com>

Applied to u-boot/master, thanks!
diff mbox series

Patch

diff --git a/include/env.h b/include/env.h
index a74a261..b72239f 100644
--- a/include/env.h
+++ b/include/env.h
@@ -9,6 +9,7 @@ 
 #ifndef __ENV_H
 #define __ENV_H
 
+#include <compiler.h>
 #include <stdbool.h>
 #include <linux/types.h>