| Message ID | 20190821172910.13921-1-sudeep.holla@arm.com |
|---|---|
| State | Accepted |
| Commit | af38acbd701f24a7c9a8753a1190e15d7d781322 |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | [U-Boot] ARM: vexpress_*_defconfig: replace earlyprintk with earlycon | expand |
> Subject: [U-Boot] [PATCH] ARM: vexpress_*_defconfig: replace earlyprintk > with earlycon > > earlyprintk no longer works on arm64 platforms. Replace it with earlycon > which works fine. > > Cc: Ryan Harkin <ryan.harkin@linaro.org> > Cc: Liviu Dudau <liviu.dudau@foss.arm.com> > Cc: Linus Walleij <linus.walleij@linaro.org> > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> > --- > configs/vexpress_aemv8a_dram_defconfig | 2 +- > configs/vexpress_aemv8a_juno_defconfig | 2 +- > configs/vexpress_aemv8a_semi_defconfig | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/configs/vexpress_aemv8a_dram_defconfig > b/configs/vexpress_aemv8a_dram_defconfig > index 2ff9e4b9f291..51860da387da 100644 > --- a/configs/vexpress_aemv8a_dram_defconfig > +++ b/configs/vexpress_aemv8a_dram_defconfig > @@ -7,7 +7,7 @@ CONFIG_IDENT_STRING=" vexpress_aemv8a" > CONFIG_DISTRO_DEFAULTS=y > CONFIG_BOOTDELAY=1 > CONFIG_USE_BOOTARGS=y > -CONFIG_BOOTARGS="console=ttyAMA0 earlyprintk=pl011,0x1c090000 > debug user_debug=31 androidboot.hardware=fvpbase root=/dev/vda2 rw > rootwait loglevel=9" > +CONFIG_BOOTARGS="console=ttyAMA0 earlycon=pl011,0x1c090000 debug > user_debug=31 androidboot.hardware=fvpbase root=/dev/vda2 rw rootwait > loglevel=9" > # CONFIG_USE_BOOTCOMMAND is not set > # CONFIG_DISPLAY_CPUINFO is not set > # CONFIG_DISPLAY_BOARDINFO is not set > diff --git a/configs/vexpress_aemv8a_juno_defconfig > b/configs/vexpress_aemv8a_juno_defconfig > index fd306f9f6bf0..0823d17c1158 100644 > --- a/configs/vexpress_aemv8a_juno_defconfig > +++ b/configs/vexpress_aemv8a_juno_defconfig > @@ -7,7 +7,7 @@ CONFIG_IDENT_STRING=" vexpress_aemv8a" > CONFIG_DISTRO_DEFAULTS=y > CONFIG_BOOTDELAY=1 > CONFIG_USE_BOOTARGS=y > -CONFIG_BOOTARGS="console=ttyAMA0,115200n8 root=/dev/sda2 rw > rootwait earlyprintk=pl011,0x7ff80000 debug user_debug=31 > androidboot.hardware=juno loglevel=9" > +CONFIG_BOOTARGS="console=ttyAMA0,115200n8 root=/dev/sda2 rw > rootwait earlycon=pl011,0x7ff80000 debug user_debug=31 > androidboot.hardware=juno loglevel=9" > # CONFIG_USE_BOOTCOMMAND is not set > # CONFIG_DISPLAY_CPUINFO is not set > # CONFIG_DISPLAY_BOARDINFO is not set > diff --git a/configs/vexpress_aemv8a_semi_defconfig > b/configs/vexpress_aemv8a_semi_defconfig > index bff52f703836..db5ad3dfa5a4 100644 > --- a/configs/vexpress_aemv8a_semi_defconfig > +++ b/configs/vexpress_aemv8a_semi_defconfig > @@ -7,7 +7,7 @@ CONFIG_IDENT_STRING=" vexpress_aemv8a" > CONFIG_DISTRO_DEFAULTS=y > CONFIG_BOOTDELAY=1 > CONFIG_USE_BOOTARGS=y > -CONFIG_BOOTARGS="console=ttyAMA0 earlyprintk=pl011,0x1c090000 > debug user_debug=31 loglevel=9" > +CONFIG_BOOTARGS="console=ttyAMA0 earlycon=pl011,0x1c090000 debug > user_debug=31 loglevel=9" > # CONFIG_USE_BOOTCOMMAND is not set > # CONFIG_DISPLAY_CPUINFO is not set > # CONFIG_DISPLAY_BOARDINFO is not set Reviewed-by: Peng Fan <peng.fan@nxp.com> Nitpick: this will be no early print when booting older version kernel. > -- > 2.17.1 > > _______________________________________________ > U-Boot mailing list > U-Boot@lists.denx.de > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.d > enx.de%2Flistinfo%2Fu-boot&data=02%7C01%7CPeng.Fan%40nxp.com > %7C527db1f88898493ad3a708d7265d2df8%7C686ea1d3bc2b4c6fa92cd99c5 > c301635%7C0%7C0%7C637020053985296717&sdata=eTWujuzFpTwWil > xc%2F7W7I7t8UQirTZ%2BE8MWkFGsdzrk%3D&reserved=0
On Thu, 22 Aug 2019 at 02:25, Peng Fan <peng.fan@nxp.com> wrote: > > Subject: [U-Boot] [PATCH] ARM: vexpress_*_defconfig: replace earlyprintk > > with earlycon > > > > earlyprintk no longer works on arm64 platforms. Replace it with earlycon > > which works fine. > > > > Cc: Ryan Harkin <ryan.harkin@linaro.org> > > Cc: Liviu Dudau <liviu.dudau@foss.arm.com> > > Cc: Linus Walleij <linus.walleij@linaro.org> > > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> > > --- > > configs/vexpress_aemv8a_dram_defconfig | 2 +- > > configs/vexpress_aemv8a_juno_defconfig | 2 +- > > configs/vexpress_aemv8a_semi_defconfig | 2 +- > > 3 files changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/configs/vexpress_aemv8a_dram_defconfig > > b/configs/vexpress_aemv8a_dram_defconfig > > index 2ff9e4b9f291..51860da387da 100644 > > --- a/configs/vexpress_aemv8a_dram_defconfig > > +++ b/configs/vexpress_aemv8a_dram_defconfig > > @@ -7,7 +7,7 @@ CONFIG_IDENT_STRING=" vexpress_aemv8a" > > CONFIG_DISTRO_DEFAULTS=y > > CONFIG_BOOTDELAY=1 > > CONFIG_USE_BOOTARGS=y > > -CONFIG_BOOTARGS="console=ttyAMA0 earlyprintk=pl011,0x1c090000 > > debug user_debug=31 androidboot.hardware=fvpbase root=/dev/vda2 rw > > rootwait loglevel=9" > > +CONFIG_BOOTARGS="console=ttyAMA0 earlycon=pl011,0x1c090000 debug > > user_debug=31 androidboot.hardware=fvpbase root=/dev/vda2 rw rootwait > > loglevel=9" > > # CONFIG_USE_BOOTCOMMAND is not set > > # CONFIG_DISPLAY_CPUINFO is not set > > # CONFIG_DISPLAY_BOARDINFO is not set > > diff --git a/configs/vexpress_aemv8a_juno_defconfig > > b/configs/vexpress_aemv8a_juno_defconfig > > index fd306f9f6bf0..0823d17c1158 100644 > > --- a/configs/vexpress_aemv8a_juno_defconfig > > +++ b/configs/vexpress_aemv8a_juno_defconfig > > @@ -7,7 +7,7 @@ CONFIG_IDENT_STRING=" vexpress_aemv8a" > > CONFIG_DISTRO_DEFAULTS=y > > CONFIG_BOOTDELAY=1 > > CONFIG_USE_BOOTARGS=y > > -CONFIG_BOOTARGS="console=ttyAMA0,115200n8 root=/dev/sda2 rw > > rootwait earlyprintk=pl011,0x7ff80000 debug user_debug=31 > > androidboot.hardware=juno loglevel=9" > > +CONFIG_BOOTARGS="console=ttyAMA0,115200n8 root=/dev/sda2 rw > > rootwait earlycon=pl011,0x7ff80000 debug user_debug=31 > > androidboot.hardware=juno loglevel=9" > > # CONFIG_USE_BOOTCOMMAND is not set > > # CONFIG_DISPLAY_CPUINFO is not set > > # CONFIG_DISPLAY_BOARDINFO is not set > > diff --git a/configs/vexpress_aemv8a_semi_defconfig > > b/configs/vexpress_aemv8a_semi_defconfig > > index bff52f703836..db5ad3dfa5a4 100644 > > --- a/configs/vexpress_aemv8a_semi_defconfig > > +++ b/configs/vexpress_aemv8a_semi_defconfig > > @@ -7,7 +7,7 @@ CONFIG_IDENT_STRING=" vexpress_aemv8a" > > CONFIG_DISTRO_DEFAULTS=y > > CONFIG_BOOTDELAY=1 > > CONFIG_USE_BOOTARGS=y > > -CONFIG_BOOTARGS="console=ttyAMA0 earlyprintk=pl011,0x1c090000 > > debug user_debug=31 loglevel=9" > > +CONFIG_BOOTARGS="console=ttyAMA0 earlycon=pl011,0x1c090000 debug > > user_debug=31 loglevel=9" > > # CONFIG_USE_BOOTCOMMAND is not set > > # CONFIG_DISPLAY_CPUINFO is not set > > # CONFIG_DISPLAY_BOARDINFO is not set > > Reviewed-by: Peng Fan <peng.fan@nxp.com> > Reviewed-by: Ryan Harkin <ryan.harkin@linaro.org> > > Nitpick: this will be no early print when booting older version kernel. > Note also that the -dram platform is no longer used or tested. I'll send a patch to remove it. > > -- > > 2.17.1 > > > > _______________________________________________ > > U-Boot mailing list > > U-Boot@lists.denx.de > > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.d > > enx.de%2Flistinfo%2Fu-boot&data=02%7C01%7CPeng.Fan%40nxp.com > > %7C527db1f88898493ad3a708d7265d2df8%7C686ea1d3bc2b4c6fa92cd99c5 > > c301635%7C0%7C0%7C637020053985296717&sdata=eTWujuzFpTwWil > > xc%2F7W7I7t8UQirTZ%2BE8MWkFGsdzrk%3D&reserved=0 > _______________________________________________ > U-Boot mailing list > U-Boot@lists.denx.de > https://lists.denx.de/listinfo/u-boot >
On Thu, Aug 22, 2019 at 12:38:31PM +0100, Ryan Harkin wrote: > On Thu, 22 Aug 2019 at 02:25, Peng Fan <peng.fan@nxp.com> wrote: > > > > Subject: [U-Boot] [PATCH] ARM: vexpress_*_defconfig: replace earlyprintk > > > with earlycon > > > > > > earlyprintk no longer works on arm64 platforms. Replace it with earlycon > > > which works fine. > > > > > > Cc: Ryan Harkin <ryan.harkin@linaro.org> > > > Cc: Liviu Dudau <liviu.dudau@foss.arm.com> > > > Cc: Linus Walleij <linus.walleij@linaro.org> > > > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> > > > --- > > > configs/vexpress_aemv8a_dram_defconfig | 2 +- > > > configs/vexpress_aemv8a_juno_defconfig | 2 +- > > > configs/vexpress_aemv8a_semi_defconfig | 2 +- > > > 3 files changed, 3 insertions(+), 3 deletions(-) > > > > > > diff --git a/configs/vexpress_aemv8a_dram_defconfig > > > b/configs/vexpress_aemv8a_dram_defconfig > > > index 2ff9e4b9f291..51860da387da 100644 > > > --- a/configs/vexpress_aemv8a_dram_defconfig > > > +++ b/configs/vexpress_aemv8a_dram_defconfig > > > @@ -7,7 +7,7 @@ CONFIG_IDENT_STRING=" vexpress_aemv8a" > > > CONFIG_DISTRO_DEFAULTS=y > > > CONFIG_BOOTDELAY=1 > > > CONFIG_USE_BOOTARGS=y > > > -CONFIG_BOOTARGS="console=ttyAMA0 earlyprintk=pl011,0x1c090000 > > > debug user_debug=31 androidboot.hardware=fvpbase root=/dev/vda2 rw > > > rootwait loglevel=9" > > > +CONFIG_BOOTARGS="console=ttyAMA0 earlycon=pl011,0x1c090000 debug > > > user_debug=31 androidboot.hardware=fvpbase root=/dev/vda2 rw rootwait > > > loglevel=9" > > > # CONFIG_USE_BOOTCOMMAND is not set > > > # CONFIG_DISPLAY_CPUINFO is not set > > > # CONFIG_DISPLAY_BOARDINFO is not set > > > diff --git a/configs/vexpress_aemv8a_juno_defconfig > > > b/configs/vexpress_aemv8a_juno_defconfig > > > index fd306f9f6bf0..0823d17c1158 100644 > > > --- a/configs/vexpress_aemv8a_juno_defconfig > > > +++ b/configs/vexpress_aemv8a_juno_defconfig > > > @@ -7,7 +7,7 @@ CONFIG_IDENT_STRING=" vexpress_aemv8a" > > > CONFIG_DISTRO_DEFAULTS=y > > > CONFIG_BOOTDELAY=1 > > > CONFIG_USE_BOOTARGS=y > > > -CONFIG_BOOTARGS="console=ttyAMA0,115200n8 root=/dev/sda2 rw > > > rootwait earlyprintk=pl011,0x7ff80000 debug user_debug=31 > > > androidboot.hardware=juno loglevel=9" > > > +CONFIG_BOOTARGS="console=ttyAMA0,115200n8 root=/dev/sda2 rw > > > rootwait earlycon=pl011,0x7ff80000 debug user_debug=31 > > > androidboot.hardware=juno loglevel=9" > > > # CONFIG_USE_BOOTCOMMAND is not set > > > # CONFIG_DISPLAY_CPUINFO is not set > > > # CONFIG_DISPLAY_BOARDINFO is not set > > > diff --git a/configs/vexpress_aemv8a_semi_defconfig > > > b/configs/vexpress_aemv8a_semi_defconfig > > > index bff52f703836..db5ad3dfa5a4 100644 > > > --- a/configs/vexpress_aemv8a_semi_defconfig > > > +++ b/configs/vexpress_aemv8a_semi_defconfig > > > @@ -7,7 +7,7 @@ CONFIG_IDENT_STRING=" vexpress_aemv8a" > > > CONFIG_DISTRO_DEFAULTS=y > > > CONFIG_BOOTDELAY=1 > > > CONFIG_USE_BOOTARGS=y > > > -CONFIG_BOOTARGS="console=ttyAMA0 earlyprintk=pl011,0x1c090000 > > > debug user_debug=31 loglevel=9" > > > +CONFIG_BOOTARGS="console=ttyAMA0 earlycon=pl011,0x1c090000 debug > > > user_debug=31 loglevel=9" > > > # CONFIG_USE_BOOTCOMMAND is not set > > > # CONFIG_DISPLAY_CPUINFO is not set > > > # CONFIG_DISPLAY_BOARDINFO is not set > > > > Reviewed-by: Peng Fan <peng.fan@nxp.com> > > > Reviewed-by: Ryan Harkin <ryan.harkin@linaro.org> > > > > > Nitpick: this will be no early print when booting older version kernel. > > > > Note also that the -dram platform is no longer used or tested. I'll send a > patch to remove it. > Ah OK, I was about to try that on FVP but then saw -semihosting one. Thanks for the review. I assume you will post on top of my patch or do you need me to drop changes in -dram defconfig and post v2 ? -- Regards, Sudeep
On Thu, Aug 22, 2019 at 01:25:46AM +0000, Peng Fan wrote: > > Subject: [U-Boot] [PATCH] ARM: vexpress_*_defconfig: replace earlyprintk > > with earlycon > > > > earlyprintk no longer works on arm64 platforms. Replace it with earlycon > > which works fine. > > > > Cc: Ryan Harkin <ryan.harkin@linaro.org> > > Cc: Liviu Dudau <liviu.dudau@foss.arm.com> > > Cc: Linus Walleij <linus.walleij@linaro.org> > > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> > > --- > > configs/vexpress_aemv8a_dram_defconfig | 2 +- > > configs/vexpress_aemv8a_juno_defconfig | 2 +- > > configs/vexpress_aemv8a_semi_defconfig | 2 +- > > 3 files changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/configs/vexpress_aemv8a_dram_defconfig > > b/configs/vexpress_aemv8a_dram_defconfig > > index 2ff9e4b9f291..51860da387da 100644 > > --- a/configs/vexpress_aemv8a_dram_defconfig > > +++ b/configs/vexpress_aemv8a_dram_defconfig > > @@ -7,7 +7,7 @@ CONFIG_IDENT_STRING=" vexpress_aemv8a" > > CONFIG_DISTRO_DEFAULTS=y > > CONFIG_BOOTDELAY=1 > > CONFIG_USE_BOOTARGS=y > > -CONFIG_BOOTARGS="console=ttyAMA0 earlyprintk=pl011,0x1c090000 > > debug user_debug=31 androidboot.hardware=fvpbase root=/dev/vda2 rw > > rootwait loglevel=9" > > +CONFIG_BOOTARGS="console=ttyAMA0 earlycon=pl011,0x1c090000 debug > > user_debug=31 androidboot.hardware=fvpbase root=/dev/vda2 rw rootwait > > loglevel=9" > > # CONFIG_USE_BOOTCOMMAND is not set > > # CONFIG_DISPLAY_CPUINFO is not set > > # CONFIG_DISPLAY_BOARDINFO is not set > > diff --git a/configs/vexpress_aemv8a_juno_defconfig > > b/configs/vexpress_aemv8a_juno_defconfig > > index fd306f9f6bf0..0823d17c1158 100644 > > --- a/configs/vexpress_aemv8a_juno_defconfig > > +++ b/configs/vexpress_aemv8a_juno_defconfig > > @@ -7,7 +7,7 @@ CONFIG_IDENT_STRING=" vexpress_aemv8a" > > CONFIG_DISTRO_DEFAULTS=y > > CONFIG_BOOTDELAY=1 > > CONFIG_USE_BOOTARGS=y > > -CONFIG_BOOTARGS="console=ttyAMA0,115200n8 root=/dev/sda2 rw > > rootwait earlyprintk=pl011,0x7ff80000 debug user_debug=31 > > androidboot.hardware=juno loglevel=9" > > +CONFIG_BOOTARGS="console=ttyAMA0,115200n8 root=/dev/sda2 rw > > rootwait earlycon=pl011,0x7ff80000 debug user_debug=31 > > androidboot.hardware=juno loglevel=9" > > # CONFIG_USE_BOOTCOMMAND is not set > > # CONFIG_DISPLAY_CPUINFO is not set > > # CONFIG_DISPLAY_BOARDINFO is not set > > diff --git a/configs/vexpress_aemv8a_semi_defconfig > > b/configs/vexpress_aemv8a_semi_defconfig > > index bff52f703836..db5ad3dfa5a4 100644 > > --- a/configs/vexpress_aemv8a_semi_defconfig > > +++ b/configs/vexpress_aemv8a_semi_defconfig > > @@ -7,7 +7,7 @@ CONFIG_IDENT_STRING=" vexpress_aemv8a" > > CONFIG_DISTRO_DEFAULTS=y > > CONFIG_BOOTDELAY=1 > > CONFIG_USE_BOOTARGS=y > > -CONFIG_BOOTARGS="console=ttyAMA0 earlyprintk=pl011,0x1c090000 > > debug user_debug=31 loglevel=9" > > +CONFIG_BOOTARGS="console=ttyAMA0 earlycon=pl011,0x1c090000 debug > > user_debug=31 loglevel=9" > > # CONFIG_USE_BOOTCOMMAND is not set > > # CONFIG_DISPLAY_CPUINFO is not set > > # CONFIG_DISPLAY_BOARDINFO is not set > > Reviewed-by: Peng Fan <peng.fan@nxp.com> > > Nitpick: this will be no early print when booting older version kernel. Indeed, thanks for the review. -- Regards, Sudeep
On Thu, 22 Aug 2019 at 13:10, Sudeep Holla <sudeep.holla@arm.com> wrote: > On Thu, Aug 22, 2019 at 12:38:31PM +0100, Ryan Harkin wrote: > > On Thu, 22 Aug 2019 at 02:25, Peng Fan <peng.fan@nxp.com> wrote: > > > > > > Subject: [U-Boot] [PATCH] ARM: vexpress_*_defconfig: replace > earlyprintk > > > > with earlycon > > > > > > > > earlyprintk no longer works on arm64 platforms. Replace it with > earlycon > > > > which works fine. > > > > > > > > Cc: Ryan Harkin <ryan.harkin@linaro.org> > > > > Cc: Liviu Dudau <liviu.dudau@foss.arm.com> > > > > Cc: Linus Walleij <linus.walleij@linaro.org> > > > > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> > > > > --- > > > > configs/vexpress_aemv8a_dram_defconfig | 2 +- > > > > configs/vexpress_aemv8a_juno_defconfig | 2 +- > > > > configs/vexpress_aemv8a_semi_defconfig | 2 +- > > > > 3 files changed, 3 insertions(+), 3 deletions(-) > > > > > > > > diff --git a/configs/vexpress_aemv8a_dram_defconfig > > > > b/configs/vexpress_aemv8a_dram_defconfig > > > > index 2ff9e4b9f291..51860da387da 100644 > > > > --- a/configs/vexpress_aemv8a_dram_defconfig > > > > +++ b/configs/vexpress_aemv8a_dram_defconfig > > > > @@ -7,7 +7,7 @@ CONFIG_IDENT_STRING=" vexpress_aemv8a" > > > > CONFIG_DISTRO_DEFAULTS=y > > > > CONFIG_BOOTDELAY=1 > > > > CONFIG_USE_BOOTARGS=y > > > > -CONFIG_BOOTARGS="console=ttyAMA0 earlyprintk=pl011,0x1c090000 > > > > debug user_debug=31 androidboot.hardware=fvpbase root=/dev/vda2 rw > > > > rootwait loglevel=9" > > > > +CONFIG_BOOTARGS="console=ttyAMA0 earlycon=pl011,0x1c090000 debug > > > > user_debug=31 androidboot.hardware=fvpbase root=/dev/vda2 rw rootwait > > > > loglevel=9" > > > > # CONFIG_USE_BOOTCOMMAND is not set > > > > # CONFIG_DISPLAY_CPUINFO is not set > > > > # CONFIG_DISPLAY_BOARDINFO is not set > > > > diff --git a/configs/vexpress_aemv8a_juno_defconfig > > > > b/configs/vexpress_aemv8a_juno_defconfig > > > > index fd306f9f6bf0..0823d17c1158 100644 > > > > --- a/configs/vexpress_aemv8a_juno_defconfig > > > > +++ b/configs/vexpress_aemv8a_juno_defconfig > > > > @@ -7,7 +7,7 @@ CONFIG_IDENT_STRING=" vexpress_aemv8a" > > > > CONFIG_DISTRO_DEFAULTS=y > > > > CONFIG_BOOTDELAY=1 > > > > CONFIG_USE_BOOTARGS=y > > > > -CONFIG_BOOTARGS="console=ttyAMA0,115200n8 root=/dev/sda2 rw > > > > rootwait earlyprintk=pl011,0x7ff80000 debug user_debug=31 > > > > androidboot.hardware=juno loglevel=9" > > > > +CONFIG_BOOTARGS="console=ttyAMA0,115200n8 root=/dev/sda2 rw > > > > rootwait earlycon=pl011,0x7ff80000 debug user_debug=31 > > > > androidboot.hardware=juno loglevel=9" > > > > # CONFIG_USE_BOOTCOMMAND is not set > > > > # CONFIG_DISPLAY_CPUINFO is not set > > > > # CONFIG_DISPLAY_BOARDINFO is not set > > > > diff --git a/configs/vexpress_aemv8a_semi_defconfig > > > > b/configs/vexpress_aemv8a_semi_defconfig > > > > index bff52f703836..db5ad3dfa5a4 100644 > > > > --- a/configs/vexpress_aemv8a_semi_defconfig > > > > +++ b/configs/vexpress_aemv8a_semi_defconfig > > > > @@ -7,7 +7,7 @@ CONFIG_IDENT_STRING=" vexpress_aemv8a" > > > > CONFIG_DISTRO_DEFAULTS=y > > > > CONFIG_BOOTDELAY=1 > > > > CONFIG_USE_BOOTARGS=y > > > > -CONFIG_BOOTARGS="console=ttyAMA0 earlyprintk=pl011,0x1c090000 > > > > debug user_debug=31 loglevel=9" > > > > +CONFIG_BOOTARGS="console=ttyAMA0 earlycon=pl011,0x1c090000 debug > > > > user_debug=31 loglevel=9" > > > > # CONFIG_USE_BOOTCOMMAND is not set > > > > # CONFIG_DISPLAY_CPUINFO is not set > > > > # CONFIG_DISPLAY_BOARDINFO is not set > > > > > > Reviewed-by: Peng Fan <peng.fan@nxp.com> > > > > > Reviewed-by: Ryan Harkin <ryan.harkin@linaro.org> > > > > > > > > Nitpick: this will be no early print when booting older version kernel. > > > > > > > Note also that the -dram platform is no longer used or tested. I'll send > a > > patch to remove it. > > > > Ah OK, I was about to try that on FVP but then saw -semihosting one. > Thanks for the review. I assume you will post on top of my patch or do > you need me to drop changes in -dram defconfig and post v2 ? > It's OK, go ahead with your patch and I'll send mine after it's merged. > > -- > Regards, > Sudeep >
On Wed, Aug 21, 2019 at 7:29 PM Sudeep Holla <sudeep.holla@arm.com> wrote: > earlyprintk no longer works on arm64 platforms. Replace it with earlycon > which works fine. > > Cc: Ryan Harkin <ryan.harkin@linaro.org> > Cc: Liviu Dudau <liviu.dudau@foss.arm.com> > Cc: Linus Walleij <linus.walleij@linaro.org> > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
On Wed, Aug 21, 2019 at 06:29:09PM +0100, Sudeep Holla wrote: > earlyprintk no longer works on arm64 platforms. Replace it with earlycon > which works fine. > > Cc: Ryan Harkin <ryan.harkin@linaro.org> > Cc: Liviu Dudau <liviu.dudau@foss.arm.com> > Cc: Linus Walleij <linus.walleij@linaro.org> > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> > Reviewed-by: Peng Fan <peng.fan@nxp.com> > Reviewed-by: Ryan Harkin <ryan.harkin@linaro.org> > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Applied to u-boot/master, thanks!
diff --git a/configs/vexpress_aemv8a_dram_defconfig b/configs/vexpress_aemv8a_dram_defconfig index 2ff9e4b9f291..51860da387da 100644 --- a/configs/vexpress_aemv8a_dram_defconfig +++ b/configs/vexpress_aemv8a_dram_defconfig @@ -7,7 +7,7 @@ CONFIG_IDENT_STRING=" vexpress_aemv8a" CONFIG_DISTRO_DEFAULTS=y CONFIG_BOOTDELAY=1 CONFIG_USE_BOOTARGS=y -CONFIG_BOOTARGS="console=ttyAMA0 earlyprintk=pl011,0x1c090000 debug user_debug=31 androidboot.hardware=fvpbase root=/dev/vda2 rw rootwait loglevel=9" +CONFIG_BOOTARGS="console=ttyAMA0 earlycon=pl011,0x1c090000 debug user_debug=31 androidboot.hardware=fvpbase root=/dev/vda2 rw rootwait loglevel=9" # CONFIG_USE_BOOTCOMMAND is not set # CONFIG_DISPLAY_CPUINFO is not set # CONFIG_DISPLAY_BOARDINFO is not set diff --git a/configs/vexpress_aemv8a_juno_defconfig b/configs/vexpress_aemv8a_juno_defconfig index fd306f9f6bf0..0823d17c1158 100644 --- a/configs/vexpress_aemv8a_juno_defconfig +++ b/configs/vexpress_aemv8a_juno_defconfig @@ -7,7 +7,7 @@ CONFIG_IDENT_STRING=" vexpress_aemv8a" CONFIG_DISTRO_DEFAULTS=y CONFIG_BOOTDELAY=1 CONFIG_USE_BOOTARGS=y -CONFIG_BOOTARGS="console=ttyAMA0,115200n8 root=/dev/sda2 rw rootwait earlyprintk=pl011,0x7ff80000 debug user_debug=31 androidboot.hardware=juno loglevel=9" +CONFIG_BOOTARGS="console=ttyAMA0,115200n8 root=/dev/sda2 rw rootwait earlycon=pl011,0x7ff80000 debug user_debug=31 androidboot.hardware=juno loglevel=9" # CONFIG_USE_BOOTCOMMAND is not set # CONFIG_DISPLAY_CPUINFO is not set # CONFIG_DISPLAY_BOARDINFO is not set diff --git a/configs/vexpress_aemv8a_semi_defconfig b/configs/vexpress_aemv8a_semi_defconfig index bff52f703836..db5ad3dfa5a4 100644 --- a/configs/vexpress_aemv8a_semi_defconfig +++ b/configs/vexpress_aemv8a_semi_defconfig @@ -7,7 +7,7 @@ CONFIG_IDENT_STRING=" vexpress_aemv8a" CONFIG_DISTRO_DEFAULTS=y CONFIG_BOOTDELAY=1 CONFIG_USE_BOOTARGS=y -CONFIG_BOOTARGS="console=ttyAMA0 earlyprintk=pl011,0x1c090000 debug user_debug=31 loglevel=9" +CONFIG_BOOTARGS="console=ttyAMA0 earlycon=pl011,0x1c090000 debug user_debug=31 loglevel=9" # CONFIG_USE_BOOTCOMMAND is not set # CONFIG_DISPLAY_CPUINFO is not set # CONFIG_DISPLAY_BOARDINFO is not set
earlyprintk no longer works on arm64 platforms. Replace it with earlycon which works fine. Cc: Ryan Harkin <ryan.harkin@linaro.org> Cc: Liviu Dudau <liviu.dudau@foss.arm.com> Cc: Linus Walleij <linus.walleij@linaro.org> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> --- configs/vexpress_aemv8a_dram_defconfig | 2 +- configs/vexpress_aemv8a_juno_defconfig | 2 +- configs/vexpress_aemv8a_semi_defconfig | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)