Patchwork [4/4] ext4: fix a wrong comment in __mb_check_buddy

login
register
mail settings
Submitter Robin Dong
Date Sept. 15, 2011, 7:09 a.m.
Message ID <1316070580-10723-4-git-send-email-hao.bigrat@gmail.com>
Download mbox | patch
Permalink /patch/114765/
State Accepted
Headers show

Comments

Robin Dong - Sept. 15, 2011, 7:09 a.m.
From: Robin Dong <sanbai@taobao.com>

The comment says the bit should be 0, but the after code assert the bit to be 1.
This makes people confused, so fix it.

Signed-off-by: Robin Dong <sanbai@taobao.com>
---
 fs/ext4/mballoc.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Theodore Ts'o - Oct. 26, 2011, 12:53 p.m.
On Thu, Sep 15, 2011 at 03:09:40PM +0800, Robin Dong wrote:
> From: Robin Dong <sanbai@taobao.com>
> 
> The comment says the bit should be 0, but the after code assert the bit to be 1.
> This makes people confused, so fix it.
> 
> Signed-off-by: Robin Dong <sanbai@taobao.com>

Thanks, applied.

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
index 99d123a..0b3d0ee 100644
--- a/fs/ext4/mballoc.c
+++ b/fs/ext4/mballoc.c
@@ -580,7 +580,7 @@  static int __mb_check_buddy(struct ext4_buddy *e4b, char *file,
 				continue;
 			}
 
-			/* both bits in buddy2 must be 0 */
+			/* both bits in buddy2 must be 1 */
 			MB_CHECK_ASSERT(mb_test_bit(i << 1, buddy2));
 			MB_CHECK_ASSERT(mb_test_bit((i << 1) + 1, buddy2));