From patchwork Thu Sep 15 07:09:40 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robin Dong X-Patchwork-Id: 114765 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id E10E4B71AD for ; Thu, 15 Sep 2011 17:10:14 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754028Ab1IOHKK (ORCPT ); Thu, 15 Sep 2011 03:10:10 -0400 Received: from mail-pz0-f46.google.com ([209.85.210.46]:32913 "EHLO mail-pz0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750788Ab1IOHKK (ORCPT ); Thu, 15 Sep 2011 03:10:10 -0400 Received: by mail-pz0-f46.google.com with SMTP id 32so2239825pzk.19 for ; Thu, 15 Sep 2011 00:10:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=RVmeGdaKrl1ykMFhvF9N3oN1veCsbs57zWCeQUhJoPE=; b=Vy8JcCv8L/7iitS9xFl9nk6kaHJLfAj9749YKnQZQIntnUcUeoRXBknj+bvmiNpQxl aBHdJPbKj28jHN7g7bbhrxEoVgluNYaspbrHDklt1iDnlZQjsHyWXLHJHBdzdqgs5CUY WFoojtuv4OPO3O9kK22mQgBsqiw7zIMJ0IFP8= Received: by 10.68.24.230 with SMTP id x6mr1380033pbf.422.1316070609961; Thu, 15 Sep 2011 00:10:09 -0700 (PDT) Received: from localhost.localdomain ([182.92.247.2]) by mx.google.com with ESMTPS id i3sm20418470pbg.10.2011.09.15.00.10.07 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 15 Sep 2011 00:10:09 -0700 (PDT) From: Robin Dong To: linux-ext4@vger.kernel.org Cc: Robin Dong Subject: [PATCH 4/4] ext4: fix a wrong comment in __mb_check_buddy Date: Thu, 15 Sep 2011 15:09:40 +0800 Message-Id: <1316070580-10723-4-git-send-email-hao.bigrat@gmail.com> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1316070580-10723-1-git-send-email-hao.bigrat@gmail.com> References: <1316070580-10723-1-git-send-email-hao.bigrat@gmail.com> Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org From: Robin Dong The comment says the bit should be 0, but the after code assert the bit to be 1. This makes people confused, so fix it. Signed-off-by: Robin Dong --- fs/ext4/mballoc.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c index 99d123a..0b3d0ee 100644 --- a/fs/ext4/mballoc.c +++ b/fs/ext4/mballoc.c @@ -580,7 +580,7 @@ static int __mb_check_buddy(struct ext4_buddy *e4b, char *file, continue; } - /* both bits in buddy2 must be 0 */ + /* both bits in buddy2 must be 1 */ MB_CHECK_ASSERT(mb_test_bit(i << 1, buddy2)); MB_CHECK_ASSERT(mb_test_bit((i << 1) + 1, buddy2));