| Message ID | 966a64a6f70b21d0732543dee0ffb2f5c0aa253a.1564384345.git.baruch@tkos.co.il |
|---|---|
| State | Superseded |
| Delegated to: | Stefan Roese |
| Headers | show |
| Series | [U-Boot,v2,1/3] spl: mmc: support uboot image offset on main partition | expand |
On 29.07.19 09:12, Baruch Siach wrote: > Armada 38x ROM skips the first SD card offset when loading SPL. This > affects the location of the main U-Boot image. SPL MMC code now supports > U-Boot image offset based on run-time detection of the boot partition. > Use this feature to make the same generated image support both SD card > and eMMC boot partition. > > Signed-off-by: Baruch Siach <baruch@tkos.co.il> > --- > configs/clearfog_defconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configs/clearfog_defconfig b/configs/clearfog_defconfig > index b7b886be4f7a..3609445c1e95 100644 > --- a/configs/clearfog_defconfig > +++ b/configs/clearfog_defconfig > @@ -22,7 +22,7 @@ CONFIG_SYS_CONSOLE_INFO_QUIET=y > # CONFIG_DISPLAY_BOARDINFO is not set > CONFIG_DISPLAY_BOARDINFO_LATE=y > CONFIG_SPL_TEXT_BASE=0x40000030 > -CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR=0x141 > +CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_DATA_PART_OFFSET=0x1 While looking at this patch, shouldn't this new Kconfig symbol include "SECTOR" for better transparency? And why "DATA"? Perhaps use CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR_OFFSET? Thanks, Stefan
Hi Baruch, On 06.08.19 08:20, Stefan Roese wrote: > On 29.07.19 09:12, Baruch Siach wrote: >> Armada 38x ROM skips the first SD card offset when loading SPL. This >> affects the location of the main U-Boot image. SPL MMC code now supports >> U-Boot image offset based on run-time detection of the boot partition. >> Use this feature to make the same generated image support both SD card >> and eMMC boot partition. >> >> Signed-off-by: Baruch Siach <baruch@tkos.co.il> >> --- >> configs/clearfog_defconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/configs/clearfog_defconfig b/configs/clearfog_defconfig >> index b7b886be4f7a..3609445c1e95 100644 >> --- a/configs/clearfog_defconfig >> +++ b/configs/clearfog_defconfig >> @@ -22,7 +22,7 @@ CONFIG_SYS_CONSOLE_INFO_QUIET=y >> # CONFIG_DISPLAY_BOARDINFO is not set >> CONFIG_DISPLAY_BOARDINFO_LATE=y >> CONFIG_SPL_TEXT_BASE=0x40000030 >> -CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR=0x141 >> +CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_DATA_PART_OFFSET=0x1 > > While looking at this patch, shouldn't this new Kconfig symbol > include "SECTOR" for better transparency? And why "DATA"? > Perhaps use CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR_OFFSET? Any updates on this? Thanks, Stefan
Hi Stefan, On Mon, Aug 12, 2019 at 03:14:16PM +0200, Stefan Roese wrote: > On 06.08.19 08:20, Stefan Roese wrote: > > On 29.07.19 09:12, Baruch Siach wrote: > > > Armada 38x ROM skips the first SD card offset when loading SPL. This > > > affects the location of the main U-Boot image. SPL MMC code now supports > > > U-Boot image offset based on run-time detection of the boot partition. > > > Use this feature to make the same generated image support both SD card > > > and eMMC boot partition. > > > > > > Signed-off-by: Baruch Siach <baruch@tkos.co.il> > > > --- > > > configs/clearfog_defconfig | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/configs/clearfog_defconfig b/configs/clearfog_defconfig > > > index b7b886be4f7a..3609445c1e95 100644 > > > --- a/configs/clearfog_defconfig > > > +++ b/configs/clearfog_defconfig > > > @@ -22,7 +22,7 @@ CONFIG_SYS_CONSOLE_INFO_QUIET=y > > > # CONFIG_DISPLAY_BOARDINFO is not set > > > CONFIG_DISPLAY_BOARDINFO_LATE=y > > > CONFIG_SPL_TEXT_BASE=0x40000030 > > > -CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR=0x141 > > > +CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_DATA_PART_OFFSET=0x1 > > > > While looking at this patch, shouldn't this new Kconfig symbol > > include "SECTOR" for better transparency? And why "DATA"? > > Perhaps use CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR_OFFSET? "DATA" is for the main eMMC data hardware partition, as opposed to boot partitions. This offset only applied to data partition. The symbol name should reflect that, I think. We could use CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_DATA_PART_SECTOR_OFFSET. Isn't that too long? baruch
diff --git a/configs/clearfog_defconfig b/configs/clearfog_defconfig index b7b886be4f7a..3609445c1e95 100644 --- a/configs/clearfog_defconfig +++ b/configs/clearfog_defconfig @@ -22,7 +22,7 @@ CONFIG_SYS_CONSOLE_INFO_QUIET=y # CONFIG_DISPLAY_BOARDINFO is not set CONFIG_DISPLAY_BOARDINFO_LATE=y CONFIG_SPL_TEXT_BASE=0x40000030 -CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR=0x141 +CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_DATA_PART_OFFSET=0x1 CONFIG_SPL_I2C_SUPPORT=y # CONFIG_CMD_FLASH is not set CONFIG_CMD_GPIO=y
Armada 38x ROM skips the first SD card offset when loading SPL. This affects the location of the main U-Boot image. SPL MMC code now supports U-Boot image offset based on run-time detection of the boot partition. Use this feature to make the same generated image support both SD card and eMMC boot partition. Signed-off-by: Baruch Siach <baruch@tkos.co.il> --- configs/clearfog_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)