Patchwork [U-Boot,v6,1/2] MX25: tx25: Avoid the usage of extern in C file

login
register
mail settings
Submitter Fabio Estevam
Date Sept. 6, 2011, 7:05 p.m.
Message ID <1315335943-11428-1-git-send-email-fabio.estevam@freescale.com>
Download mbox | patch
Permalink /patch/113659/
State Accepted
Commit e6d9b9785cde08162afd68ef555dcef7d477e1be
Delegated to: Stefano Babic
Headers show

Comments

Fabio Estevam - Sept. 6, 2011, 7:05 p.m.
Avoid the usage of extern in C file as pointed out by checkpatch.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
Changes since v5:
- Only place mx25_uart1_init_pins inside sys_proto.h
Changes since v4:
- No changes
Changes since v3:
- Place mx25_uart1_init_pins inside sys_proto.h
Changes since v2:
- Place the extern in the MX25 imx-regs.h instead of inside the MX27 imx-regs.h
Changes since v1:
- No changes
 arch/arm/include/asm/arch-mx25/sys_proto.h |   29 ++++++++++++++++++++++++++++
 board/karo/tx25/tx25.c                     |    3 +-
 2 files changed, 30 insertions(+), 2 deletions(-)
 create mode 100644 arch/arm/include/asm/arch-mx25/sys_proto.h
Fabio Estevam - Sept. 12, 2011, 3:39 p.m.
Hi Stefano,

On Tue, Sep 6, 2011 at 4:05 PM, Fabio Estevam
<fabio.estevam@freescale.com> wrote:
> Avoid the usage of extern in C file as pointed out by checkpatch.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

Does v6 series look good now?

Regards,

Fabio Estevam
Stefano Babic - Sept. 12, 2011, 4:10 p.m.
On 09/12/2011 05:39 PM, Fabio Estevam wrote:
> Hi Stefano,
> 
> On Tue, Sep 6, 2011 at 4:05 PM, Fabio Estevam
> <fabio.estevam@freescale.com> wrote:
>> Avoid the usage of extern in C file as pointed out by checkpatch.
>>
>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> 
> Does v6 series look good now?

Yes, I have rebased your patch due to changes in boards.cfg and put on
my private next branch. Due to incoming release, I have not yet
officially pushed, but I will merge them after 2011.09 is out.

I have now published my next branch, and you can take a look what I have
currently taken to be merged. Except for the changes in main Makefile,
because these patches should be picked or rejected by Wolfgang.

Best regards,
Stefano Babic

Patch

diff --git a/arch/arm/include/asm/arch-mx25/sys_proto.h b/arch/arm/include/asm/arch-mx25/sys_proto.h
new file mode 100644
index 0000000..6a01a7b
--- /dev/null
+++ b/arch/arm/include/asm/arch-mx25/sys_proto.h
@@ -0,0 +1,29 @@ 
+/*
+ * (C) Copyright 2009
+ * Stefano Babic, DENX Software Engineering, sbabic@denx.de.
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+#ifndef _SYS_PROTO_H_
+#define _SYS_PROTO_H_
+
+void mx25_uart1_init_pins(void);
+
+#endif
diff --git a/board/karo/tx25/tx25.c b/board/karo/tx25/tx25.c
index ce75468..307ffd0 100644
--- a/board/karo/tx25/tx25.c
+++ b/board/karo/tx25/tx25.c
@@ -29,6 +29,7 @@ 
 #include <asm/arch/imx-regs.h>
 #include <asm/arch/imx25-pinmux.h>
 #include <asm/gpio.h>
+#include <asm/arch/sys_proto.h>
 
 static void mdelay(int n)
 {
@@ -142,8 +143,6 @@  void tx25_fec_init(void)
 int board_init()
 {
 #ifdef CONFIG_MXC_UART
-	extern void mx25_uart1_init_pins(void);
-
 	mx25_uart1_init_pins();
 #endif
 	/* board id for linux */