| Message ID | 20190723161357.26718-3-vaibhav@linux.ibm.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | powerpc/papr_scm: Workaround for failure of drc bind after kexec | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | Successfully applied on branch next (f3365d1a959d5c6527efe3d38276acc9b58e3f3f) |
| snowpatch_ozlabs/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 17 lines checked |
On Tue, Jul 23, 2019 at 09:43:55PM +0530, Vaibhav Jain wrote: > Update the hvcalls.h to include op-codes for new hcalls introduce to > manage SCM memory. Also update existing hcall definitions to reflect > current papr specification for SCM. > > The removed hcall op-codes H_SCM_MEM_QUERY, H_SCM_BLOCK_CLEAR were > transient proposals and there support was never implemented by > Power-VM nor they were used anywhere in Linux kernel. Hence we don't > expect anyone to be impacted by this change. > > Signed-off-by: Vaibhav Jain <vaibhav@linux.ibm.com> They really should not have been merged while only interim proposals. But since they have changed, better to update them than not, obviously. > --- > Change-log: > > v5: > * None. Re-spinning the patchset. > > v4: > * Updated the patch description mentioned current status of removed > hcall opcodes. [Mpe] > > v3: > * Added updated opcode for H_SCM_HEALTH [Oliver] > > v2: > * None new patch in this series. > --- > arch/powerpc/include/asm/hvcall.h | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/arch/powerpc/include/asm/hvcall.h b/arch/powerpc/include/asm/hvcall.h > index 463c63a9fcf1..11112023e327 100644 > --- a/arch/powerpc/include/asm/hvcall.h > +++ b/arch/powerpc/include/asm/hvcall.h > @@ -302,9 +302,14 @@ > #define H_SCM_UNBIND_MEM 0x3F0 > #define H_SCM_QUERY_BLOCK_MEM_BINDING 0x3F4 > #define H_SCM_QUERY_LOGICAL_MEM_BINDING 0x3F8 > -#define H_SCM_MEM_QUERY 0x3FC > -#define H_SCM_BLOCK_CLEAR 0x400 > -#define MAX_HCALL_OPCODE H_SCM_BLOCK_CLEAR > +#define H_SCM_UNBIND_ALL 0x3FC > +#define H_SCM_HEALTH 0x400 > +#define H_SCM_PERFORMANCE_STATS 0x418 > +#define MAX_HCALL_OPCODE H_SCM_PERFORMANCE_STATS > + > +/* Scope args for H_SCM_UNBIND_ALL */ > +#define H_UNBIND_SCOPE_ALL (0x1) > +#define H_UNBIND_SCOPE_DRC (0x2) > > /* H_VIOCTL functions */ > #define H_GET_VIOA_DUMP_SIZE 0x01
David Gibson <david@gibson.dropbear.id.au> writes: > On Tue, Jul 23, 2019 at 09:43:55PM +0530, Vaibhav Jain wrote: >> Update the hvcalls.h to include op-codes for new hcalls introduce to >> manage SCM memory. Also update existing hcall definitions to reflect >> current papr specification for SCM. >> >> The removed hcall op-codes H_SCM_MEM_QUERY, H_SCM_BLOCK_CLEAR were >> transient proposals and there support was never implemented by >> Power-VM nor they were used anywhere in Linux kernel. Hence we don't >> expect anyone to be impacted by this change. >> >> Signed-off-by: Vaibhav Jain <vaibhav@linux.ibm.com> > > They really should not have been merged while only interim proposals. > But since they have changed, better to update them than not, obviously. Yes, absolutely agree. It wasn't clear when I merged them that they were *unpublished* and *unstable*. Unfortunately we can't realistically wait for these APIs to be in a published PAPR spec because it seems to take about 5 years for a PAPR spec to escape the IBM firewall. cheers
diff --git a/arch/powerpc/include/asm/hvcall.h b/arch/powerpc/include/asm/hvcall.h index 463c63a9fcf1..11112023e327 100644 --- a/arch/powerpc/include/asm/hvcall.h +++ b/arch/powerpc/include/asm/hvcall.h @@ -302,9 +302,14 @@ #define H_SCM_UNBIND_MEM 0x3F0 #define H_SCM_QUERY_BLOCK_MEM_BINDING 0x3F4 #define H_SCM_QUERY_LOGICAL_MEM_BINDING 0x3F8 -#define H_SCM_MEM_QUERY 0x3FC -#define H_SCM_BLOCK_CLEAR 0x400 -#define MAX_HCALL_OPCODE H_SCM_BLOCK_CLEAR +#define H_SCM_UNBIND_ALL 0x3FC +#define H_SCM_HEALTH 0x400 +#define H_SCM_PERFORMANCE_STATS 0x418 +#define MAX_HCALL_OPCODE H_SCM_PERFORMANCE_STATS + +/* Scope args for H_SCM_UNBIND_ALL */ +#define H_UNBIND_SCOPE_ALL (0x1) +#define H_UNBIND_SCOPE_DRC (0x2) /* H_VIOCTL functions */ #define H_GET_VIOA_DUMP_SIZE 0x01
Update the hvcalls.h to include op-codes for new hcalls introduce to manage SCM memory. Also update existing hcall definitions to reflect current papr specification for SCM. The removed hcall op-codes H_SCM_MEM_QUERY, H_SCM_BLOCK_CLEAR were transient proposals and there support was never implemented by Power-VM nor they were used anywhere in Linux kernel. Hence we don't expect anyone to be impacted by this change. Signed-off-by: Vaibhav Jain <vaibhav@linux.ibm.com> --- Change-log: v5: * None. Re-spinning the patchset. v4: * Updated the patch description mentioned current status of removed hcall opcodes. [Mpe] v3: * Added updated opcode for H_SCM_HEALTH [Oliver] v2: * None new patch in this series. --- arch/powerpc/include/asm/hvcall.h | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-)