Message ID | AM0PR04MB4481691FEF03C0D471D00B9E88CF0@AM0PR04MB4481.eurprd04.prod.outlook.com |
---|---|
State | Accepted |
Delegated to: | Tom Rini |
Headers | show |
Series | [U-Boot] Please pull u-boot-mmc | expand |
On Mon, Jul 15, 2019 at 07:21:24AM +0000, Peng Fan wrote: > Hi Tom, > > Please pull u-boot-mmc, > CI build: https://travis-ci.org/MrVan/u-boot/builds/558716778 Note that I see a general small bit of SPL growth here. Can we do something about it? i.e. this from libretech_all_h3_cc_h5: spl-u-boot-spl: add: 0/0, grow: 5/-2 bytes: 260/-104 (156) function old new delta static.__mmc_switch 108 248 +140 mmc_startup_v4 516 572 +56 mmc_init 2272 2304 +32 mmc_switch_part 120 148 +28 static.mmc_set_card_speed 156 160 +4 mmc_switch 12 4 -8 mmc_send_status 212 116 -96 Applied to u-boot/master, thanks!
Hi Tom, > Subject: Re: Please pull u-boot-mmc > > On Mon, Jul 15, 2019 at 07:21:24AM +0000, Peng Fan wrote: > > > Hi Tom, > > > > Please pull u-boot-mmc, > > CI build: https://travis-ci.org/MrVan/u-boot/builds/558716778 > > Note that I see a general small bit of SPL growth here. Can we do something > about it? i.e. this from libretech_all_h3_cc_h5: Could you please share how to the comparation? Do you have a script? Thanks, Peng. > spl-u-boot-spl: add: 0/0, grow: 5/-2 bytes: 260/-104 (156) > function old > new delta > static.__mmc_switch 108 > 248 +140 > mmc_startup_v4 > 516 572 +56 > mmc_init > 2272 2304 +32 > mmc_switch_part > 120 148 +28 > static.mmc_set_card_speed 156 > 160 +4 > mmc_switch > 12 4 -8 > mmc_send_status > 212 116 -96 > > Applied to u-boot/master, thanks! > > -- > Tom
On Tue, Jul 16, 2019 at 02:03:02AM +0000, Peng Fan wrote: > Hi Tom, > > > Subject: Re: Please pull u-boot-mmc > > > > On Mon, Jul 15, 2019 at 07:21:24AM +0000, Peng Fan wrote: > > > > > Hi Tom, > > > > > > Please pull u-boot-mmc, > > > CI build: https://travis-ci.org/MrVan/u-boot/builds/558716778 > > > > Note that I see a general small bit of SPL growth here. Can we do something > > about it? i.e. this from libretech_all_h3_cc_h5: > > Could you please share how to the comparation? Do you have a script? Just one of the many features of buildman. My wrapper around it is: #!/bin/bash if [ $# -ne 1 -a $# -ne 2 ];then echo "Usage: $0 MACHINE [BRANCH]" exit 1 fi if [ ! -z $2 ]; then B=$2 else B=`git rev-parse --abbrev-ref HEAD` fi export SOURCE_DATE_EPOCH=`date +%s` ./tools/buildman/buildman -o /tmp/$1 -b $B --step 0 -SBCdevlk $1 ./tools/buildman/buildman -o /tmp/$1 -b $B --step 0 -SsBdevlk $1 rm -rf /tmp/$1