| Message ID | 20190610180526.11262-1-rfried.dev@gmail.com |
|---|---|
| State | Not Applicable |
| Delegated to: | Daniel Schwierzeck |
| Headers | show |
| Series | [U-Boot,v2,1/2] MIPS: add empty arch/clk.h | expand |
Am Mo., 10. Juni 2019 um 20:05 Uhr schrieb Ramon Fried <rfried.dev@gmail.com>: > > The file is needed for compilation of various > drivers (IE. macb). > Add empty implementation so compilation succeeds. > > Signed-off-by: Ramon Fried <rfried.dev@gmail.com> > --- > v2: Moved the new file to the correct location. > > arch/mips/include/asm/arch/clk.h | 11 +++++++++++ > 1 file changed, 11 insertions(+) > create mode 100644 arch/mips/include/asm/arch/clk.h > > diff --git a/arch/mips/include/asm/arch/clk.h b/arch/mips/include/asm/arch/clk.h > new file mode 100644 > index 0000000000..c01e0973cd > --- /dev/null > +++ b/arch/mips/include/asm/arch/clk.h > @@ -0,0 +1,11 @@ > +/* SPDX-License-Identifier: GPL-2.0+ */ > +/* > + * Copyright (c) Ramon Fried <rfried.dev@gmail.com> > + */ > + > +#ifndef __ASM_MIPS_ARCH_CLK_H > +#define __ASM_MIPS_ARCH_CLK_H > + > +/* Note: This is a placeholder header for driver compilation. */ > + > +#endif > -- > 2.21.0 > the macb driver pulls only some SoC specific enums or functions. This shouldn't be required anymore with driver model or clock framework. Especially if this driver is shared between different SoCs and architectures. Maybe you should rather fix the macb driver to not force asm/arch/clk.h e.g. by wrapping it with #ifndef CONFIG_CLK.
On Mon, Jun 17, 2019 at 2:42 PM Daniel Schwierzeck < daniel.schwierzeck@gmail.com> wrote: > Am Mo., 10. Juni 2019 um 20:05 Uhr schrieb Ramon Fried < > rfried.dev@gmail.com>: > > > > The file is needed for compilation of various > > drivers (IE. macb). > > Add empty implementation so compilation succeeds. > > > > Signed-off-by: Ramon Fried <rfried.dev@gmail.com> > > --- > > v2: Moved the new file to the correct location. > > > > arch/mips/include/asm/arch/clk.h | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > create mode 100644 arch/mips/include/asm/arch/clk.h > > > > diff --git a/arch/mips/include/asm/arch/clk.h > b/arch/mips/include/asm/arch/clk.h > > new file mode 100644 > > index 0000000000..c01e0973cd > > --- /dev/null > > +++ b/arch/mips/include/asm/arch/clk.h > > @@ -0,0 +1,11 @@ > > +/* SPDX-License-Identifier: GPL-2.0+ */ > > +/* > > + * Copyright (c) Ramon Fried <rfried.dev@gmail.com> > > + */ > > + > > +#ifndef __ASM_MIPS_ARCH_CLK_H > > +#define __ASM_MIPS_ARCH_CLK_H > > + > > +/* Note: This is a placeholder header for driver compilation. */ > > + > > +#endif > > -- > > 2.21.0 > > > > the macb driver pulls only some SoC specific enums or functions. This > shouldn't be required anymore with driver model or clock framework. > Especially if this driver is shared between different SoCs and > architectures. Maybe you should rather fix the macb driver to not > force asm/arch/clk.h e.g. by wrapping it with #ifndef CONFIG_CLK. > I totally agree with you, I created this patch as I thought this is what I was expected to do: I followed what RISCV did: /arch/riscv/include/asm/arch-generic/clk.h Thanks, Ramon. > > -- > - Daniel >
diff --git a/arch/mips/include/asm/arch/clk.h b/arch/mips/include/asm/arch/clk.h new file mode 100644 index 0000000000..c01e0973cd --- /dev/null +++ b/arch/mips/include/asm/arch/clk.h @@ -0,0 +1,11 @@ +/* SPDX-License-Identifier: GPL-2.0+ */ +/* + * Copyright (c) Ramon Fried <rfried.dev@gmail.com> + */ + +#ifndef __ASM_MIPS_ARCH_CLK_H +#define __ASM_MIPS_ARCH_CLK_H + +/* Note: This is a placeholder header for driver compilation. */ + +#endif
The file is needed for compilation of various drivers (IE. macb). Add empty implementation so compilation succeeds. Signed-off-by: Ramon Fried <rfried.dev@gmail.com> --- v2: Moved the new file to the correct location. arch/mips/include/asm/arch/clk.h | 11 +++++++++++ 1 file changed, 11 insertions(+) create mode 100644 arch/mips/include/asm/arch/clk.h