| Message ID | 1559829493-28457-1-git-send-email-cai@lca.pw (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 04db3ede40ae4fc23a5c4237254c4a53bbe4c1f2 |
| Headers | show |
| Series | powerpc/cacheflush: fix variable set but not used | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | Successfully applied on branch next (a3bf9fbdad600b1e4335dd90979f8d6072e4f602) |
| snowpatch_ozlabs/build-ppc64le | success | Build succeeded |
| snowpatch_ozlabs/build-ppc64be | success | Build succeeded |
| snowpatch_ozlabs/build-ppc64e | success | Build succeeded |
| snowpatch_ozlabs/build-pmac32 | success | Build succeeded |
| snowpatch_ozlabs/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 14 lines checked |
Ping. On Thu, 2019-06-06 at 09:58 -0400, Qian Cai wrote: > The powerpc's flush_cache_vmap() is defined as a macro and never use > both of its arguments, so it will generate a compilation warning, > > lib/ioremap.c: In function 'ioremap_page_range': > lib/ioremap.c:203:16: warning: variable 'start' set but not used > [-Wunused-but-set-variable] > > Fix it by making it an inline function. > > Signed-off-by: Qian Cai <cai@lca.pw> > --- > arch/powerpc/include/asm/cacheflush.h | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/arch/powerpc/include/asm/cacheflush.h > b/arch/powerpc/include/asm/cacheflush.h > index 74d60cfe8ce5..fd318f7c3eed 100644 > --- a/arch/powerpc/include/asm/cacheflush.h > +++ b/arch/powerpc/include/asm/cacheflush.h > @@ -29,9 +29,12 @@ > * not expect this type of fault. flush_cache_vmap is not exactly the right > * place to put this, but it seems to work well enough. > */ > -#define flush_cache_vmap(start, end) do { asm > volatile("ptesync" ::: "memory"); } while (0) > +static inline void flush_cache_vmap(unsigned long start, unsigned long end) > +{ > + asm volatile("ptesync" ::: "memory"); > +} > #else > -#define flush_cache_vmap(start, end) do { } while (0) > +static inline void flush_cache_vmap(unsigned long start, unsigned long end) { > } > #endif > > #define ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE 1
On Thu, 2019-06-06 at 13:58:13 UTC, Qian Cai wrote: > The powerpc's flush_cache_vmap() is defined as a macro and never use > both of its arguments, so it will generate a compilation warning, > > lib/ioremap.c: In function 'ioremap_page_range': > lib/ioremap.c:203:16: warning: variable 'start' set but not used > [-Wunused-but-set-variable] > > Fix it by making it an inline function. > > Signed-off-by: Qian Cai <cai@lca.pw> Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/04db3ede40ae4fc23a5c4237254c4a53bbe4c1f2 cheers
diff --git a/arch/powerpc/include/asm/cacheflush.h b/arch/powerpc/include/asm/cacheflush.h index 74d60cfe8ce5..fd318f7c3eed 100644 --- a/arch/powerpc/include/asm/cacheflush.h +++ b/arch/powerpc/include/asm/cacheflush.h @@ -29,9 +29,12 @@ * not expect this type of fault. flush_cache_vmap is not exactly the right * place to put this, but it seems to work well enough. */ -#define flush_cache_vmap(start, end) do { asm volatile("ptesync" ::: "memory"); } while (0) +static inline void flush_cache_vmap(unsigned long start, unsigned long end) +{ + asm volatile("ptesync" ::: "memory"); +} #else -#define flush_cache_vmap(start, end) do { } while (0) +static inline void flush_cache_vmap(unsigned long start, unsigned long end) { } #endif #define ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE 1
The powerpc's flush_cache_vmap() is defined as a macro and never use both of its arguments, so it will generate a compilation warning, lib/ioremap.c: In function 'ioremap_page_range': lib/ioremap.c:203:16: warning: variable 'start' set but not used [-Wunused-but-set-variable] Fix it by making it an inline function. Signed-off-by: Qian Cai <cai@lca.pw> --- arch/powerpc/include/asm/cacheflush.h | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)