| Message ID | 20190525005302.27164-1-ruslan@babayev.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [net-next,v2,1/2] i2c: acpi: export i2c_acpi_find_adapter_by_handle | expand |
On Fri, May 24, 2019 at 05:53:01PM -0700, Ruslan Babayev wrote: > +struct i2c_adapter *i2c_acpi_find_adapter_by_handle(acpi_handle handle); > #else > static inline bool i2c_acpi_get_i2c_resource(struct acpi_resource *ares, > struct acpi_resource_i2c_serialbus **i2c) > @@ -996,6 +998,10 @@ static inline struct i2c_client *i2c_acpi_new_device(struct device *dev, > { > return NULL; > } > +struct i2c_adapter *i2c_acpi_find_adapter_by_handle(acpi_handle handle) This should be static inline, I think. > +{ > + return NULL; > +} > #endif /* CONFIG_ACPI */ > > #endif /* _LINUX_I2C_H */ > -- > 2.17.1
On Fri, May 24, 2019 at 05:53:01PM -0700, Ruslan Babayev wrote: > This allows drivers to lookup i2c adapters on ACPI based systems similar to > of_get_i2c_adapter_by_node() with DT based systems. > > Signed-off-by: Ruslan Babayev <ruslan@babayev.com> > Cc: xe-linux-external@cisco.com Please have a look how your patches look in my inbox: May 05 Ruslan Babayev ( 129) [PATCH] net: phy: sfp: enable i2c-bus detection on ACPI based systems May 05 Ruslan Babayev ( 65) ├─>[PATCH 1/2] i2c: acpi: export i2c_acpi_find_adapter_by_handle May 24 Ruslan Babayev ( 65) └─>[PATCH net-next v2 1/2] i2c: acpi: export i2c_acpi_find_adapter_by_handle May 05 Ruslan Babayev ( 65) [PATCH net-next 1/2] i2c: acpi: export i2c_acpi_find_adapter_by_handle May 06 Ruslan Babayev ( 3) ├─>[PATCH RFC v2 net-next] Enable SFP support on ACPI May 06 Ruslan Babayev ( 65) ├─>[PATCH RFC v2 net-next 1/2] i2c: acpi: export i2c_acpi_find_adapter_by_handle May 06 Ruslan Babayev ( 120) └─>[PATCH RFC v2 net-next 2/2] net: phy: sfp: enable i2c-bus detection on ACPI based systems May 07 Ruslan Babayev ( 154) └─&─> May 07 Ruslan Babayev ( 10) └─> May 22 Ruslan Babayev ( 29) └─> May 05 Ruslan Babayev ( 93) [PATCH net-next 2/2] net: phy: sfp: enable i2c-bus detection on ACPI based systems May 06 Ruslan Babayev ( 25) ├─&─> May 06 Ruslan Babayev ( 99) └─&─> This is highly confusing, and super hard to find out which patches belong together. v2 2/2 seems even missing. Please resend this as a new series without any in-reply-to, and a fresh cover-letter, so I know which one to apply to my tree. Thanks, Wolfram
Wolfram Sang writes: > On Fri, May 24, 2019 at 05:53:01PM -0700, Ruslan Babayev wrote: >> This allows drivers to lookup i2c adapters on ACPI based systems similar to >> of_get_i2c_adapter_by_node() with DT based systems. >> >> Signed-off-by: Ruslan Babayev <ruslan@babayev.com> >> Cc: xe-linux-external@cisco.com > > Please have a look how your patches look in my inbox: > > May 05 Ruslan Babayev ( 129) [PATCH] net: phy: sfp: enable i2c-bus detection on ACPI based systems > May 05 Ruslan Babayev ( 65) ├─>[PATCH 1/2] i2c: acpi: export i2c_acpi_find_adapter_by_handle > May 24 Ruslan Babayev ( 65) └─>[PATCH net-next v2 1/2] i2c: acpi: export i2c_acpi_find_adapter_by_handle > May 05 Ruslan Babayev ( 65) [PATCH net-next 1/2] i2c: acpi: export i2c_acpi_find_adapter_by_handle > May 06 Ruslan Babayev ( 3) ├─>[PATCH RFC v2 net-next] Enable SFP support on ACPI > May 06 Ruslan Babayev ( 65) ├─>[PATCH RFC v2 net-next 1/2] i2c: acpi: export i2c_acpi_find_adapter_by_handle > May 06 Ruslan Babayev ( 120) └─>[PATCH RFC v2 net-next 2/2] net: phy: sfp: enable i2c-bus detection on ACPI based systems > May 07 Ruslan Babayev ( 154) └─&─> > May 07 Ruslan Babayev ( 10) └─> > May 22 Ruslan Babayev ( 29) └─> > May 05 Ruslan Babayev ( 93) [PATCH net-next 2/2] net: phy: sfp: enable i2c-bus detection on ACPI based systems > May 06 Ruslan Babayev ( 25) ├─&─> > May 06 Ruslan Babayev ( 99) └─&─> > > This is highly confusing, and super hard to find out which patches belong > together. v2 2/2 seems even missing. Please resend this as a new series without > any in-reply-to, and a fresh cover-letter, so I know which one to apply to my > tree. > > Thanks, > > Wolfram Will do, sorry about that.
Mika Westerberg writes: > On Fri, May 24, 2019 at 05:53:01PM -0700, Ruslan Babayev wrote: >> +struct i2c_adapter *i2c_acpi_find_adapter_by_handle(acpi_handle handle); >> #else >> static inline bool i2c_acpi_get_i2c_resource(struct acpi_resource *ares, >> struct acpi_resource_i2c_serialbus **i2c) >> @@ -996,6 +998,10 @@ static inline struct i2c_client *i2c_acpi_new_device(struct device *dev, >> { >> return NULL; >> } >> +struct i2c_adapter *i2c_acpi_find_adapter_by_handle(acpi_handle handle) > > This should be static inline, I think. > >> +{ >> + return NULL; >> +} >> #endif /* CONFIG_ACPI */ >> >> #endif /* _LINUX_I2C_H */ >> -- >> 2.17.1 Thanks Mika, will make the change and repost the patches.
diff --git a/drivers/i2c/i2c-core-acpi.c b/drivers/i2c/i2c-core-acpi.c index 272800692088..964687534754 100644 --- a/drivers/i2c/i2c-core-acpi.c +++ b/drivers/i2c/i2c-core-acpi.c @@ -337,7 +337,7 @@ static int i2c_acpi_find_match_device(struct device *dev, void *data) return ACPI_COMPANION(dev) == data; } -static struct i2c_adapter *i2c_acpi_find_adapter_by_handle(acpi_handle handle) +struct i2c_adapter *i2c_acpi_find_adapter_by_handle(acpi_handle handle) { struct device *dev; @@ -345,6 +345,7 @@ static struct i2c_adapter *i2c_acpi_find_adapter_by_handle(acpi_handle handle) i2c_acpi_find_match_adapter); return dev ? i2c_verify_adapter(dev) : NULL; } +EXPORT_SYMBOL_GPL(i2c_acpi_find_adapter_by_handle); static struct i2c_client *i2c_acpi_find_client_by_adev(struct acpi_device *adev) { diff --git a/include/linux/i2c.h b/include/linux/i2c.h index 1308126fc384..78f7d39ea5bc 100644 --- a/include/linux/i2c.h +++ b/include/linux/i2c.h @@ -21,6 +21,7 @@ #include <linux/rtmutex.h> #include <linux/irqdomain.h> /* for Host Notify IRQ */ #include <linux/of.h> /* for struct device_node */ +#include <linux/acpi.h> /* for acpi_handle */ #include <linux/swab.h> /* for swab16 */ #include <uapi/linux/i2c.h> @@ -981,6 +982,7 @@ bool i2c_acpi_get_i2c_resource(struct acpi_resource *ares, u32 i2c_acpi_find_bus_speed(struct device *dev); struct i2c_client *i2c_acpi_new_device(struct device *dev, int index, struct i2c_board_info *info); +struct i2c_adapter *i2c_acpi_find_adapter_by_handle(acpi_handle handle); #else static inline bool i2c_acpi_get_i2c_resource(struct acpi_resource *ares, struct acpi_resource_i2c_serialbus **i2c) @@ -996,6 +998,10 @@ static inline struct i2c_client *i2c_acpi_new_device(struct device *dev, { return NULL; } +struct i2c_adapter *i2c_acpi_find_adapter_by_handle(acpi_handle handle) +{ + return NULL; +} #endif /* CONFIG_ACPI */ #endif /* _LINUX_I2C_H */
This allows drivers to lookup i2c adapters on ACPI based systems similar to of_get_i2c_adapter_by_node() with DT based systems. Signed-off-by: Ruslan Babayev <ruslan@babayev.com> Cc: xe-linux-external@cisco.com --- drivers/i2c/i2c-core-acpi.c | 3 ++- include/linux/i2c.h | 6 ++++++ 2 files changed, 8 insertions(+), 1 deletion(-)