| Message ID | 20190520193223.14071-1-b.bilas@grinn-global.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [RFC,1/4] configs/bananapro_defconfig: bump Linux to 5.1.1 | expand |
Hello, On Mon, 20 May 2019 21:32:20 +0200 Bartosz Bilas <b.bilas@grinn-global.com> wrote: > Signed-off-by: Bartosz Bilas <b.bilas@grinn-global.com> > --- > configs/bananapro_defconfig | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Why did you split your changes into four patches ? As I understand it, the current bananapro_defconfig already supports WiFi, so if the bump to Linux 5.1.1 breaks WiFi and requires the fixes of the three other patches, then you should have a single patch that does all. Without this, you break bisectability: if I apply only your PATCH 1/4, then the WiFi feature which was working is no longer working. Of course, if WiFi was in fact not working with the current defconfig (i.e before any of your patches), then it's fine to split the patches. Just perhaps patches 2, 3 and 4 could be the same, because it's all about making WiFi work. Could you clarify this point, and send a new iteration ? Thanks, Thomas
Hi Thomas, On 26.05.2019 21:26, Thomas Petazzoni wrote: > Hello, > > On Mon, 20 May 2019 21:32:20 +0200 > Bartosz Bilas <b.bilas@grinn-global.com> wrote: > >> Signed-off-by: Bartosz Bilas <b.bilas@grinn-global.com> >> --- >> configs/bananapro_defconfig | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) > Why did you split your changes into four patches ? As I understand it, > the current bananapro_defconfig already supports WiFi, Yes, that's right. > so if the bump > to Linux 5.1.1 breaks WiFi and requires the fixes of the three other > patches, then you should have a single patch that does all. > > Without this, you break bisectability: if I apply only your PATCH 1/4, > then the WiFi feature which was working is no longer working. Ah, I haven't thought about that in that way, I'll keep it in my mind ;) > > Of course, if WiFi was in fact not working with the current defconfig > (i.e before any of your patches), then it's fine to split the patches. > Just perhaps patches 2, 3 and 4 could be the same, because it's all > about making WiFi work. Ok, thanks for the hints. > > Could you clarify this point, and send a new iteration ? I've fixed that and I'm going to send a new one soon. > > Thanks, > > Thomas Best Bartek
diff --git a/configs/bananapro_defconfig b/configs/bananapro_defconfig index a6433ee597..d5284bdd4c 100644 --- a/configs/bananapro_defconfig +++ b/configs/bananapro_defconfig @@ -4,8 +4,8 @@ BR2_cortex_a7=y BR2_ARM_EABIHF=y BR2_ARM_FPU_NEON_VFPV4=y -# Linux headers same as kernel, a 4.14 series -BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_14=y +# Linux headers same as kernel, a 5.1 series +BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_1=y # Toolchain BR2_TOOLCHAIN_BUILDROOT_WCHAR=y @@ -22,7 +22,7 @@ BR2_ROOTFS_POST_IMAGE_SCRIPT="board/lemaker/bananapro/post-image.sh" # Kernel BR2_LINUX_KERNEL=y BR2_LINUX_KERNEL_CUSTOM_VERSION=y -BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.14.116" +BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.1.1" BR2_LINUX_KERNEL_USE_DEFCONFIG=y BR2_LINUX_KERNEL_DEFCONFIG="sunxi" BR2_LINUX_KERNEL_CONFIG_FRAGMENT_FILES="board/lemaker/bananapro/linux-wifi.fragment"
Signed-off-by: Bartosz Bilas <b.bilas@grinn-global.com> --- configs/bananapro_defconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)