diff mbox series

[committed] Clean up libgomp GCC 5 legacy support (was: Remove unused openacc call)

Message ID 87bm0gezi4.fsf@euler.schwinge.homeip.net
State New
Headers show
Series [committed] Clean up libgomp GCC 5 legacy support (was: Remove unused openacc call) | expand

Commit Message

Thomas Schwinge May 6, 2019, 8:52 a.m. UTC 
Hi!

On Wed, 20 Apr 2016 12:27:27 +0200, Jakub Jelinek <jakub@redhat.com> wrote:
> On Wed, Apr 20, 2016 at 10:46:38AM +0200, Thomas Schwinge wrote:
> >     Clean up libgomp GCC 5 legacy support
> >     
> >     	libgomp/
> >     	* config/nvptx/oacc-parallel.c: Empty file.
|       	* oacc-parallel.c: Add comments to legacy entry points (GCC 5).
> 
> Ok for trunk and 6.2, we don't need this for 6.1.

I don't know anymore why I didn't commit this back then.

Cesar has since committed to trunk in r263236 the patch that truncates
'libgomp/config/nvptx/oacc-parallel.c', and I've now committed the
documentation update to trunk in r270901, see attached.


Grüße
 Thomas
diff mbox series

Patch

From 75a3472e37d26152afb7b08a6fda2691c4b0ee74 Mon Sep 17 00:00:00 2001
From: tschwinge <tschwinge@138bc75d-0d04-0410-961f-82ee72b054a4>
Date: Mon, 6 May 2019 08:49:55 +0000
Subject: [PATCH] Clean up libgomp GCC 5 legacy support

	libgomp/
	* oacc-parallel.c: Add comments to legacy entry points (GCC 5).

git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@270901 138bc75d-0d04-0410-961f-82ee72b054a4
---
 libgomp/ChangeLog       | 4 ++++
 libgomp/oacc-parallel.c | 6 +++++-
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/libgomp/ChangeLog b/libgomp/ChangeLog
index 30bb2d4beba..64e0a8ad8df 100644
--- a/libgomp/ChangeLog
+++ b/libgomp/ChangeLog
@@ -1,3 +1,7 @@ 
+2019-05-06  Thomas Schwinge  <thomas@codesourcery.com>
+
+	* oacc-parallel.c: Add comments to legacy entry points (GCC 5).
+
 2019-03-27  Kevin Buettner  <kevinb@redhat.com>
 
 	* team.c (gomp_team_start): Initialize pool->threads[0].
diff --git a/libgomp/oacc-parallel.c b/libgomp/oacc-parallel.c
index b77c5e8b9c5..f5fb63c5b5a 100644
--- a/libgomp/oacc-parallel.c
+++ b/libgomp/oacc-parallel.c
@@ -275,7 +275,7 @@  GOACC_parallel_keyed (int flags_m, void (*fn) (void *),
   acc_dev->openacc.async_set_async_func (acc_async_sync);
 }
 
-/* Legacy entry point, only provide host execution.  */
+/* Legacy entry point (GCC 5).  Only provide host fallback execution.  */
 
 void
 GOACC_parallel (int flags_m, void (*fn) (void *),
@@ -649,12 +649,16 @@  GOACC_wait (int async, int num_waits, ...)
     acc_wait_all_async (async);
 }
 
+/* Legacy entry point (GCC 5).  */
+
 int
 GOACC_get_num_threads (void)
 {
   return 1;
 }
 
+/* Legacy entry point (GCC 5).  */
+
 int
 GOACC_get_thread_num (void)
 {
-- 
2.17.1