From patchwork Mon May 6 08:52:19 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Thomas Schwinge X-Patchwork-Id: 1095732 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-500130-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="J2SX/bKU"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 44yGhv0kPnz9s4V for ; Mon, 6 May 2019 18:52:44 +1000 (AEST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; q=dns; s=default; b=XDVDOf5slD2FusTO N4DsrRsihufDNx1jEG68Wct8+Q0Hd2DiQPpo5YzYzlcSLcWfDVk17mzwqv+OSTeG tJIkXQdSrg2VkC+DfDSJf0NOmKcF6z0YYC/V5A4gKZG7GUGVui4A60m6i2k/MYP4 Nx4/wCQ00KDuxIH/pCo8Gusqk5o= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=default; bh=IR5ou8Ft9EKjvNklnFzJwB VV+kI=; b=J2SX/bKUQ9XDl+sOnwrqVlgOrwsBB7+RYYLP1pMnTGDm3udd1u9Vz0 P628tz+hlDG/Q8p4dbtbpBm6vAEcF/ziiK3bOH+Go8OuFvKWTml3kJbEIRKDNWfE ktXX/Hw2adBMUEmdDXodKog0/0DUn/dIIGAv+SkK+e58zTjyGo1Zs= Received: (qmail 57518 invoked by alias); 6 May 2019 08:52:37 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 56611 invoked by uid 89); 6 May 2019 08:52:37 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-15.4 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.1 spammy=61, sk:thomas, 6.1, 62 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 06 May 2019 08:52:35 +0000 Received: from svr-orw-mbx-02.mgc.mentorg.com ([147.34.90.202]) by relay1.mentorg.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-SHA384:256) id 1hNZMP-0002cU-HK from Thomas_Schwinge@mentor.com ; Mon, 06 May 2019 01:52:33 -0700 Received: from SVR-ORW-MBX-07.mgc.mentorg.com (147.34.90.207) by svr-orw-mbx-02.mgc.mentorg.com (147.34.90.202) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Mon, 6 May 2019 01:52:31 -0700 Received: from tftp-cs (147.34.91.1) by SVR-ORW-MBX-07.mgc.mentorg.com (147.34.90.207) with Microsoft SMTP Server id 15.0.1320.4 via Frontend Transport; Mon, 6 May 2019 01:52:31 -0700 Received: by tftp-cs (Postfix, from userid 49978) id A74EFC2409; Mon, 6 May 2019 01:52:30 -0700 (PDT) From: Thomas Schwinge To: CC: Jakub Jelinek , Tom de Vries Subject: [committed] Clean up libgomp GCC 5 legacy support (was: Remove unused openacc call) In-Reply-To: <20160420102727.GC2850@laptop.zalov.cz> References: <56411718.6080503@acm.org> <87k2js3bwx.fsf@kepler.schwinge.homeip.net> <20160420102727.GC2850@laptop.zalov.cz> <1e40ad5b-dfc2-fc93-f4df-424fc5e468aa@codesourcery.com> User-Agent: Notmuch/0.9-125-g4686d11 (http://notmuchmail.org) Emacs/26.1 (x86_64-pc-linux-gnu) Date: Mon, 6 May 2019 10:52:19 +0200 Message-ID: <87bm0gezi4.fsf@euler.schwinge.homeip.net> MIME-Version: 1.0 Hi! On Wed, 20 Apr 2016 12:27:27 +0200, Jakub Jelinek wrote: > On Wed, Apr 20, 2016 at 10:46:38AM +0200, Thomas Schwinge wrote: > > Clean up libgomp GCC 5 legacy support > > > > libgomp/ > > * config/nvptx/oacc-parallel.c: Empty file. | * oacc-parallel.c: Add comments to legacy entry points (GCC 5). > > Ok for trunk and 6.2, we don't need this for 6.1. I don't know anymore why I didn't commit this back then. Cesar has since committed to trunk in r263236 the patch that truncates 'libgomp/config/nvptx/oacc-parallel.c', and I've now committed the documentation update to trunk in r270901, see attached. Grüße Thomas From 75a3472e37d26152afb7b08a6fda2691c4b0ee74 Mon Sep 17 00:00:00 2001 From: tschwinge Date: Mon, 6 May 2019 08:49:55 +0000 Subject: [PATCH] Clean up libgomp GCC 5 legacy support libgomp/ * oacc-parallel.c: Add comments to legacy entry points (GCC 5). git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@270901 138bc75d-0d04-0410-961f-82ee72b054a4 --- libgomp/ChangeLog | 4 ++++ libgomp/oacc-parallel.c | 6 +++++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/libgomp/ChangeLog b/libgomp/ChangeLog index 30bb2d4beba..64e0a8ad8df 100644 --- a/libgomp/ChangeLog +++ b/libgomp/ChangeLog @@ -1,3 +1,7 @@ +2019-05-06 Thomas Schwinge + + * oacc-parallel.c: Add comments to legacy entry points (GCC 5). + 2019-03-27 Kevin Buettner * team.c (gomp_team_start): Initialize pool->threads[0]. diff --git a/libgomp/oacc-parallel.c b/libgomp/oacc-parallel.c index b77c5e8b9c5..f5fb63c5b5a 100644 --- a/libgomp/oacc-parallel.c +++ b/libgomp/oacc-parallel.c @@ -275,7 +275,7 @@ GOACC_parallel_keyed (int flags_m, void (*fn) (void *), acc_dev->openacc.async_set_async_func (acc_async_sync); } -/* Legacy entry point, only provide host execution. */ +/* Legacy entry point (GCC 5). Only provide host fallback execution. */ void GOACC_parallel (int flags_m, void (*fn) (void *), @@ -649,12 +649,16 @@ GOACC_wait (int async, int num_waits, ...) acc_wait_all_async (async); } +/* Legacy entry point (GCC 5). */ + int GOACC_get_num_threads (void) { return 1; } +/* Legacy entry point (GCC 5). */ + int GOACC_get_thread_num (void) { -- 2.17.1