diff mbox series

[Bionic,Cosmic,Disco] UBUNTU: SAUCE: [ALSA] Headset fixup for System76 Gazelle (gaze14)

Message ID 8974a819-497a-48cc-b5f1-eb32fe2f2de8@www.fastmail.com
State New
Headers show
Series [Bionic,Cosmic,Disco] UBUNTU: SAUCE: [ALSA] Headset fixup for System76 Gazelle (gaze14) | expand

Commit Message

Jeremy Soller May 3, 2019, 5:27 p.m. UTC 
BugLink: https://bugs.launchpad.net/bugs/1827555

On the System76 Gazelle (gaze14), there is a headset microphone input attached
to 0x1a that does not have a jack detect. In order to get it working, the pin
configuration needs to be set correctly, and the
ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC fixup needs to be applied. This is
identical to the patch already applied for the System76 Darter Pro (darp5).

Signed-off-by: Jeremy Soller <jeremy@system76.com>

---

Comments

Kleber Sacilotto de Souza May 6, 2019, 3:53 p.m. UTC | #1 
On 5/3/19 7:27 PM, Jeremy Soller wrote:
> BugLink: https://bugs.launchpad.net/bugs/1827555
> 
> On the System76 Gazelle (gaze14), there is a headset microphone input attached
> to 0x1a that does not have a jack detect. In order to get it working, the pin
> configuration needs to be set correctly, and the
> ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC fixup needs to be applied. This is
> identical to the patch already applied for the System76 Darter Pro (darp5).
> 
> Signed-off-by: Jeremy Soller <jeremy@system76.com>
> 
> ---
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index f5b510f119ed..4ea3affad617 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -6931,6 +6931,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
>         SND_PCI_QUIRK(0x1462, 0xb120, "MSI Cubi MS-B120", ALC283_FIXUP_HEADSET_MIC),
>         SND_PCI_QUIRK(0x1462, 0xb171, "Cubi N 8GL (MS-B171)", ALC283_FIXUP_HEADSET_MIC),
>         SND_PCI_QUIRK(0x1558, 0x1325, "System76 Darter Pro (darp5)", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
> +       SND_PCI_QUIRK(0x1558, 0x8550, "System76 Gazelle (gaze14)", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
>         SND_PCI_QUIRK(0x17aa, 0x1036, "Lenovo P520", ALC233_FIXUP_LENOVO_MULTI_CODECS),
>         SND_PCI_QUIRK(0x17aa, 0x20f2, "Thinkpad SL410/510", ALC269_FIXUP_SKU_IGNORE),
>         SND_PCI_QUIRK(0x17aa, 0x215e, "Thinkpad L512", ALC269_FIXUP_SKU_IGNORE),
> 

Hi Jeremy,

Has this patch been submitted upstream?


Thanks,
Kleber
Jeremy Soller May 7, 2019, 12:57 p.m. UTC | #2 
Yes, it was submitted upstream last week. It has not been merged upstream yet.
Jeremy Soller May 7, 2019, 9:11 p.m. UTC | #3 
Updated patch adding second PCI ID:

BugLink: https://bugs.launchpad.net/bugs/1827555

On the System76 Gazelle (gaze14), there is a headset microphone input attached
to 0x1a that does not have a jack detect. In order to get it working, the pin
configuration needs to be set correctly, and the
ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC fixup needs to be applied. This is
identical to the patch already applied for the System76 Darter Pro (darp5).

Signed-off-by: Jeremy Soller <jeremy@system76.com>

---
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index f5b510f119ed..4ea3affad617 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -6931,6 +6931,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
        SND_PCI_QUIRK(0x1462, 0xb120, "MSI Cubi MS-B120", ALC283_FIXUP_HEADSET_MIC),
        SND_PCI_QUIRK(0x1462, 0xb171, "Cubi N 8GL (MS-B171)", ALC283_FIXUP_HEADSET_MIC),
        SND_PCI_QUIRK(0x1558, 0x1325, "System76 Darter Pro (darp5)", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
+       SND_PCI_QUIRK(0x1558, 0x8550, "System76 Gazelle (gaze14)", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
+       SND_PCI_QUIRK(0x1558, 0x8560, "System76 Gazelle (gaze14)", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
        SND_PCI_QUIRK(0x17aa, 0x1036, "Lenovo P520", ALC233_FIXUP_LENOVO_MULTI_CODECS),
        SND_PCI_QUIRK(0x17aa, 0x20f2, "Thinkpad SL410/510", ALC269_FIXUP_SKU_IGNORE),
        SND_PCI_QUIRK(0x17aa, 0x215e, "Thinkpad L512", ALC269_FIXUP_SKU_IGNORE),
Kleber Sacilotto de Souza May 8, 2019, 9:23 a.m. UTC | #4 
On 5/7/19 11:11 PM, Jeremy Soller wrote:
> Updated patch adding second PCI ID:
> 
> BugLink: https://bugs.launchpad.net/bugs/1827555
> 
> On the System76 Gazelle (gaze14), there is a headset microphone input attached
> to 0x1a that does not have a jack detect. In order to get it working, the pin
> configuration needs to be set correctly, and the
> ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC fixup needs to be applied. This is
> identical to the patch already applied for the System76 Darter Pro (darp5).
> 
> Signed-off-by: Jeremy Soller <jeremy@system76.com>

This patch has now been applied at the sound.git repo:
https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git/commit/?id=80a5052db75131423b67f38b21958555d7d970e4

So we can remove the "UBUNTU: SAUCE:" from the subject line and add the
provenance as:

Signed-off-by: Jeremy Soller <jeremy@system76.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
(cherry picked from commit 80a5052db75131423b67f38b21958555d7d970e4
git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git)


With the above changes applied:

Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>

> 
> ---
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index f5b510f119ed..4ea3affad617 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -6931,6 +6931,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
>         SND_PCI_QUIRK(0x1462, 0xb120, "MSI Cubi MS-B120", ALC283_FIXUP_HEADSET_MIC),
>         SND_PCI_QUIRK(0x1462, 0xb171, "Cubi N 8GL (MS-B171)", ALC283_FIXUP_HEADSET_MIC),
>         SND_PCI_QUIRK(0x1558, 0x1325, "System76 Darter Pro (darp5)", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
> +       SND_PCI_QUIRK(0x1558, 0x8550, "System76 Gazelle (gaze14)", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
> +       SND_PCI_QUIRK(0x1558, 0x8560, "System76 Gazelle (gaze14)", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
>         SND_PCI_QUIRK(0x17aa, 0x1036, "Lenovo P520", ALC233_FIXUP_LENOVO_MULTI_CODECS),
>         SND_PCI_QUIRK(0x17aa, 0x20f2, "Thinkpad SL410/510", ALC269_FIXUP_SKU_IGNORE),
>         SND_PCI_QUIRK(0x17aa, 0x215e, "Thinkpad L512", ALC269_FIXUP_SKU_IGNORE),
>
Seth Forshee May 8, 2019, 2:15 p.m. UTC | #5 
On Fri, May 03, 2019 at 01:27:37PM -0400, Jeremy Soller wrote:
> BugLink: https://bugs.launchpad.net/bugs/1827555
> 
> On the System76 Gazelle (gaze14), there is a headset microphone input attached
> to 0x1a that does not have a jack detect. In order to get it working, the pin
> configuration needs to be set correctly, and the
> ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC fixup needs to be applied. This is
> identical to the patch already applied for the System76 Darter Pro (darp5).
> 
> Signed-off-by: Jeremy Soller <jeremy@system76.com>

Acked-by: Seth Forshee <seth.forshee@canonical.com>

Applied to unstable/master, thanks!
Kleber Sacilotto de Souza May 8, 2019, 5:32 p.m. UTC | #6 
On 5/8/19 11:23 AM, Kleber Souza wrote:
> On 5/7/19 11:11 PM, Jeremy Soller wrote:
>> Updated patch adding second PCI ID:
>>
>> BugLink: https://bugs.launchpad.net/bugs/1827555
>>
>> On the System76 Gazelle (gaze14), there is a headset microphone input attached
>> to 0x1a that does not have a jack detect. In order to get it working, the pin
>> configuration needs to be set correctly, and the
>> ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC fixup needs to be applied. This is
>> identical to the patch already applied for the System76 Darter Pro (darp5).
>>
>> Signed-off-by: Jeremy Soller <jeremy@system76.com>
> 
> This patch has now been applied at the sound.git repo:
> https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git/commit/?id=80a5052db75131423b67f38b21958555d7d970e4
> 
> So we can remove the "UBUNTU: SAUCE:" from the subject line and add the
> provenance as:
> 
> Signed-off-by: Jeremy Soller <jeremy@system76.com>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> (cherry picked from commit 80a5052db75131423b67f38b21958555d7d970e4
> git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git)
> 
> 
> With the above changes applied:
> 
> Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
> 
>>
>> ---
>> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
>> index f5b510f119ed..4ea3affad617 100644
>> --- a/sound/pci/hda/patch_realtek.c
>> +++ b/sound/pci/hda/patch_realtek.c
>> @@ -6931,6 +6931,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
>>         SND_PCI_QUIRK(0x1462, 0xb120, "MSI Cubi MS-B120", ALC283_FIXUP_HEADSET_MIC),
>>         SND_PCI_QUIRK(0x1462, 0xb171, "Cubi N 8GL (MS-B171)", ALC283_FIXUP_HEADSET_MIC),
>>         SND_PCI_QUIRK(0x1558, 0x1325, "System76 Darter Pro (darp5)", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
>> +       SND_PCI_QUIRK(0x1558, 0x8550, "System76 Gazelle (gaze14)", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
>> +       SND_PCI_QUIRK(0x1558, 0x8560, "System76 Gazelle (gaze14)", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
>>         SND_PCI_QUIRK(0x17aa, 0x1036, "Lenovo P520", ALC233_FIXUP_LENOVO_MULTI_CODECS),
>>         SND_PCI_QUIRK(0x17aa, 0x20f2, "Thinkpad SL410/510", ALC269_FIXUP_SKU_IGNORE),
>>         SND_PCI_QUIRK(0x17aa, 0x215e, "Thinkpad L512", ALC269_FIXUP_SKU_IGNORE),
>>
> 

Applied to bionic, cosmic and disco/master-next branches, with the
provenance and subject line copied from the sound.git repo commit,
and marking the patch for bionic and cosmic as "backported from ..."
since they required some context adjustments.

Thanks,
Kleber
Stefan Bader May 14, 2019, 8:26 a.m. UTC | #7 
On 03.05.19 19:27, Jeremy Soller wrote:
> BugLink: https://bugs.launchpad.net/bugs/1827555
> 
> On the System76 Gazelle (gaze14), there is a headset microphone input attached
> to 0x1a that does not have a jack detect. In order to get it working, the pin
> configuration needs to be set correctly, and the
> ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC fixup needs to be applied. This is
> identical to the patch already applied for the System76 Darter Pro (darp5).
> 
> Signed-off-by: Jeremy Soller <jeremy@system76.com>
> 
> ---

This was invalidated by a later submission. Until a clear, correct submission is
made I am rejecting this.

-Stefan


> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index f5b510f119ed..4ea3affad617 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -6931,6 +6931,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
>         SND_PCI_QUIRK(0x1462, 0xb120, "MSI Cubi MS-B120", ALC283_FIXUP_HEADSET_MIC),
>         SND_PCI_QUIRK(0x1462, 0xb171, "Cubi N 8GL (MS-B171)", ALC283_FIXUP_HEADSET_MIC),
>         SND_PCI_QUIRK(0x1558, 0x1325, "System76 Darter Pro (darp5)", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
> +       SND_PCI_QUIRK(0x1558, 0x8550, "System76 Gazelle (gaze14)", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
>         SND_PCI_QUIRK(0x17aa, 0x1036, "Lenovo P520", ALC233_FIXUP_LENOVO_MULTI_CODECS),
>         SND_PCI_QUIRK(0x17aa, 0x20f2, "Thinkpad SL410/510", ALC269_FIXUP_SKU_IGNORE),
>         SND_PCI_QUIRK(0x17aa, 0x215e, "Thinkpad L512", ALC269_FIXUP_SKU_IGNORE),
>
Jeremy Soller May 15, 2019, 12:54 p.m. UTC | #8 
Thanks Stefan. Assuming the previous patches were not applied, here is the complete and correct patch that has now been applied upstream:

BugLink: https://bugs.launchpad.net/bugs/1827555

On the System76 Gazelle (gaze14) variants with a GTX 1660Ti, there is a headset
microphone input attached to 0x1a that does not have a jack detect. In order to
get it working, the pin configuration needs to be set correctly, and the
ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC fixup needs to be applied. This is
identical to the ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE fixup already applied
for the System76 Darter Pro (darp5).

On the System76 Gazelle (gaze14) variants with a GTX 1650, there is a headset
microphone input that is not parsed correctly. In order to get it working, the  
ALC269_FIXUP_HEADSET_MIC fixup needs to be applied.

Tests were done on all four variants ensuring full audio capability:
- 15 inch with GTX 1660 Ti (0x8550)
- 17 inch with GTX 1660 Ti (0x8551)
- 15 inch with GTX 1650 (0x8560)
- 17 inch with GTX 1650 (0x8561)

Signed-off-by: Jeremy Soller <jeremy@system76.com>

---
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 00c27b3b8c14..3e790b49c1c0 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -6900,6 +6900,10 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
        SND_PCI_QUIRK(0x1462, 0xb120, "MSI Cubi MS-B120", ALC283_FIXUP_HEADSET_MIC),
        SND_PCI_QUIRK(0x1462, 0xb171, "Cubi N 8GL (MS-B171)", ALC283_FIXUP_HEADSET_MIC),
        SND_PCI_QUIRK(0x1558, 0x1325, "System76 Darter Pro (darp5)", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
+       SND_PCI_QUIRK(0x1558, 0x8550, "System76 Gazelle (gaze14)", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
+       SND_PCI_QUIRK(0x1558, 0x8551, "System76 Gazelle (gaze14)", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
+       SND_PCI_QUIRK(0x1558, 0x8560, "System76 Gazelle (gaze14)", ALC269_FIXUP_HEADSET_MIC),
+       SND_PCI_QUIRK(0x1558, 0x8561, "System76 Gazelle (gaze14)", ALC269_FIXUP_HEADSET_MIC),
        SND_PCI_QUIRK(0x17aa, 0x1036, "Lenovo P520", ALC233_FIXUP_LENOVO_MULTI_CODECS),
        SND_PCI_QUIRK(0x17aa, 0x20f2, "Thinkpad SL410/510", ALC269_FIXUP_SKU_IGNORE),
        SND_PCI_QUIRK(0x17aa, 0x215e, "Thinkpad L512", ALC269_FIXUP_SKU_IGNORE),
Connor Kuehl May 28, 2019, 6:29 p.m. UTC | #9 
On 5/15/19 5:54 AM, Jeremy Soller wrote:
> Thanks Stefan. Assuming the previous patches were not applied, here is the complete and correct patch that has now been applied upstream:
> 
> BugLink: https://bugs.launchpad.net/bugs/1827555
> 
> On the System76 Gazelle (gaze14) variants with a GTX 1660Ti, there is a headset
> microphone input attached to 0x1a that does not have a jack detect. In order to
> get it working, the pin configuration needs to be set correctly, and the
> ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC fixup needs to be applied. This is
> identical to the ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE fixup already applied
> for the System76 Darter Pro (darp5).
> 
> On the System76 Gazelle (gaze14) variants with a GTX 1650, there is a headset
> microphone input that is not parsed correctly. In order to get it working, the  
> ALC269_FIXUP_HEADSET_MIC fixup needs to be applied.
> 
> Tests were done on all four variants ensuring full audio capability:
> - 15 inch with GTX 1660 Ti (0x8550)
> - 17 inch with GTX 1660 Ti (0x8551)
> - 15 inch with GTX 1650 (0x8560)
> - 17 inch with GTX 1650 (0x8561)
> 
> Signed-off-by: Jeremy Soller <jeremy@system76.com>
> 
> ---

Hi Jeremy,

If this patch has been submitted, accepted, and applied upstream then
it's important that we carry the provenance from upstream along with it
as well as the upstream commit SHA. There's an example on this page:
https://wiki.ubuntu.com/Kernel/Dev/StablePatchFormat specifically under
the "Comment Body" section with list items #3 and #4.

Also, just a gentle reminder that since it's been accepted upstream, the
e-mail/git subject should no longer contain "UBUNTU: SAUCE" :-)

Thanks,

Connor

> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 00c27b3b8c14..3e790b49c1c0 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -6900,6 +6900,10 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
>         SND_PCI_QUIRK(0x1462, 0xb120, "MSI Cubi MS-B120", ALC283_FIXUP_HEADSET_MIC),
>         SND_PCI_QUIRK(0x1462, 0xb171, "Cubi N 8GL (MS-B171)", ALC283_FIXUP_HEADSET_MIC),
>         SND_PCI_QUIRK(0x1558, 0x1325, "System76 Darter Pro (darp5)", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
> +       SND_PCI_QUIRK(0x1558, 0x8550, "System76 Gazelle (gaze14)", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
> +       SND_PCI_QUIRK(0x1558, 0x8551, "System76 Gazelle (gaze14)", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
> +       SND_PCI_QUIRK(0x1558, 0x8560, "System76 Gazelle (gaze14)", ALC269_FIXUP_HEADSET_MIC),
> +       SND_PCI_QUIRK(0x1558, 0x8561, "System76 Gazelle (gaze14)", ALC269_FIXUP_HEADSET_MIC),
>         SND_PCI_QUIRK(0x17aa, 0x1036, "Lenovo P520", ALC233_FIXUP_LENOVO_MULTI_CODECS),
>         SND_PCI_QUIRK(0x17aa, 0x20f2, "Thinkpad SL410/510", ALC269_FIXUP_SKU_IGNORE),
>         SND_PCI_QUIRK(0x17aa, 0x215e, "Thinkpad L512", ALC269_FIXUP_SKU_IGNORE),
>
Jeremy Soller June 5, 2019, 3:58 p.m. UTC | #10 
Hello Connor,

I tried to submit again, this time using the exact commits as follows:

80a5052db75131423b67f38b21958555d7d970e4
891afcf2462d2cc4ef7caf94215358ca61fa32cb

If there are any issues now, please let me know as soon as possible.
Connor Kuehl June 5, 2019, 6:02 p.m. UTC | #11 
On 6/5/19 8:58 AM, Jeremy Soller wrote:
> Hello Connor,
> 
> I tried to submit again, this time using the exact commits as follows:
> 
> 80a5052db75131423b67f38b21958555d7d970e4
> 891afcf2462d2cc4ef7caf94215358ca61fa32cb
> 
> If there are any issues now, please let me know as soon as possible.
> 

Hi Jeremy,

Thanks for resubmitting! There were just a couple of minor changes to be
made so that these patches fit the SRU "mold". No code changes, but just
git commit message content.

I've adjusted the following things from your patches:

- I moved your cherry pick line beneath the upstream provenance and then
put your S-o-b beneath it since you did the work on cherry picking the
patch.

- I added the BugLink as the first line after the git subject.

Aside from the SRU paperwork stuff above, the changes look good to me.
If you have any other questions, feel free to check here:
https://wiki.ubuntu.com/Kernel/Dev/StablePatchFormat or just ask us :-)

Thanks,
Jeremy Soller June 5, 2019, 7:37 p.m. UTC | #12 
Thanks Connor!
diff mbox series

Patch

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index f5b510f119ed..4ea3affad617 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -6931,6 +6931,7 @@  static const struct snd_pci_quirk alc269_fixup_tbl[] = {
        SND_PCI_QUIRK(0x1462, 0xb120, "MSI Cubi MS-B120", ALC283_FIXUP_HEADSET_MIC),
        SND_PCI_QUIRK(0x1462, 0xb171, "Cubi N 8GL (MS-B171)", ALC283_FIXUP_HEADSET_MIC),
        SND_PCI_QUIRK(0x1558, 0x1325, "System76 Darter Pro (darp5)", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
+       SND_PCI_QUIRK(0x1558, 0x8550, "System76 Gazelle (gaze14)", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
        SND_PCI_QUIRK(0x17aa, 0x1036, "Lenovo P520", ALC233_FIXUP_LENOVO_MULTI_CODECS),
        SND_PCI_QUIRK(0x17aa, 0x20f2, "Thinkpad SL410/510", ALC269_FIXUP_SKU_IGNORE),
        SND_PCI_QUIRK(0x17aa, 0x215e, "Thinkpad L512", ALC269_FIXUP_SKU_IGNORE),