| Message ID | 20190411170355.6882-17-mmaddireddy@nvidia.com |
|---|---|
| State | Superseded |
| Delegated to: | Lorenzo Pieralisi |
| Headers | show |
| Series | Enable Tegra PCIe root port features | expand |
On Thu, Apr 11, 2019 at 10:33:41PM +0530, Manikanta Maddireddy wrote: > AFI_CACHE* registers are available only in Tegra20, program them only > for Tegra20. > > Signed-off-by: Manikanta Maddireddy <mmaddireddy@nvidia.com> > --- > drivers/pci/controller/pci-tegra.c | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) > > diff --git a/drivers/pci/controller/pci-tegra.c b/drivers/pci/controller/pci-tegra.c > index 8e5fdc8ce3d6..cdaaf13a9fd7 100644 > --- a/drivers/pci/controller/pci-tegra.c > +++ b/drivers/pci/controller/pci-tegra.c > @@ -887,6 +887,7 @@ static irqreturn_t tegra_pcie_isr(int irq, void *arg) > */ > static void tegra_pcie_setup_translations(struct tegra_pcie *pcie) > { > + struct device_node *np = pcie->dev->of_node; > u32 fpci_bar, size, axi_address; > > /* Bar 0: type 1 extended configuration space */ > @@ -927,11 +928,13 @@ static void tegra_pcie_setup_translations(struct tegra_pcie *pcie) > afi_writel(pcie, 0, AFI_AXI_BAR5_SZ); > afi_writel(pcie, 0, AFI_FPCI_BAR5); > > - /* map all upstream transactions as uncached */ > - afi_writel(pcie, 0, AFI_CACHE_BAR0_ST); > - afi_writel(pcie, 0, AFI_CACHE_BAR0_SZ); > - afi_writel(pcie, 0, AFI_CACHE_BAR1_ST); > - afi_writel(pcie, 0, AFI_CACHE_BAR1_SZ); > + if (of_device_is_compatible(np, "nvidia,tegra20-pcie")) { At this point we've already matched on that compatible string, so we could probably get that information from the SoC structure. Why are these registers not available on later chips? How would we mark transactions as uncached on later generations of Tegra? Also, typically writing to non-existing registers on Tegra186 would cause an SError exception, but I haven't seen any of those with PCIe on Tegra186. So do these really not exist, or are they simply not used? Thierry > + /* map all upstream transactions as uncached */ > + afi_writel(pcie, 0, AFI_CACHE_BAR0_ST); > + afi_writel(pcie, 0, AFI_CACHE_BAR0_SZ); > + afi_writel(pcie, 0, AFI_CACHE_BAR1_ST); > + afi_writel(pcie, 0, AFI_CACHE_BAR1_SZ); > + } > > /* MSI translations are setup only when needed */ > afi_writel(pcie, 0, AFI_MSI_FPCI_BAR_ST); > -- > 2.17.1 >
On 15-Apr-19 6:50 PM, Thierry Reding wrote: > On Thu, Apr 11, 2019 at 10:33:41PM +0530, Manikanta Maddireddy wrote: >> AFI_CACHE* registers are available only in Tegra20, program them only >> for Tegra20. >> >> Signed-off-by: Manikanta Maddireddy <mmaddireddy@nvidia.com> >> --- >> drivers/pci/controller/pci-tegra.c | 13 ++++++++----- >> 1 file changed, 8 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/pci/controller/pci-tegra.c b/drivers/pci/controller/pci-tegra.c >> index 8e5fdc8ce3d6..cdaaf13a9fd7 100644 >> --- a/drivers/pci/controller/pci-tegra.c >> +++ b/drivers/pci/controller/pci-tegra.c >> @@ -887,6 +887,7 @@ static irqreturn_t tegra_pcie_isr(int irq, void *arg) >> */ >> static void tegra_pcie_setup_translations(struct tegra_pcie *pcie) >> { >> + struct device_node *np = pcie->dev->of_node; >> u32 fpci_bar, size, axi_address; >> >> /* Bar 0: type 1 extended configuration space */ >> @@ -927,11 +928,13 @@ static void tegra_pcie_setup_translations(struct tegra_pcie *pcie) >> afi_writel(pcie, 0, AFI_AXI_BAR5_SZ); >> afi_writel(pcie, 0, AFI_FPCI_BAR5); >> >> - /* map all upstream transactions as uncached */ >> - afi_writel(pcie, 0, AFI_CACHE_BAR0_ST); >> - afi_writel(pcie, 0, AFI_CACHE_BAR0_SZ); >> - afi_writel(pcie, 0, AFI_CACHE_BAR1_ST); >> - afi_writel(pcie, 0, AFI_CACHE_BAR1_SZ); >> + if (of_device_is_compatible(np, "nvidia,tegra20-pcie")) { > At this point we've already matched on that compatible string, so we > could probably get that information from the SoC structure. Why are > these registers not available on later chips? How would we mark > transactions as uncached on later generations of Tegra? > > Also, typically writing to non-existing registers on Tegra186 would > cause an SError exception, but I haven't seen any of those with PCIe > on Tegra186. So do these really not exist, or are they simply not used? > > Thierry Do you want me to add new soc flag for AFI_CACHE registers? As per the HW team feedback, upstream requests targeting DRAM would be marked as cacheable when the address of the request are within the regions defined by the cache_bar_sz/st registers. All upstream DRAM requests are marked as non-cacheable from T30 to T210 as the field is not used by MSS. In Tegra186 cacheable requests are supported by new register AFI_AXCACHE_0*. * These register definitions are not present in Tegra186 TRM, but register offsets are accessible, so these are not used. However Tegra186 simulations traps this register access because it is not defined in register spec. Manikanta >> + /* map all upstream transactions as uncached */ >> + afi_writel(pcie, 0, AFI_CACHE_BAR0_ST); >> + afi_writel(pcie, 0, AFI_CACHE_BAR0_SZ); >> + afi_writel(pcie, 0, AFI_CACHE_BAR1_ST); >> + afi_writel(pcie, 0, AFI_CACHE_BAR1_SZ); >> + } >> >> /* MSI translations are setup only when needed */ >> afi_writel(pcie, 0, AFI_MSI_FPCI_BAR_ST); >> -- >> 2.17.1 >>
On Tue, Apr 16, 2019 at 04:17:46PM +0530, Manikanta Maddireddy wrote: > > > On 15-Apr-19 6:50 PM, Thierry Reding wrote: > > On Thu, Apr 11, 2019 at 10:33:41PM +0530, Manikanta Maddireddy wrote: > >> AFI_CACHE* registers are available only in Tegra20, program them only > >> for Tegra20. > >> > >> Signed-off-by: Manikanta Maddireddy <mmaddireddy@nvidia.com> > >> --- > >> drivers/pci/controller/pci-tegra.c | 13 ++++++++----- > >> 1 file changed, 8 insertions(+), 5 deletions(-) > >> > >> diff --git a/drivers/pci/controller/pci-tegra.c b/drivers/pci/controller/pci-tegra.c > >> index 8e5fdc8ce3d6..cdaaf13a9fd7 100644 > >> --- a/drivers/pci/controller/pci-tegra.c > >> +++ b/drivers/pci/controller/pci-tegra.c > >> @@ -887,6 +887,7 @@ static irqreturn_t tegra_pcie_isr(int irq, void *arg) > >> */ > >> static void tegra_pcie_setup_translations(struct tegra_pcie *pcie) > >> { > >> + struct device_node *np = pcie->dev->of_node; > >> u32 fpci_bar, size, axi_address; > >> > >> /* Bar 0: type 1 extended configuration space */ > >> @@ -927,11 +928,13 @@ static void tegra_pcie_setup_translations(struct tegra_pcie *pcie) > >> afi_writel(pcie, 0, AFI_AXI_BAR5_SZ); > >> afi_writel(pcie, 0, AFI_FPCI_BAR5); > >> > >> - /* map all upstream transactions as uncached */ > >> - afi_writel(pcie, 0, AFI_CACHE_BAR0_ST); > >> - afi_writel(pcie, 0, AFI_CACHE_BAR0_SZ); > >> - afi_writel(pcie, 0, AFI_CACHE_BAR1_ST); > >> - afi_writel(pcie, 0, AFI_CACHE_BAR1_SZ); > >> + if (of_device_is_compatible(np, "nvidia,tegra20-pcie")) { > > At this point we've already matched on that compatible string, so we > > could probably get that information from the SoC structure. Why are > > these registers not available on later chips? How would we mark > > transactions as uncached on later generations of Tegra? > > > > Also, typically writing to non-existing registers on Tegra186 would > > cause an SError exception, but I haven't seen any of those with PCIe > > on Tegra186. So do these really not exist, or are they simply not used? > > > > Thierry > > Do you want me to add new soc flag for AFI_CACHE registers? > > As per the HW team feedback, upstream requests targeting DRAM would > be marked as cacheable when the address of the request are within the > regions defined by the cache_bar_sz/st registers. > All upstream DRAM requests are marked as non-cacheable from T30 to T210 > as the field is not used by MSS. In Tegra186 cacheable requests are > supported by new register AFI_AXCACHE_0*. * > These register definitions are not present in Tegra186 TRM, but > register offsets are accessible, so these are not used. > However Tegra186 simulations traps this register access because > it is not defined in register spec. Yes, I think something like .has_cache_bars or similar would be the best solution here. Thierry
diff --git a/drivers/pci/controller/pci-tegra.c b/drivers/pci/controller/pci-tegra.c index 8e5fdc8ce3d6..cdaaf13a9fd7 100644 --- a/drivers/pci/controller/pci-tegra.c +++ b/drivers/pci/controller/pci-tegra.c @@ -887,6 +887,7 @@ static irqreturn_t tegra_pcie_isr(int irq, void *arg) */ static void tegra_pcie_setup_translations(struct tegra_pcie *pcie) { + struct device_node *np = pcie->dev->of_node; u32 fpci_bar, size, axi_address; /* Bar 0: type 1 extended configuration space */ @@ -927,11 +928,13 @@ static void tegra_pcie_setup_translations(struct tegra_pcie *pcie) afi_writel(pcie, 0, AFI_AXI_BAR5_SZ); afi_writel(pcie, 0, AFI_FPCI_BAR5); - /* map all upstream transactions as uncached */ - afi_writel(pcie, 0, AFI_CACHE_BAR0_ST); - afi_writel(pcie, 0, AFI_CACHE_BAR0_SZ); - afi_writel(pcie, 0, AFI_CACHE_BAR1_ST); - afi_writel(pcie, 0, AFI_CACHE_BAR1_SZ); + if (of_device_is_compatible(np, "nvidia,tegra20-pcie")) { + /* map all upstream transactions as uncached */ + afi_writel(pcie, 0, AFI_CACHE_BAR0_ST); + afi_writel(pcie, 0, AFI_CACHE_BAR0_SZ); + afi_writel(pcie, 0, AFI_CACHE_BAR1_ST); + afi_writel(pcie, 0, AFI_CACHE_BAR1_SZ); + } /* MSI translations are setup only when needed */ afi_writel(pcie, 0, AFI_MSI_FPCI_BAR_ST);
AFI_CACHE* registers are available only in Tegra20, program them only for Tegra20. Signed-off-by: Manikanta Maddireddy <mmaddireddy@nvidia.com> --- drivers/pci/controller/pci-tegra.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-)