| Message ID | 1554095960-15638-1-git-send-email-Anson.Huang@nxp.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | pwm: imx27: use devm_platform_ioremap_resource() to simplify code | expand |
On Mon, Apr 01, 2019 at 05:24:02AM +0000, Anson Huang wrote: > Use the new helper devm_platform_ioremap_resource() which wraps the > platform_get_resource() and devm_ioremap_resource() together, to > simplify the code. > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Thanks Uwe
On 4/1/2019 10:54 AM, Anson Huang wrote: > Use the new helper devm_platform_ioremap_resource() which wraps the > platform_get_resource() and devm_ioremap_resource() together, to > simplify the code. > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> Reviewed-by: Mukesh Ojha <mojha@codeaurora.org> Cheers, -Mukesh > --- > drivers/pwm/pwm-imx27.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/pwm/pwm-imx27.c b/drivers/pwm/pwm-imx27.c > index 8061306..434a351 100644 > --- a/drivers/pwm/pwm-imx27.c > +++ b/drivers/pwm/pwm-imx27.c > @@ -291,7 +291,6 @@ MODULE_DEVICE_TABLE(of, pwm_imx27_dt_ids); > static int pwm_imx27_probe(struct platform_device *pdev) > { > struct pwm_imx27_chip *imx; > - struct resource *r; > > imx = devm_kzalloc(&pdev->dev, sizeof(*imx), GFP_KERNEL); > if (imx == NULL) > @@ -326,8 +325,7 @@ static int pwm_imx27_probe(struct platform_device *pdev) > imx->chip.of_xlate = of_pwm_xlate_with_flags; > imx->chip.of_pwm_n_cells = 3; > > - r = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - imx->mmio_base = devm_ioremap_resource(&pdev->dev, r); > + imx->mmio_base = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(imx->mmio_base)) > return PTR_ERR(imx->mmio_base); >
On 4/1/2019 10:54 AM, Anson Huang wrote: > Use the new helper devm_platform_ioremap_resource() which wraps the > platform_get_resource() and devm_ioremap_resource() together, to > simplify the code. > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> Reviewed-by: Mukesh Ojha <mojha@codeaurora.org> Cheers, -Mukesh > --- > drivers/pwm/pwm-imx27.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/pwm/pwm-imx27.c b/drivers/pwm/pwm-imx27.c > index 8061306..434a351 100644 > --- a/drivers/pwm/pwm-imx27.c > +++ b/drivers/pwm/pwm-imx27.c > @@ -291,7 +291,6 @@ MODULE_DEVICE_TABLE(of, pwm_imx27_dt_ids); > static int pwm_imx27_probe(struct platform_device *pdev) > { > struct pwm_imx27_chip *imx; > - struct resource *r; > > imx = devm_kzalloc(&pdev->dev, sizeof(*imx), GFP_KERNEL); > if (imx == NULL) > @@ -326,8 +325,7 @@ static int pwm_imx27_probe(struct platform_device *pdev) > imx->chip.of_xlate = of_pwm_xlate_with_flags; > imx->chip.of_pwm_n_cells = 3; > > - r = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - imx->mmio_base = devm_ioremap_resource(&pdev->dev, r); > + imx->mmio_base = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(imx->mmio_base)) > return PTR_ERR(imx->mmio_base); >
On 4/1/2019 10:54 AM, Anson Huang wrote: > Use the new helper devm_platform_ioremap_resource() which wraps the > platform_get_resource() and devm_ioremap_resource() together, to > simplify the code. > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> Reviewed-by: Mukesh Ojha <mojha@codeaurora.org> Cheers, -Mukesh > --- > drivers/pwm/pwm-imx27.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/pwm/pwm-imx27.c b/drivers/pwm/pwm-imx27.c > index 8061306..434a351 100644 > --- a/drivers/pwm/pwm-imx27.c > +++ b/drivers/pwm/pwm-imx27.c > @@ -291,7 +291,6 @@ MODULE_DEVICE_TABLE(of, pwm_imx27_dt_ids); > static int pwm_imx27_probe(struct platform_device *pdev) > { > struct pwm_imx27_chip *imx; > - struct resource *r; > > imx = devm_kzalloc(&pdev->dev, sizeof(*imx), GFP_KERNEL); > if (imx == NULL) > @@ -326,8 +325,7 @@ static int pwm_imx27_probe(struct platform_device *pdev) > imx->chip.of_xlate = of_pwm_xlate_with_flags; > imx->chip.of_pwm_n_cells = 3; > > - r = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - imx->mmio_base = devm_ioremap_resource(&pdev->dev, r); > + imx->mmio_base = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(imx->mmio_base)) > return PTR_ERR(imx->mmio_base); >
Ping... > -----Original Message----- > From: Mukesh Ojha [mailto:mojha@codeaurora.org] > Sent: Monday, April 1, 2019 4:01 PM > To: Anson Huang <anson.huang@nxp.com>; thierry.reding@gmail.com; > shawnguo@kernel.org; s.hauer@pengutronix.de; kernel@pengutronix.de; > festevam@gmail.com; linux-pwm@vger.kernel.org; linux-arm- > kernel@lists.infradead.org; linux-kernel@vger.kernel.org > Cc: dl-linux-imx <linux-imx@nxp.com> > Subject: Re: [PATCH] pwm: imx27: use devm_platform_ioremap_resource() > to simplify code > > > On 4/1/2019 10:54 AM, Anson Huang wrote: > > Use the new helper devm_platform_ioremap_resource() which wraps the > > platform_get_resource() and devm_ioremap_resource() together, to > > simplify the code. > > > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > > > Reviewed-by: Mukesh Ojha <mojha@codeaurora.org> > > Cheers, > -Mukesh > > > --- > > drivers/pwm/pwm-imx27.c | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/drivers/pwm/pwm-imx27.c b/drivers/pwm/pwm-imx27.c index > > 8061306..434a351 100644 > > --- a/drivers/pwm/pwm-imx27.c > > +++ b/drivers/pwm/pwm-imx27.c > > @@ -291,7 +291,6 @@ MODULE_DEVICE_TABLE(of, pwm_imx27_dt_ids); > > static int pwm_imx27_probe(struct platform_device *pdev) > > { > > struct pwm_imx27_chip *imx; > > - struct resource *r; > > > > imx = devm_kzalloc(&pdev->dev, sizeof(*imx), GFP_KERNEL); > > if (imx == NULL) > > @@ -326,8 +325,7 @@ static int pwm_imx27_probe(struct > platform_device *pdev) > > imx->chip.of_xlate = of_pwm_xlate_with_flags; > > imx->chip.of_pwm_n_cells = 3; > > > > - r = platform_get_resource(pdev, IORESOURCE_MEM, 0); > > - imx->mmio_base = devm_ioremap_resource(&pdev->dev, r); > > + imx->mmio_base = devm_platform_ioremap_resource(pdev, 0); > > if (IS_ERR(imx->mmio_base)) > > return PTR_ERR(imx->mmio_base); > >
On Mon, Apr 01, 2019 at 05:24:02AM +0000, Anson Huang wrote: > Use the new helper devm_platform_ioremap_resource() which wraps the > platform_get_resource() and devm_ioremap_resource() together, to > simplify the code. > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > --- > drivers/pwm/pwm-imx27.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) Applied, thanks. Thierry
diff --git a/drivers/pwm/pwm-imx27.c b/drivers/pwm/pwm-imx27.c index 8061306..434a351 100644 --- a/drivers/pwm/pwm-imx27.c +++ b/drivers/pwm/pwm-imx27.c @@ -291,7 +291,6 @@ MODULE_DEVICE_TABLE(of, pwm_imx27_dt_ids); static int pwm_imx27_probe(struct platform_device *pdev) { struct pwm_imx27_chip *imx; - struct resource *r; imx = devm_kzalloc(&pdev->dev, sizeof(*imx), GFP_KERNEL); if (imx == NULL) @@ -326,8 +325,7 @@ static int pwm_imx27_probe(struct platform_device *pdev) imx->chip.of_xlate = of_pwm_xlate_with_flags; imx->chip.of_pwm_n_cells = 3; - r = platform_get_resource(pdev, IORESOURCE_MEM, 0); - imx->mmio_base = devm_ioremap_resource(&pdev->dev, r); + imx->mmio_base = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(imx->mmio_base)) return PTR_ERR(imx->mmio_base);
Use the new helper devm_platform_ioremap_resource() which wraps the platform_get_resource() and devm_ioremap_resource() together, to simplify the code. Signed-off-by: Anson Huang <Anson.Huang@nxp.com> --- drivers/pwm/pwm-imx27.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)