| Message ID | 20190327232350.GA11373@xps13.dannf |
|---|---|
| State | New |
| Headers | show |
| Series | [PULL,Disco] SDEI support for ARM | expand |
On Wed, Mar 27, 2019 at 05:23:50PM -0600, dann frazier wrote: > BugLink: https://bugs.launchpad.net/bugs/1822005 > > All clean cherry-picks. Tested on a HiSilicon D06 system. > > The following changes since commit 367eb5b3c88e9dba6892be290a47af5da7ad21e6: > > SMB3: Fix SMB3.1.1 guest mounts to Samba (2019-03-26 09:54:23 -0500) > > are available in the Git repository at: > > git://git.launchpad.net/~dannf/ubuntu/+source/linux/+git/linux f90d8112f03c16b8c2467323a742249f6632f4cb > > for you to fetch changes up to f90d8112f03c16b8c2467323a742249f6632f4cb: > > ACPI / APEI: Add support for the SDEI GHES Notification type (2019-03-27 17:18:16 -0600) There's a lot of changes to generic code in your pull. You mention testing on HiSilicon D06, did you do regression testing on any other architectures?
On Thu, Mar 28, 2019 at 09:00:02AM -0500, Seth Forshee wrote: > On Wed, Mar 27, 2019 at 05:23:50PM -0600, dann frazier wrote: > > BugLink: https://bugs.launchpad.net/bugs/1822005 > > > > All clean cherry-picks. Tested on a HiSilicon D06 system. > > > > The following changes since commit 367eb5b3c88e9dba6892be290a47af5da7ad21e6: > > > > SMB3: Fix SMB3.1.1 guest mounts to Samba (2019-03-26 09:54:23 -0500) > > > > are available in the Git repository at: > > > > git://git.launchpad.net/~dannf/ubuntu/+source/linux/+git/linux f90d8112f03c16b8c2467323a742249f6632f4cb > > > > for you to fetch changes up to f90d8112f03c16b8c2467323a742249f6632f4cb: > > > > ACPI / APEI: Add support for the SDEI GHES Notification type (2019-03-27 17:18:16 -0600) > > There's a lot of changes to generic code in your pull. You mention > testing on HiSilicon D06, did you do regression testing on any other > architectures? I guess "other architectures" here only means x86, since that's the only other arch with ACPI enabled in our kernels.
On Thu, Mar 28, 2019 at 8:39 AM Seth Forshee <seth.forshee@canonical.com> wrote: > > On Thu, Mar 28, 2019 at 09:00:02AM -0500, Seth Forshee wrote: > > On Wed, Mar 27, 2019 at 05:23:50PM -0600, dann frazier wrote: > > > BugLink: https://bugs.launchpad.net/bugs/1822005 > > > > > > All clean cherry-picks. Tested on a HiSilicon D06 system. > > > > > > The following changes since commit 367eb5b3c88e9dba6892be290a47af5da7ad21e6: > > > > > > SMB3: Fix SMB3.1.1 guest mounts to Samba (2019-03-26 09:54:23 -0500) > > > > > > are available in the Git repository at: > > > > > > git://git.launchpad.net/~dannf/ubuntu/+source/linux/+git/linux f90d8112f03c16b8c2467323a742249f6632f4cb > > > > > > for you to fetch changes up to f90d8112f03c16b8c2467323a742249f6632f4cb: > > > > > > ACPI / APEI: Add support for the SDEI GHES Notification type (2019-03-27 17:18:16 -0600) > > > > There's a lot of changes to generic code in your pull. You mention > > testing on HiSilicon D06, did you do regression testing on any other > > architectures? > > I guess "other architectures" here only means x86, since that's the only > other arch with ACPI enabled in our kernels. Compile-testing only, but that's a fair point. I'll try to get access to an x86 system w/ APEI support and regression test there. -dann
On Thu, Mar 28, 2019 at 10:17 AM dann frazier <dann.frazier@canonical.com> wrote: > > On Thu, Mar 28, 2019 at 8:39 AM Seth Forshee <seth.forshee@canonical.com> wrote: > > > > On Thu, Mar 28, 2019 at 09:00:02AM -0500, Seth Forshee wrote: > > > On Wed, Mar 27, 2019 at 05:23:50PM -0600, dann frazier wrote: > > > > BugLink: https://bugs.launchpad.net/bugs/1822005 > > > > > > > > All clean cherry-picks. Tested on a HiSilicon D06 system. > > > > > > > > The following changes since commit 367eb5b3c88e9dba6892be290a47af5da7ad21e6: > > > > > > > > SMB3: Fix SMB3.1.1 guest mounts to Samba (2019-03-26 09:54:23 -0500) > > > > > > > > are available in the Git repository at: > > > > > > > > git://git.launchpad.net/~dannf/ubuntu/+source/linux/+git/linux f90d8112f03c16b8c2467323a742249f6632f4cb > > > > > > > > for you to fetch changes up to f90d8112f03c16b8c2467323a742249f6632f4cb: > > > > > > > > ACPI / APEI: Add support for the SDEI GHES Notification type (2019-03-27 17:18:16 -0600) > > > > > > There's a lot of changes to generic code in your pull. You mention > > > testing on HiSilicon D06, did you do regression testing on any other > > > architectures? > > > > I guess "other architectures" here only means x86, since that's the only > > other arch with ACPI enabled in our kernels. > > Compile-testing only, but that's a fair point. I'll try to get access > to an x86 system w/ APEI support and regression test there. Now tested on x86 as well (Nvidia DGX system). I wasn't able to get it to MCE w/ ACPI EINJ correctable memory errors (either before or after my patches) - looks like an older APEI implementation. But I was able to crash it w/ an uncorrectable one in both cases. -dann
On Thu, Mar 28, 2019 at 12:44:15PM -0600, dann frazier wrote: > On Thu, Mar 28, 2019 at 10:17 AM dann frazier > <dann.frazier@canonical.com> wrote: > > > > On Thu, Mar 28, 2019 at 8:39 AM Seth Forshee <seth.forshee@canonical.com> wrote: > > > > > > On Thu, Mar 28, 2019 at 09:00:02AM -0500, Seth Forshee wrote: > > > > On Wed, Mar 27, 2019 at 05:23:50PM -0600, dann frazier wrote: > > > > > BugLink: https://bugs.launchpad.net/bugs/1822005 > > > > > > > > > > All clean cherry-picks. Tested on a HiSilicon D06 system. > > > > > > > > > > The following changes since commit 367eb5b3c88e9dba6892be290a47af5da7ad21e6: > > > > > > > > > > SMB3: Fix SMB3.1.1 guest mounts to Samba (2019-03-26 09:54:23 -0500) > > > > > > > > > > are available in the Git repository at: > > > > > > > > > > git://git.launchpad.net/~dannf/ubuntu/+source/linux/+git/linux f90d8112f03c16b8c2467323a742249f6632f4cb > > > > > > > > > > for you to fetch changes up to f90d8112f03c16b8c2467323a742249f6632f4cb: > > > > > > > > > > ACPI / APEI: Add support for the SDEI GHES Notification type (2019-03-27 17:18:16 -0600) > > > > > > > > There's a lot of changes to generic code in your pull. You mention > > > > testing on HiSilicon D06, did you do regression testing on any other > > > > architectures? > > > > > > I guess "other architectures" here only means x86, since that's the only > > > other arch with ACPI enabled in our kernels. > > > > Compile-testing only, but that's a fair point. I'll try to get access > > to an x86 system w/ APEI support and regression test there. > > Now tested on x86 as well (Nvidia DGX system). I wasn't able to get it > to MCE w/ ACPI EINJ correctable memory errors (either before or after > my patches) - looks like an older APEI implementation. But I was able > to crash it w/ an uncorrectable one in both cases. Thanks for testing. Applied to disco/master-next, thanks!
BugLink: https://bugs.launchpad.net/bugs/1822005 All clean cherry-picks. Tested on a HiSilicon D06 system. The following changes since commit 367eb5b3c88e9dba6892be290a47af5da7ad21e6: SMB3: Fix SMB3.1.1 guest mounts to Samba (2019-03-26 09:54:23 -0500) are available in the Git repository at: git://git.launchpad.net/~dannf/ubuntu/+source/linux/+git/linux f90d8112f03c16b8c2467323a742249f6632f4cb for you to fetch changes up to f90d8112f03c16b8c2467323a742249f6632f4cb: ACPI / APEI: Add support for the SDEI GHES Notification type (2019-03-27 17:18:16 -0600) ---------------------------------------------------------------- James Morse (23): ACPI / APEI: Don't wait to serialise with oops messages when panic()ing ACPI / APEI: Remove silent flag from ghes_read_estatus() ACPI / APEI: Switch estatus pool to use vmalloc memory ACPI / APEI: Make hest.c manage the estatus memory pool ACPI / APEI: Make estatus pool allocation a static size ACPI / APEI: Don't store CPER records physical address in struct ghes ACPI / APEI: Remove spurious GHES_TO_CLEAR check ACPI / APEI: Don't update struct ghes' flags in read/clear estatus ACPI / APEI: Generalise the estatus queue's notify code ACPI / APEI: Don't allow ghes_ack_error() to mask earlier errors ACPI / APEI: Move NOTIFY_SEA between the estatus-queue and NOTIFY_NMI ACPI / APEI: Switch NOTIFY_SEA to use the estatus queue KVM: arm/arm64: Add kvm_ras.h to collect kvm specific RAS plumbing arm64: KVM/mm: Move SEA handling behind a single 'claim' interface ACPI / APEI: Move locking to the notification helper ACPI / APEI: Let the notification helper specify the fixmap slot ACPI / APEI: Pass ghes and estatus separately to avoid a later copy ACPI / APEI: Make GHES estatus header validation more user friendly ACPI / APEI: Split ghes_read_estatus() to allow a peek at the CPER length ACPI / APEI: Only use queued estatus entry during in_nmi_queue_one_entry() ACPI / APEI: Use separate fixmap pages for arm64 NMI-like notifications firmware: arm_sdei: Add ACPI GHES registration helper ACPI / APEI: Add support for the SDEI GHES Notification type arch/arm/include/asm/kvm_ras.h | 14 + arch/arm/include/asm/system_misc.h | 5 - arch/arm64/include/asm/acpi.h | 4 +- arch/arm64/include/asm/daifflags.h | 1 + arch/arm64/include/asm/fixmap.h | 6 +- arch/arm64/include/asm/kvm_ras.h | 25 ++ arch/arm64/include/asm/system_misc.h | 2 - arch/arm64/kernel/acpi.c | 31 ++ arch/arm64/mm/fault.c | 24 +- drivers/acpi/apei/Kconfig | 12 +- drivers/acpi/apei/ghes.c | 655 ++++++++++++++++++++--------------- drivers/acpi/apei/hest.c | 10 +- drivers/firmware/arm_sdei.c | 68 ++++ include/acpi/ghes.h | 4 +- include/linux/arm_sdei.h | 9 + virt/kvm/arm/mmu.c | 4 +- 16 files changed, 546 insertions(+), 328 deletions(-) create mode 100644 arch/arm/include/asm/kvm_ras.h create mode 100644 arch/arm64/include/asm/kvm_ras.h