| Message ID | 20190326123853.20026-2-simon.k.r.goldschmidt@gmail.com |
|---|---|
| State | Superseded, archived |
| Delegated to: | Marek Vasut |
| Headers | show |
| Series | [U-Boot,v2,1/2] eeprom: fix DM_I2C support without CONFIG_SYS_I2C_EEPROM_BUS | expand |
On Tue, 26 Mar 2019 at 06:39, Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com> wrote: > > This reverts commit 65a97e7fcf54feb7c4ebe1aee8a572830af4cf51. > > The 'eeprom' command has been converted to work with DM_I2C in a patch > submitted around the same time as this commit: > commit 0c07a9b4078d ("eeprom: Add device model based I2C support to eeprom command") > > Signed-off-by: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com> > --- > > Changes in v2: > - added patch to fix DM_I2C eeprom code to work without > CONFIG_SYS_I2C_EEPROM_BUS > > cmd/Kconfig | 1 - > 1 file changed, 1 deletion(-) Reviewed-by: Simon Glass <sjg@chromium.org>
Am 30.03.2019 um 22:18 schrieb Simon Glass: > On Tue, 26 Mar 2019 at 06:39, Simon Goldschmidt > <simon.k.r.goldschmidt@gmail.com> wrote: >> >> This reverts commit 65a97e7fcf54feb7c4ebe1aee8a572830af4cf51. >> >> The 'eeprom' command has been converted to work with DM_I2C in a patch >> submitted around the same time as this commit: >> commit 0c07a9b4078d ("eeprom: Add device model based I2C support to eeprom command") >> >> Signed-off-by: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com> >> --- >> >> Changes in v2: >> - added patch to fix DM_I2C eeprom code to work without >> CONFIG_SYS_I2C_EEPROM_BUS >> >> cmd/Kconfig | 1 - >> 1 file changed, 1 deletion(-) > > Reviewed-by: Simon Glass <sjg@chromium.org> > Who will take this series? It's assigned in to Marek in patchwork, but might go via Heiko's i2c tree? Or directly via Tom? I have sent patches (move socfpga_vining to DM_I2C) that are based on this series... Thanks, Simon
On 4/9/19 8:53 PM, Simon Goldschmidt wrote: > Am 30.03.2019 um 22:18 schrieb Simon Glass: >> On Tue, 26 Mar 2019 at 06:39, Simon Goldschmidt >> <simon.k.r.goldschmidt@gmail.com> wrote: >>> >>> This reverts commit 65a97e7fcf54feb7c4ebe1aee8a572830af4cf51. >>> >>> The 'eeprom' command has been converted to work with DM_I2C in a patch >>> submitted around the same time as this commit: >>> commit 0c07a9b4078d ("eeprom: Add device model based I2C support to >>> eeprom command") >>> >>> Signed-off-by: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com> >>> --- >>> >>> Changes in v2: >>> - added patch to fix DM_I2C eeprom code to work without >>> CONFIG_SYS_I2C_EEPROM_BUS >>> >>> cmd/Kconfig | 1 - >>> 1 file changed, 1 deletion(-) >> >> Reviewed-by: Simon Glass <sjg@chromium.org> >> > > > Who will take this series? It's assigned in to Marek in patchwork, but > might go via Heiko's i2c tree? Or directly via Tom? > > I have sent patches (move socfpga_vining to DM_I2C) that are based on > this series... Heiko should at least AB/RB it , then I can take it via socfpga tree to avoid dependency problems.
Hello Simon, Am 26.03.2019 um 13:38 schrieb Simon Goldschmidt: > This reverts commit 65a97e7fcf54feb7c4ebe1aee8a572830af4cf51. > > The 'eeprom' command has been converted to work with DM_I2C in a patch > submitted around the same time as this commit: > commit 0c07a9b4078d ("eeprom: Add device model based I2C support to eeprom command") > > Signed-off-by: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com> > --- > > Changes in v2: > - added patch to fix DM_I2C eeprom code to work without > CONFIG_SYS_I2C_EEPROM_BUS Reviewed-by: Heiko Schocher <hs@denx.de> bye, Heiko
Hello Marek, Simon, Am 09.04.2019 um 21:30 schrieb Marek Vasut: > On 4/9/19 8:53 PM, Simon Goldschmidt wrote: >> Am 30.03.2019 um 22:18 schrieb Simon Glass: >>> On Tue, 26 Mar 2019 at 06:39, Simon Goldschmidt >>> <simon.k.r.goldschmidt@gmail.com> wrote: >>>> >>>> This reverts commit 65a97e7fcf54feb7c4ebe1aee8a572830af4cf51. >>>> >>>> The 'eeprom' command has been converted to work with DM_I2C in a patch >>>> submitted around the same time as this commit: >>>> commit 0c07a9b4078d ("eeprom: Add device model based I2C support to >>>> eeprom command") >>>> >>>> Signed-off-by: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com> >>>> --- >>>> >>>> Changes in v2: >>>> - added patch to fix DM_I2C eeprom code to work without >>>> CONFIG_SYS_I2C_EEPROM_BUS >>>> >>>> cmd/Kconfig | 1 - >>>> 1 file changed, 1 deletion(-) >>> >>> Reviewed-by: Simon Glass <sjg@chromium.org> >>> >> >> >> Who will take this series? It's assigned in to Marek in patchwork, but >> might go via Heiko's i2c tree? Or directly via Tom? >> >> I have sent patches (move socfpga_vining to DM_I2C) that are based on >> this series... > > Heiko should at least AB/RB it , then I can take it via socfpga tree to > avoid dependency problems. Just add to this patches my RB tag, so please pick it up, to prevent dependency problems, thanks! bye, Heiko
Hello Heiko, On Wed, Apr 10, 2019 at 7:20 AM Heiko Schocher <hs@denx.de> wrote: > > Hello Marek, Simon, > > Am 09.04.2019 um 21:30 schrieb Marek Vasut: > > On 4/9/19 8:53 PM, Simon Goldschmidt wrote: > >> Am 30.03.2019 um 22:18 schrieb Simon Glass: > >>> On Tue, 26 Mar 2019 at 06:39, Simon Goldschmidt > >>> <simon.k.r.goldschmidt@gmail.com> wrote: > >>>> > >>>> This reverts commit 65a97e7fcf54feb7c4ebe1aee8a572830af4cf51. > >>>> > >>>> The 'eeprom' command has been converted to work with DM_I2C in a patch > >>>> submitted around the same time as this commit: > >>>> commit 0c07a9b4078d ("eeprom: Add device model based I2C support to > >>>> eeprom command") > >>>> > >>>> Signed-off-by: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com> > >>>> --- > >>>> > >>>> Changes in v2: > >>>> - added patch to fix DM_I2C eeprom code to work without > >>>> CONFIG_SYS_I2C_EEPROM_BUS > >>>> > >>>> cmd/Kconfig | 1 - > >>>> 1 file changed, 1 deletion(-) > >>> > >>> Reviewed-by: Simon Glass <sjg@chromium.org> > >>> > >> > >> > >> Who will take this series? It's assigned in to Marek in patchwork, but > >> might go via Heiko's i2c tree? Or directly via Tom? > >> > >> I have sent patches (move socfpga_vining to DM_I2C) that are based on > >> this series... > > > > Heiko should at least AB/RB it , then I can take it via socfpga tree to > > avoid dependency problems. > > Just add to this patches my RB tag, so please pick it up, to prevent > dependency problems, thanks! OK, I'll do that. Thanks, Simon
On 4/10/19 7:20 AM, Heiko Schocher wrote: > Hello Marek, Simon, > > Am 09.04.2019 um 21:30 schrieb Marek Vasut: >> On 4/9/19 8:53 PM, Simon Goldschmidt wrote: >>> Am 30.03.2019 um 22:18 schrieb Simon Glass: >>>> On Tue, 26 Mar 2019 at 06:39, Simon Goldschmidt >>>> <simon.k.r.goldschmidt@gmail.com> wrote: >>>>> >>>>> This reverts commit 65a97e7fcf54feb7c4ebe1aee8a572830af4cf51. >>>>> >>>>> The 'eeprom' command has been converted to work with DM_I2C in a patch >>>>> submitted around the same time as this commit: >>>>> commit 0c07a9b4078d ("eeprom: Add device model based I2C support to >>>>> eeprom command") >>>>> >>>>> Signed-off-by: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com> >>>>> --- >>>>> >>>>> Changes in v2: >>>>> - added patch to fix DM_I2C eeprom code to work without >>>>> CONFIG_SYS_I2C_EEPROM_BUS >>>>> >>>>> cmd/Kconfig | 1 - >>>>> 1 file changed, 1 deletion(-) >>>> >>>> Reviewed-by: Simon Glass <sjg@chromium.org> >>>> >>> >>> >>> Who will take this series? It's assigned in to Marek in patchwork, but >>> might go via Heiko's i2c tree? Or directly via Tom? >>> >>> I have sent patches (move socfpga_vining to DM_I2C) that are based on >>> this series... >> >> Heiko should at least AB/RB it , then I can take it via socfpga tree to >> avoid dependency problems. > > Just add to this patches my RB tag, so please pick it up, to prevent > dependency problems, thanks! Then put the RB tag here , so that PW can pick it :)
Hello Marek, Am 10.04.2019 um 10:05 schrieb Marek Vasut: > On 4/10/19 7:20 AM, Heiko Schocher wrote: >> Hello Marek, Simon, >> >> Am 09.04.2019 um 21:30 schrieb Marek Vasut: >>> On 4/9/19 8:53 PM, Simon Goldschmidt wrote: >>>> Am 30.03.2019 um 22:18 schrieb Simon Glass: >>>>> On Tue, 26 Mar 2019 at 06:39, Simon Goldschmidt >>>>> <simon.k.r.goldschmidt@gmail.com> wrote: >>>>>> >>>>>> This reverts commit 65a97e7fcf54feb7c4ebe1aee8a572830af4cf51. >>>>>> >>>>>> The 'eeprom' command has been converted to work with DM_I2C in a patch >>>>>> submitted around the same time as this commit: >>>>>> commit 0c07a9b4078d ("eeprom: Add device model based I2C support to >>>>>> eeprom command") >>>>>> >>>>>> Signed-off-by: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com> >>>>>> --- >>>>>> >>>>>> Changes in v2: >>>>>> - added patch to fix DM_I2C eeprom code to work without >>>>>> CONFIG_SYS_I2C_EEPROM_BUS >>>>>> >>>>>> cmd/Kconfig | 1 - >>>>>> 1 file changed, 1 deletion(-) >>>>> >>>>> Reviewed-by: Simon Glass <sjg@chromium.org> >>>>> >>>> >>>> >>>> Who will take this series? It's assigned in to Marek in patchwork, but >>>> might go via Heiko's i2c tree? Or directly via Tom? >>>> >>>> I have sent patches (move socfpga_vining to DM_I2C) that are based on >>>> this series... >>> >>> Heiko should at least AB/RB it , then I can take it via socfpga tree to >>> avoid dependency problems. >> >> Just add to this patches my RB tag, so please pick it up, to prevent >> dependency problems, thanks! > > Then put the RB tag here , so that PW can pick it :) already done, see: http://patchwork.ozlabs.org/patch/1065524/#2149315 bye, Heiko
On 4/10/19 10:19 AM, Heiko Schocher wrote: > Hello Marek, > > Am 10.04.2019 um 10:05 schrieb Marek Vasut: >> On 4/10/19 7:20 AM, Heiko Schocher wrote: >>> Hello Marek, Simon, >>> >>> Am 09.04.2019 um 21:30 schrieb Marek Vasut: >>>> On 4/9/19 8:53 PM, Simon Goldschmidt wrote: >>>>> Am 30.03.2019 um 22:18 schrieb Simon Glass: >>>>>> On Tue, 26 Mar 2019 at 06:39, Simon Goldschmidt >>>>>> <simon.k.r.goldschmidt@gmail.com> wrote: >>>>>>> >>>>>>> This reverts commit 65a97e7fcf54feb7c4ebe1aee8a572830af4cf51. >>>>>>> >>>>>>> The 'eeprom' command has been converted to work with DM_I2C in a >>>>>>> patch >>>>>>> submitted around the same time as this commit: >>>>>>> commit 0c07a9b4078d ("eeprom: Add device model based I2C support to >>>>>>> eeprom command") >>>>>>> >>>>>>> Signed-off-by: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com> >>>>>>> --- >>>>>>> >>>>>>> Changes in v2: >>>>>>> - added patch to fix DM_I2C eeprom code to work without >>>>>>> CONFIG_SYS_I2C_EEPROM_BUS >>>>>>> >>>>>>> cmd/Kconfig | 1 - >>>>>>> 1 file changed, 1 deletion(-) >>>>>> >>>>>> Reviewed-by: Simon Glass <sjg@chromium.org> >>>>>> >>>>> >>>>> >>>>> Who will take this series? It's assigned in to Marek in patchwork, but >>>>> might go via Heiko's i2c tree? Or directly via Tom? >>>>> >>>>> I have sent patches (move socfpga_vining to DM_I2C) that are based on >>>>> this series... >>>> >>>> Heiko should at least AB/RB it , then I can take it via socfpga tree to >>>> avoid dependency problems. >>> >>> Just add to this patches my RB tag, so please pick it up, to prevent >>> dependency problems, thanks! >> >> Then put the RB tag here , so that PW can pick it :) > > already done, see: > > http://patchwork.ozlabs.org/patch/1065524/#2149315 Thanks!
diff --git a/cmd/Kconfig b/cmd/Kconfig index 4bcc5c4557..74c5a1a6ed 100644 --- a/cmd/Kconfig +++ b/cmd/Kconfig @@ -455,7 +455,6 @@ config CRC32_VERIFY config CMD_EEPROM bool "eeprom - EEPROM subsystem" - depends on !DM_I2C || DM_I2C_COMPAT help (deprecated, needs conversion to driver model) Provides commands to read and write EEPROM (Electrically Erasable
This reverts commit 65a97e7fcf54feb7c4ebe1aee8a572830af4cf51. The 'eeprom' command has been converted to work with DM_I2C in a patch submitted around the same time as this commit: commit 0c07a9b4078d ("eeprom: Add device model based I2C support to eeprom command") Signed-off-by: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com> --- Changes in v2: - added patch to fix DM_I2C eeprom code to work without CONFIG_SYS_I2C_EEPROM_BUS cmd/Kconfig | 1 - 1 file changed, 1 deletion(-)