diff mbox series

[02/15] core/test/run-trace: Fix type in testing struct

Message ID 20190325001425.29483-3-jniethe5@gmail.com
State Superseded
Headers show
Series Improve usability of skiboot traces | expand

Checks

Context Check Description
snowpatch_ozlabs/apply_patch success Successfully applied on branch master (b392d785eb49630b9f00fef8d17944ed82b2c1fe)
snowpatch_ozlabs/snowpatch_job_snowpatch-skiboot success Test snowpatch/job/snowpatch-skiboot on branch master
snowpatch_ozlabs/snowpatch_job_snowpatch-skiboot-dco fail Signed-off-by missing

Commit Message

Jordan Niethe March 25, 2019, 12:14 a.m. UTC
A mock cpu thread structure is used for testing the skiboot trace
buffers. This contains the parts of the actual structure that are needed
for the tests. Within the mock structure the type used for servo_no is
different from the real structure. Change the type so it is consistent.
---
 core/test/run-trace.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Oliver O'Halloran March 25, 2019, 12:37 a.m. UTC | #1
On Mon, Mar 25, 2019 at 11:16 AM Jordan Niethe <jniethe5@gmail.com> wrote:
>
> A mock cpu thread structure is used for testing the skiboot trace
> buffers. This contains the parts of the actual structure that are needed
> for the tests. Within the mock structure the type used for servo_no is
> different from the real structure. Change the type so it is consistent.

Reviewed-by: Oliver O'Halloran <oohall@gmail.com>

> ---
>  core/test/run-trace.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/core/test/run-trace.c b/core/test/run-trace.c
> index dd4cd450002c..ef7ebfe12655 100644
> --- a/core/test/run-trace.c
> +++ b/core/test/run-trace.c
> @@ -55,7 +55,7 @@ struct cpu_thread {
>         uint32_t pir;
>         uint32_t chip_id;
>         struct trace_info *trace;
> -       int server_no;
> +       uint32_t server_no;
>         bool is_secondary;
>         struct cpu_thread *primary;
>  };
> --
> 2.20.1
>
> _______________________________________________
> Skiboot mailing list
> Skiboot@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/skiboot
diff mbox series

Patch

diff --git a/core/test/run-trace.c b/core/test/run-trace.c
index dd4cd450002c..ef7ebfe12655 100644
--- a/core/test/run-trace.c
+++ b/core/test/run-trace.c
@@ -55,7 +55,7 @@  struct cpu_thread {
 	uint32_t pir;
 	uint32_t chip_id;
 	struct trace_info *trace;
-	int server_no;
+	uint32_t server_no;
 	bool is_secondary;
 	struct cpu_thread *primary;
 };