diff mbox series

[11/15] external/trace: Use correct width integer byte swapping

Message ID 20190325001425.29483-12-jniethe5@gmail.com
State Superseded
Headers show
Series Improve usability of skiboot traces | expand

Checks

Context Check Description
snowpatch_ozlabs/apply_patch success Successfully applied on branch master (b392d785eb49630b9f00fef8d17944ed82b2c1fe)
snowpatch_ozlabs/snowpatch_job_snowpatch-skiboot success Test snowpatch/job/snowpatch-skiboot on branch master
snowpatch_ozlabs/snowpatch_job_snowpatch-skiboot-dco fail Signed-off-by missing

Commit Message

Jordan Niethe March 25, 2019, 12:14 a.m. UTC 
The trace_repeat struct uses be16 for storing the number of repeats.
Currently be32_to_cpu conversion is used to display this member. This
produces an incorrect value. Use be16_to_cpu instead.
---
 external/trace/dump_trace.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Oliver O'Halloran March 25, 2019, 1:41 a.m. UTC | #1 
On Mon, Mar 25, 2019 at 11:18 AM Jordan Niethe <jniethe5@gmail.com> wrote:
>
> The trace_repeat struct uses be16 for storing the number of repeats.
> Currently be32_to_cpu conversion is used to display this member. This
> produces an incorrect value. Use be16_to_cpu instead.
> ---
>  external/trace/dump_trace.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/external/trace/dump_trace.c b/external/trace/dump_trace.c
> index db53d785be57..4779dc42ec6d 100644
> --- a/external/trace/dump_trace.c
> +++ b/external/trace/dump_trace.c
> @@ -170,7 +170,7 @@ int main(int argc, char *argv[])
>                 switch (t.hdr.type) {
>                 case TRACE_REPEAT:
>                         printf("REPEATS: %u times\n",
> -                              be32_to_cpu(t.repeat.num));
> +                              be16_to_cpu(t.repeat.num));
>                         break;
>                 case TRACE_OVERFLOW:
>                         printf("**OVERFLOW**: %"PRIu64" bytes missed\n",
> --
> 2.20.1

Reviewed-by: Oliver O'Halloran <oohall@gmail.com>

>
> _______________________________________________
> Skiboot mailing list
> Skiboot@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/skiboot
diff mbox series

Patch

diff --git a/external/trace/dump_trace.c b/external/trace/dump_trace.c
index db53d785be57..4779dc42ec6d 100644
--- a/external/trace/dump_trace.c
+++ b/external/trace/dump_trace.c
@@ -170,7 +170,7 @@  int main(int argc, char *argv[])
 		switch (t.hdr.type) {
 		case TRACE_REPEAT:
 			printf("REPEATS: %u times\n",
-			       be32_to_cpu(t.repeat.num));
+			       be16_to_cpu(t.repeat.num));
 			break;
 		case TRACE_OVERFLOW:
 			printf("**OVERFLOW**: %"PRIu64" bytes missed\n",