diff mbox series

[U-Boot,09/17] mx6sabresd: convert to DM_VIDEO

Message ID 20190318222947.7148-10-agust@denx.de
State Accepted
Commit f3592ceac9810b34801772b6d335d8f7cff4c287
Delegated to: Stefano Babic
Headers show
Series Convert some imx6 boards to DM_VIDEO | expand

Commit Message

Anatolij Gustschin March 18, 2019, 10:29 p.m. UTC
Enable DM_VIDEO in defconfig.

Signed-off-by: Anatolij Gustschin <agust@denx.de>
---
 configs/mx6sabresd_defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Fabio Estevam Sept. 16, 2019, 6:18 p.m. UTC | #1
Hi Anatolij,

On Mon, Mar 18, 2019 at 7:36 PM Anatolij Gustschin <agust@denx.de> wrote:
>
> Enable DM_VIDEO in defconfig.
>
> Signed-off-by: Anatolij Gustschin <agust@denx.de>
> ---
>  configs/mx6sabresd_defconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configs/mx6sabresd_defconfig b/configs/mx6sabresd_defconfig
> index ea34217e1c..825218c0d6 100644
> --- a/configs/mx6sabresd_defconfig
> +++ b/configs/mx6sabresd_defconfig
> @@ -93,6 +93,6 @@ CONFIG_USB_GADGET_PRODUCT_NUM=0xa4a5
>  CONFIG_CI_UDC=y
>  CONFIG_USB_HOST_ETHER=y
>  CONFIG_USB_ETHER_ASIX=y
> -CONFIG_VIDEO=y
> +CONFIG_DM_VIDEO=y

I am running the latest tree from Stefano and I do not have LVDS
output after this patch.

If I revert it, then LVDS output is normal again.

Any ideas?

Thanks
Anatolij Gustschin Sept. 16, 2019, 7:21 p.m. UTC | #2
Hi Fabio,

On Mon, 16 Sep 2019 15:18:34 -0300
Fabio Estevam festevam@gmail.com wrote:
...
> > -CONFIG_VIDEO=y
> > +CONFIG_DM_VIDEO=y  
> 
> I am running the latest tree from Stefano and I do not have LVDS
> output after this patch.
> 
> If I revert it, then LVDS output is normal again.
> 
> Any ideas?

Most probably this is because there was no user of the video
device when booting and therefore the video driver was not
probed/bound. Please try do display some bitmap with bmp
command or try to switch to the video console by command
"setenv stdout vidconsole0". Then, the video device will be
probed and you should see the LVDS output.

--
Anatolij
Anatolij Gustschin Sept. 16, 2019, 7:50 p.m. UTC | #3
Hi Fabio,

On Mon, 16 Sep 2019 21:21:38 +0200
Anatolij Gustschin agust@denx.de wrote:

>Hi Fabio,
>
>On Mon, 16 Sep 2019 15:18:34 -0300
>Fabio Estevam festevam@gmail.com wrote:
>...
>> > -CONFIG_VIDEO=y
>> > +CONFIG_DM_VIDEO=y    
>> 
>> I am running the latest tree from Stefano and I do not have LVDS
>> output after this patch.
>> 
>> If I revert it, then LVDS output is normal again.
>> 
>> Any ideas?  
>
>Most probably this is because there was no user of the video
>device when booting and therefore the video driver was not
>probed/bound. Please try do display some bitmap with bmp
>command or try to switch to the video console by command
>"setenv stdout vidconsole0". Then, the video device will be
>probed and you should see the LVDS output.

There is an example how boards can enforce using video device
when booting, e.g. for displaying splash image. Please see commit
f0be8ff45fb8 (ARM: imx: m53menlo: Convert to DM VIDEO).

I'm not happy that it requires to extend the board code for this
and would prefer if it could be in common code. But this is what
we have now.

--
Anatolij
Fabio Estevam Sept. 17, 2019, 12:32 p.m. UTC | #4
Hi Anatolij,

On Mon, Sep 16, 2019 at 4:21 PM Anatolij Gustschin <agust@denx.de> wrote:

> Most probably this is because there was no user of the video
> device when booting and therefore the video driver was not
> probed/bound. Please try do display some bitmap with bmp
> command or try to switch to the video console by command
> "setenv stdout vidconsole0". Then, the video device will be
> probed and you should see the LVDS output.

Here is what I tried:

=> setenv stdout vidconsole0
## Error inserting "stdout" variable, errno=22

Then I see garbage on the LVDS panel.

Any ideas as to why setting "stdout" failed?

Thanks
Anatolij Gustschin Sept. 17, 2019, 9:42 p.m. UTC | #5
Hi Fabio,

On Tue, 17 Sep 2019 09:32:37 -0300
Fabio Estevam festevam@gmail.com wrote:

> Hi Anatolij,
> 
> On Mon, Sep 16, 2019 at 4:21 PM Anatolij Gustschin <agust@denx.de> wrote:
> 
> > Most probably this is because there was no user of the video
> > device when booting and therefore the video driver was not
> > probed/bound. Please try do display some bitmap with bmp
> > command or try to switch to the video console by command
> > "setenv stdout vidconsole0". Then, the video device will be
> > probed and you should see the LVDS output.  
> 
> Here is what I tried:
> 
> => setenv stdout vidconsole0  
> ## Error inserting "stdout" variable, errno=22
> 
> Then I see garbage on the LVDS panel.
> 
> Any ideas as to why setting "stdout" failed?

Does "setenv stdout vidconsole" work? I think I've suggested
wrong command, sorry. "vidconsole0" is the driver instance name
for the first video console, "vidconsole" is the correct name
for console device on framebuffer.

--
Anatolij
diff mbox series

Patch

diff --git a/configs/mx6sabresd_defconfig b/configs/mx6sabresd_defconfig
index ea34217e1c..825218c0d6 100644
--- a/configs/mx6sabresd_defconfig
+++ b/configs/mx6sabresd_defconfig
@@ -93,6 +93,6 @@  CONFIG_USB_GADGET_PRODUCT_NUM=0xa4a5
 CONFIG_CI_UDC=y
 CONFIG_USB_HOST_ETHER=y
 CONFIG_USB_ETHER_ASIX=y
-CONFIG_VIDEO=y
+CONFIG_DM_VIDEO=y
 CONFIG_VIDEO_IPUV3=y
 # CONFIG_VIDEO_SW_CURSOR is not set