| Message ID | 20190312181625.2ED12FF225@linux-xvxi.amer.corp.natinst.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | [U-Boot] Pull request: u-boot-net.git master | expand |
On Tue, Mar 12, 2019 at 01:15:46PM -0500, Joe Hershberger wrote: > Hi Tom, > > These patches passed the CI build here: https://travis-ci.org/jhershbe/u-boot/builds/501807294 > > The following changes since commit 2e8092d94f40a5692baf3ec768ce3216a7bf032a: > > Merge branch 'master' of git://git.denx.de/u-boot-sunxi (2019-03-11 15:48:57 -0400) > > are available in the git repository at: > > > git://git.denx.de/u-boot-net.git master > > for you to fetch changes up to 85f05f72bacc2d047731fc648055551e4f6b34cf: > > net: phy: aquantia: Set only autoneg on in register 4.c441 (2019-03-12 13:13:37 -0500) > NAK. One of: The first bad commit could be any of: 30b2ca2e0fa274b875bb56f541b7dd33ce93c1d1 8860e1563f38d16f7ae29053018cd445c0fa111d ebb5027d69196dd83fd0fa5bd91fca07acfd77be 09e0a36497c84273e5b22488d5af01bf0ba17469 841b9df209e37fe1bfefa5f44e837a0ad497443f 15e67d1cdc7258c0c07ad1fd6c2818f7e9f52447 7aadf5134f2f5771689d0657b69875d0a464859d d35488518f3c16d305092c816a5129f45a0b62d7 Breaks am335x_evm ethernet: 18:39:52 => => dhcp 18:39:52 ethernet@4a100000 Waiting for PHY auto negotiation to complete... done 18:39:52 link up on port 0, speed 1000, full duplex 18:39:52 BOOTP broadcast 1 18:39:52 BOOTP broadcast 2 18:39:52 BOOTP broadcast 3 18:39:52 BOOTP broadcast 4 18:39:52 BOOTP broadcast 5 18:39:52 BOOTP broadcast 6 18:39:52 BOOTP broadcast 7 18:39:52 BOOTP broadcast 8 18:39:52 BOOTP broadcast 9 18:39:52 BOOTP broadcast 10 18:39:52 BOOTP broadcast 11 18:39:52 BOOTP broadcast 12 18:39:52 BOOTP broadcast 13 18:39:52 BOOTP broadcast 14 18:39:52 BOOTP broadcast 15 18:39:52 BOOTP broadcast 16 18:39:52 BOOTP broadcast 17
On Tue, Mar 19, 2019 at 5:41 PM Tom Rini <trini@konsulko.com> wrote: > > On Tue, Mar 12, 2019 at 01:15:46PM -0500, Joe Hershberger wrote: > > > Hi Tom, > > > > These patches passed the CI build here: https://travis-ci.org/jhershbe/u-boot/builds/501807294 > > > > The following changes since commit 2e8092d94f40a5692baf3ec768ce3216a7bf032a: > > > > Merge branch 'master' of git://git.denx.de/u-boot-sunxi (2019-03-11 15:48:57 -0400) > > > > are available in the git repository at: > > > > > > git://git.denx.de/u-boot-net.git master > > > > for you to fetch changes up to 85f05f72bacc2d047731fc648055551e4f6b34cf: > > > > net: phy: aquantia: Set only autoneg on in register 4.c441 (2019-03-12 13:13:37 -0500) > > > > NAK. One of: > The first bad commit could be any of: > 30b2ca2e0fa274b875bb56f541b7dd33ce93c1d1 > 8860e1563f38d16f7ae29053018cd445c0fa111d > ebb5027d69196dd83fd0fa5bd91fca07acfd77be > 09e0a36497c84273e5b22488d5af01bf0ba17469 > 841b9df209e37fe1bfefa5f44e837a0ad497443f > 15e67d1cdc7258c0c07ad1fd6c2818f7e9f52447 > 7aadf5134f2f5771689d0657b69875d0a464859d > d35488518f3c16d305092c816a5129f45a0b62d7 > Breaks am335x_evm ethernet: > 18:39:52 => => dhcp > 18:39:52 ethernet@4a100000 Waiting for PHY auto negotiation to > complete... done > 18:39:52 link up on port 0, speed 1000, full duplex > 18:39:52 BOOTP broadcast 1 > 18:39:52 BOOTP broadcast 2 > 18:39:52 BOOTP broadcast 3 > 18:39:52 BOOTP broadcast 4 > 18:39:52 BOOTP broadcast 5 > 18:39:52 BOOTP broadcast 6 > 18:39:52 BOOTP broadcast 7 > 18:39:52 BOOTP broadcast 8 > 18:39:52 BOOTP broadcast 9 > 18:39:52 BOOTP broadcast 10 > 18:39:52 BOOTP broadcast 11 > 18:39:52 BOOTP broadcast 12 > 18:39:52 BOOTP broadcast 13 > 18:39:52 BOOTP broadcast 14 > 18:39:52 BOOTP broadcast 15 > 18:39:52 BOOTP broadcast 16 > 18:39:52 BOOTP broadcast 17 I rebased the series on the current master and I can't reproduce this dhcp issue. On the original series I saw broken DHCP only with "net: phy: micrel: Use correct skew values on KSZ9021" which doesn't make any sense because that phy is not used on BBB and isn't even compiled in. Also, the issue doesn't reproduce when the next patch is applied. Even that oddity doesn't happen after the rebase. Also the SPL for boneblack is too big to build with some of the patches in this series now, so I'm not sure how that should be handled. Thanks, -Joe
On Tue, Apr 30, 2019 at 09:15:33PM +0000, Joe Hershberger wrote: > On Tue, Mar 19, 2019 at 5:41 PM Tom Rini <trini@konsulko.com> wrote: > > > > On Tue, Mar 12, 2019 at 01:15:46PM -0500, Joe Hershberger wrote: > > > > > Hi Tom, > > > > > > These patches passed the CI build here: https://travis-ci.org/jhershbe/u-boot/builds/501807294 > > > > > > The following changes since commit 2e8092d94f40a5692baf3ec768ce3216a7bf032a: > > > > > > Merge branch 'master' of git://git.denx.de/u-boot-sunxi (2019-03-11 15:48:57 -0400) > > > > > > are available in the git repository at: > > > > > > > > > git://git.denx.de/u-boot-net.git master > > > > > > for you to fetch changes up to 85f05f72bacc2d047731fc648055551e4f6b34cf: > > > > > > net: phy: aquantia: Set only autoneg on in register 4.c441 (2019-03-12 13:13:37 -0500) > > > > > > > NAK. One of: > > The first bad commit could be any of: > > 30b2ca2e0fa274b875bb56f541b7dd33ce93c1d1 > > 8860e1563f38d16f7ae29053018cd445c0fa111d > > ebb5027d69196dd83fd0fa5bd91fca07acfd77be > > 09e0a36497c84273e5b22488d5af01bf0ba17469 > > 841b9df209e37fe1bfefa5f44e837a0ad497443f > > 15e67d1cdc7258c0c07ad1fd6c2818f7e9f52447 > > 7aadf5134f2f5771689d0657b69875d0a464859d > > d35488518f3c16d305092c816a5129f45a0b62d7 > > Breaks am335x_evm ethernet: > > 18:39:52 => => dhcp > > 18:39:52 ethernet@4a100000 Waiting for PHY auto negotiation to > > complete... done > > 18:39:52 link up on port 0, speed 1000, full duplex > > 18:39:52 BOOTP broadcast 1 > > 18:39:52 BOOTP broadcast 2 > > 18:39:52 BOOTP broadcast 3 > > 18:39:52 BOOTP broadcast 4 > > 18:39:52 BOOTP broadcast 5 > > 18:39:52 BOOTP broadcast 6 > > 18:39:52 BOOTP broadcast 7 > > 18:39:52 BOOTP broadcast 8 > > 18:39:52 BOOTP broadcast 9 > > 18:39:52 BOOTP broadcast 10 > > 18:39:52 BOOTP broadcast 11 > > 18:39:52 BOOTP broadcast 12 > > 18:39:52 BOOTP broadcast 13 > > 18:39:52 BOOTP broadcast 14 > > 18:39:52 BOOTP broadcast 15 > > 18:39:52 BOOTP broadcast 16 > > 18:39:52 BOOTP broadcast 17 > > I rebased the series on the current master and I can't reproduce this > dhcp issue. On the original series I saw broken DHCP only with "net: > phy: micrel: Use correct skew values on KSZ9021" which doesn't make > any sense because that phy is not used on BBB and isn't even compiled > in. Also, the issue doesn't reproduce when the next patch is applied. > Even that oddity doesn't happen after the rebase. > > Also the SPL for boneblack is too big to build with some of the > patches in this series now, so I'm not sure how that should be > handled. Drop those parts for now I guess and we'll have to look harder at them stand-alone? And I assume you mean am335x_boneblack_vboot is too large? Or am335x_evm itself? Thanks!
On Tue, Apr 30, 2019 at 4:29 PM Tom Rini <trini@konsulko.com> wrote: > > On Tue, Apr 30, 2019 at 09:15:33PM +0000, Joe Hershberger wrote: > > On Tue, Mar 19, 2019 at 5:41 PM Tom Rini <trini@konsulko.com> wrote: > > > > > > On Tue, Mar 12, 2019 at 01:15:46PM -0500, Joe Hershberger wrote: > > > > > > > Hi Tom, > > > > > > > > These patches passed the CI build here: https://travis-ci.org/jhershbe/u-boot/builds/501807294 > > > > > > > > The following changes since commit 2e8092d94f40a5692baf3ec768ce3216a7bf032a: > > > > > > > > Merge branch 'master' of git://git.denx.de/u-boot-sunxi (2019-03-11 15:48:57 -0400) > > > > > > > > are available in the git repository at: > > > > > > > > > > > > git://git.denx.de/u-boot-net.git master > > > > > > > > for you to fetch changes up to 85f05f72bacc2d047731fc648055551e4f6b34cf: > > > > > > > > net: phy: aquantia: Set only autoneg on in register 4.c441 (2019-03-12 13:13:37 -0500) > > > > > > > > > > NAK. One of: > > > The first bad commit could be any of: > > > 30b2ca2e0fa274b875bb56f541b7dd33ce93c1d1 > > > 8860e1563f38d16f7ae29053018cd445c0fa111d > > > ebb5027d69196dd83fd0fa5bd91fca07acfd77be > > > 09e0a36497c84273e5b22488d5af01bf0ba17469 > > > 841b9df209e37fe1bfefa5f44e837a0ad497443f > > > 15e67d1cdc7258c0c07ad1fd6c2818f7e9f52447 > > > 7aadf5134f2f5771689d0657b69875d0a464859d > > > d35488518f3c16d305092c816a5129f45a0b62d7 > > > Breaks am335x_evm ethernet: > > > 18:39:52 => => dhcp > > > 18:39:52 ethernet@4a100000 Waiting for PHY auto negotiation to > > > complete... done > > > 18:39:52 link up on port 0, speed 1000, full duplex > > > 18:39:52 BOOTP broadcast 1 > > > 18:39:52 BOOTP broadcast 2 > > > 18:39:52 BOOTP broadcast 3 > > > 18:39:52 BOOTP broadcast 4 > > > 18:39:52 BOOTP broadcast 5 > > > 18:39:52 BOOTP broadcast 6 > > > 18:39:52 BOOTP broadcast 7 > > > 18:39:52 BOOTP broadcast 8 > > > 18:39:52 BOOTP broadcast 9 > > > 18:39:52 BOOTP broadcast 10 > > > 18:39:52 BOOTP broadcast 11 > > > 18:39:52 BOOTP broadcast 12 > > > 18:39:52 BOOTP broadcast 13 > > > 18:39:52 BOOTP broadcast 14 > > > 18:39:52 BOOTP broadcast 15 > > > 18:39:52 BOOTP broadcast 16 > > > 18:39:52 BOOTP broadcast 17 > > > > I rebased the series on the current master and I can't reproduce this > > dhcp issue. On the original series I saw broken DHCP only with "net: > > phy: micrel: Use correct skew values on KSZ9021" which doesn't make > > any sense because that phy is not used on BBB and isn't even compiled > > in. Also, the issue doesn't reproduce when the next patch is applied. > > Even that oddity doesn't happen after the rebase. > > > > Also the SPL for boneblack is too big to build with some of the > > patches in this series now, so I'm not sure how that should be > > handled. > > Drop those parts for now I guess and we'll have to look harder at them > stand-alone? And I assume you mean am335x_boneblack_vboot is too large? > Or am335x_evm itself? Thanks! Meaning the SPL part of am335x_evm target fails by a few hundred bytes. > -- > Tom > _______________________________________________ > U-Boot mailing list > U-Boot@lists.denx.de > https://lists.denx.de/listinfo/u-boot
On Wed, May 01, 2019 at 12:56:30AM +0000, Joe Hershberger wrote: > On Tue, Apr 30, 2019 at 4:29 PM Tom Rini <trini@konsulko.com> wrote: > > > > On Tue, Apr 30, 2019 at 09:15:33PM +0000, Joe Hershberger wrote: > > > On Tue, Mar 19, 2019 at 5:41 PM Tom Rini <trini@konsulko.com> wrote: > > > > > > > > On Tue, Mar 12, 2019 at 01:15:46PM -0500, Joe Hershberger wrote: > > > > > > > > > Hi Tom, > > > > > > > > > > These patches passed the CI build here: https://travis-ci.org/jhershbe/u-boot/builds/501807294 > > > > > > > > > > The following changes since commit 2e8092d94f40a5692baf3ec768ce3216a7bf032a: > > > > > > > > > > Merge branch 'master' of git://git.denx.de/u-boot-sunxi (2019-03-11 15:48:57 -0400) > > > > > > > > > > are available in the git repository at: > > > > > > > > > > > > > > > git://git.denx.de/u-boot-net.git master > > > > > > > > > > for you to fetch changes up to 85f05f72bacc2d047731fc648055551e4f6b34cf: > > > > > > > > > > net: phy: aquantia: Set only autoneg on in register 4.c441 (2019-03-12 13:13:37 -0500) > > > > > > > > > > > > > NAK. One of: > > > > The first bad commit could be any of: > > > > 30b2ca2e0fa274b875bb56f541b7dd33ce93c1d1 > > > > 8860e1563f38d16f7ae29053018cd445c0fa111d > > > > ebb5027d69196dd83fd0fa5bd91fca07acfd77be > > > > 09e0a36497c84273e5b22488d5af01bf0ba17469 > > > > 841b9df209e37fe1bfefa5f44e837a0ad497443f > > > > 15e67d1cdc7258c0c07ad1fd6c2818f7e9f52447 > > > > 7aadf5134f2f5771689d0657b69875d0a464859d > > > > d35488518f3c16d305092c816a5129f45a0b62d7 > > > > Breaks am335x_evm ethernet: > > > > 18:39:52 => => dhcp > > > > 18:39:52 ethernet@4a100000 Waiting for PHY auto negotiation to > > > > complete... done > > > > 18:39:52 link up on port 0, speed 1000, full duplex > > > > 18:39:52 BOOTP broadcast 1 > > > > 18:39:52 BOOTP broadcast 2 > > > > 18:39:52 BOOTP broadcast 3 > > > > 18:39:52 BOOTP broadcast 4 > > > > 18:39:52 BOOTP broadcast 5 > > > > 18:39:52 BOOTP broadcast 6 > > > > 18:39:52 BOOTP broadcast 7 > > > > 18:39:52 BOOTP broadcast 8 > > > > 18:39:52 BOOTP broadcast 9 > > > > 18:39:52 BOOTP broadcast 10 > > > > 18:39:52 BOOTP broadcast 11 > > > > 18:39:52 BOOTP broadcast 12 > > > > 18:39:52 BOOTP broadcast 13 > > > > 18:39:52 BOOTP broadcast 14 > > > > 18:39:52 BOOTP broadcast 15 > > > > 18:39:52 BOOTP broadcast 16 > > > > 18:39:52 BOOTP broadcast 17 > > > > > > I rebased the series on the current master and I can't reproduce this > > > dhcp issue. On the original series I saw broken DHCP only with "net: > > > phy: micrel: Use correct skew values on KSZ9021" which doesn't make > > > any sense because that phy is not used on BBB and isn't even compiled > > > in. Also, the issue doesn't reproduce when the next patch is applied. > > > Even that oddity doesn't happen after the rebase. > > > > > > Also the SPL for boneblack is too big to build with some of the > > > patches in this series now, so I'm not sure how that should be > > > handled. > > > > Drop those parts for now I guess and we'll have to look harder at them > > stand-alone? And I assume you mean am335x_boneblack_vboot is too large? > > Or am335x_evm itself? Thanks! > > Meaning the SPL part of am335x_evm target fails by a few hundred bytes. I need to grab the series that shaves a few hundred bytes I think then from SPL for am335x.
Hi Tom, These patches passed the CI build here: https://travis-ci.org/jhershbe/u-boot/builds/501807294 The following changes since commit 2e8092d94f40a5692baf3ec768ce3216a7bf032a: Merge branch 'master' of git://git.denx.de/u-boot-sunxi (2019-03-11 15:48:57 -0400) are available in the git repository at: git://git.denx.de/u-boot-net.git master for you to fetch changes up to 85f05f72bacc2d047731fc648055551e4f6b34cf: net: phy: aquantia: Set only autoneg on in register 4.c441 (2019-03-12 13:13:37 -0500) ---------------------------------------------------------------- Andrejs Cainikovs (2): net: dm: fec: Support phy-reset-post-delay property dts: imx8qxp-mek: Add PHY post reset delay Carlo Caione (4): net: phy: realtek: Introduce quirk to mark RXC not stoppable net: phy: Add generic helpers to access MMD PHY registers net: phy: ti: use generic helpers to access MMD registers cmd: mdio: Switch to generic helpers when accessing the registers James Byrne (2): net: phy: micrel: Use correct skew values on KSZ9021 net: phy: micrel: Find Micrel PHY node correctly Meenakshi Aggarwal (1): mc : Reduce MC memory size to 128M Murali Karicheri (7): ARM: k2g-gp-evm: update to rgmii pinmux configuration ARM: k2g-ice: Add pinmux support for rgmii interface net: netcp: add support for phy with rgmii ids ARM: k2g: add a workaround to reset the phy ARM: dts: k2g-evm: remove unused phy-mode property from phy node k2g: config enable ti phy dp83867 for k2g ARM: dts: k2g-ice: add dt node for netcp Pankaj Bansal (1): drivers: net: ldpaa_eth: fix resource leak Siva Durga Prasad Paladugu (2): net: phy: Reloc next and prev pointers inside phy_drivers net: phy: Fix return value check phy_probe Valentin-catalin Neacsu (1): net: phy: aquantia: Set only autoneg on in register 4.c441 Vladimir Oltean (6): net: phy: ar803x: Address packet drops at low traffic rate due to SmartEEE feature net: phy: ar803x: Make RGMII Tx delays actually configurable for AR8035 net: phy: ar803x: Use common functions for RGMII internal delays net: phy: ar803x: Clarify the configuration of the CLK_25M output pin net: phy: ar803x: Explicitly disable RGMII delays net: phy: ar803x: Clarify the intention of ar8021_config arch/arm/dts/fsl-imx8qxp-mek.dts | 1 + arch/arm/dts/keystone-k2g-evm.dts | 1 - arch/arm/dts/keystone-k2g-ice.dts | 35 ++++++ arch/arm/dts/sama5d3xcm.dtsi | 32 ++--- arch/arm/dts/sama5d3xcm_cmp.dtsi | 32 ++--- arch/arm/dts/socfpga_arria5_socdk.dts | 4 +- arch/arm/dts/socfpga_cyclone5_is1.dts | 4 +- arch/arm/dts/socfpga_cyclone5_socdk.dts | 4 +- arch/arm/dts/socfpga_cyclone5_sockit.dts | 4 +- arch/arm/dts/socfpga_cyclone5_vining_fpga.dts | 4 +- arch/arm/mach-keystone/include/mach/hardware-k2g.h | 3 + arch/arm/mach-keystone/include/mach/mux-k2g.h | 5 + board/ti/ks2_evm/board_k2g.c | 15 +++ board/ti/ks2_evm/mux-k2g.h | 51 +++++--- cmd/mdio.c | 27 +++-- configs/k2g_evm_defconfig | 1 + doc/device-tree-bindings/net/micrel-ksz90x1.txt | 27 +++++ drivers/net/fec_mxc.c | 11 ++ drivers/net/fec_mxc.h | 1 + drivers/net/fsl-mc/mc.c | 22 +++- drivers/net/ldpaa_eth/ldpaa_eth.c | 1 + drivers/net/phy/Kconfig | 41 +++++++ drivers/net/phy/aquantia.c | 7 +- drivers/net/phy/atheros.c | 128 ++++++++++++++------ drivers/net/phy/micrel_ksz90x1.c | 24 +++- drivers/net/phy/phy.c | 21 +++- drivers/net/phy/realtek.c | 19 +++ drivers/net/phy/ti.c | 130 ++++----------------- drivers/net/ti/keystone_net.c | 22 +++- include/configs/ls1088a_common.h | 2 +- include/configs/ls2080a_common.h | 2 +- include/configs/lx2160a_common.h | 2 +- include/phy.h | 70 +++++++++++ 33 files changed, 526 insertions(+), 227 deletions(-) Thanks! -Joe