| Message ID | 20190213234907.24173-1-jsnow@redhat.com |
|---|---|
| State | New |
| Headers | show |
On 2/13/19 6:49 PM, John Snow wrote: > The following changes since commit 0b5e750bea635b167eb03d86c3d9a09bbd43bc06: > > Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging (2019-02-12 10:53:37 +0000) > > are available in the Git repository at: > > https://github.com/jnsnow/qemu.git tags/bitmaps-pull-request > > for you to fetch changes up to fbe8c2e3b041c682d3d52030b53e1627f285a84b: > > blockdev: acquire aio_context for bitmap add/remove (2019-02-13 18:42:46 -0500) > > ---------------------------------------------------------------- > Pull request > P.S. I have extended the expiry on my GPG key and extended the expiry to 2021, you may need to refresh keys. (Hopefully I did it right. This does not come up often.) > ---------------------------------------------------------------- > > Eric Blake (1): > dirty-bitmap: Expose persistent flag to 'query-block' > > John Snow (2): > block/dirty-bitmap: Documentation and Comment fixups > blockdev: acquire aio_context for bitmap add/remove > > block/dirty-bitmap.c | 21 +++++++++++++++------ > blockdev.c | 26 ++++++++++++++++++++------ > qapi/block-core.json | 37 ++++++++++++++++++++++++++++--------- > tests/qemu-iotests/124 | 1 + > tests/qemu-iotests/236.out | 14 ++++++++++++++ > 5 files changed, 78 insertions(+), 21 deletions(-) >
On 2/13/19 5:50 PM, John Snow wrote: > > On 2/13/19 6:49 PM, John Snow wrote: >> The following changes since commit 0b5e750bea635b167eb03d86c3d9a09bbd43bc06: >> >> Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging (2019-02-12 10:53:37 +0000) >> >> are available in the Git repository at: >> >> https://github.com/jnsnow/qemu.git tags/bitmaps-pull-request >> >> for you to fetch changes up to fbe8c2e3b041c682d3d52030b53e1627f285a84b: >> >> blockdev: acquire aio_context for bitmap add/remove (2019-02-13 18:42:46 -0500) >> >> ---------------------------------------------------------------- >> Pull request >> > > P.S. I have extended the expiry on my GPG key and extended the expiry to > 2021, you may need to refresh keys. > > (Hopefully I did it right. This does not come up often.) Expiration on the key shows as 2021 on my end after a re-fetch of key 0x88A9064D183561EB, so that part looks right. But we'll need a v2 pull request, due to the fact that this one fails compilation on all platforms. :(
On Wed, 13 Feb 2019 at 23:49, John Snow <jsnow@redhat.com> wrote: > > The following changes since commit 0b5e750bea635b167eb03d86c3d9a09bbd43bc06: > > Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging (2019-02-12 10:53:37 +0000) > > are available in the Git repository at: > > https://github.com/jnsnow/qemu.git tags/bitmaps-pull-request > > for you to fetch changes up to fbe8c2e3b041c682d3d52030b53e1627f285a84b: > > blockdev: acquire aio_context for bitmap add/remove (2019-02-13 18:42:46 -0500) > > ---------------------------------------------------------------- > Pull request > > ---------------------------------------------------------------- As Eric says, this doesn't compile: /home/petmay01/linaro/qemu-for-merges/blockdev.c: In function ‘qmp_block_dirty_bitmap_add’: /home/petmay01/linaro/qemu-for-merges/blockdev.c:2869:5: error: expected ‘;’ before ‘}’ token } ^ but I've confirmed that I have your updated gpg key info and could verify the tag signature. thanks -- PMM
Patchew URL: https://patchew.org/QEMU/20190213234907.24173-1-jsnow@redhat.com/
Hi,
This series failed the docker-mingw@fedora build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
#!/bin/bash
time make docker-test-mingw@fedora SHOW_ENV=1 J=14
=== TEST SCRIPT END ===
CC qapi/qapi-commands.o
CC qapi/qapi-commands-block-core.o
/tmp/qemu-test/src/blockdev.c: In function 'qmp_block_dirty_bitmap_add':
/tmp/qemu-test/src/blockdev.c:2868:17: error: expected ';' before '}' token
goto out
^
;
The full log is available at
http://patchew.org/logs/20190213234907.24173-1-jsnow@redhat.com/testing.docker-mingw@fedora/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com