| Message ID | 1549207053-24190-2-git-send-email-philipp.tomsich@theobroma-systems.com |
|---|---|
| State | Accepted |
| Commit | f92cf0adcacf85622d9ce58647d8ce6a9b95d624 |
| Delegated to: | Philipp Tomsich |
| Headers | show |
| Series | rockchip: Improve SPI-NOR read performance for the RK3399-Q7 | expand |
> In analysing delays introduced for large SPI reads, the absence of any > indication when a delay was inserted (to ensure the CS toggling is > observed by devices) became apparent. > > Add an additional debug-only debug message to record the insertion and > duration of any delay (note that the debug-message will cause a delay > on-top of the delay-duration). > > Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com> > --- > > drivers/spi/rk_spi.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > Applied to u-boot-rockchip, thanks!
diff --git a/drivers/spi/rk_spi.c b/drivers/spi/rk_spi.c index 14437c0..4153240 100644 --- a/drivers/spi/rk_spi.c +++ b/drivers/spi/rk_spi.c @@ -130,8 +130,13 @@ static void spi_cs_activate(struct udevice *dev, uint cs) if (plat->deactivate_delay_us && priv->last_transaction_us) { ulong delay_us; /* The delay completed so far */ delay_us = timer_get_us() - priv->last_transaction_us; - if (delay_us < plat->deactivate_delay_us) - udelay(plat->deactivate_delay_us - delay_us); + if (delay_us < plat->deactivate_delay_us) { + ulong additional_delay_us = + plat->deactivate_delay_us - delay_us; + debug("%s: delaying by %ld us\n", + __func__, additional_delay_us); + udelay(additional_delay_us); + } } debug("activate cs%u\n", cs);
In analysing delays introduced for large SPI reads, the absence of any indication when a delay was inserted (to ensure the CS toggling is observed by devices) became apparent. Add an additional debug-only debug message to record the insertion and duration of any delay (note that the debug-message will cause a delay on-top of the delay-duration). Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com> --- drivers/spi/rk_spi.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)