| Message ID | 1549039198-16674-20-git-send-email-abel.vesa@nxp.com |
|---|---|
| State | Accepted |
| Delegated to: | Stefano Babic |
| Headers | show |
| Series | mx6sabre: Add DM and SPL FIT support | expand |
On Fri, Feb 1, 2019 at 2:53 PM Abel Vesa <abel.vesa@nxp.com> wrote: > > Rely on the phy-reset-gpios which is set in imx6qdl-sabresd dtsi > and get rid of the enet reset gpio handling from the board file. > > Signed-off-by: Abel Vesa <abel.vesa@nxp.com> Reviewed-by: Fabio Estevam <festevam@gmail.com>
On 02.02.19 10:48, Fabio Estevam wrote: > On Fri, Feb 1, 2019 at 2:53 PM Abel Vesa <abel.vesa@nxp.com> wrote: >> Rely on the phy-reset-gpios which is set in imx6qdl-sabresd dtsi >> and get rid of the enet reset gpio handling from the board file. >> >> Signed-off-by: Abel Vesa <abel.vesa@nxp.com> > Reviewed-by: Fabio Estevam <festevam@gmail.com> Fabio, I tried to understand this patch, in order to also apply it for the tbs2910 board. What I read from the fec_mxc driver, this only works with DM_ETH enabled, but this is not enabled for mx6sabresd. Can you point me to what I miss here? Thanks, Soeren
Hi Soeren, On Thu, Feb 28, 2019 at 4:01 PM Soeren Moch <smoch@web.de> wrote: > Fabio, > > I tried to understand this patch, in order to also apply it for the > tbs2910 board. > What I read from the fec_mxc driver, this only works with DM_ETH > enabled, but this is not enabled for mx6sabresd. Good catch. DM_ETH needs to be enabled for mx6sabresd. However, I noticed that when using U-Boot master I can not boot mx6sabresd anymore: U-Boot SPL 2019.04-rc2-00134-g783e66816d (Feb 28 2019 - 16:17:32 -0300) Trying to boot from MMC1 (It hangs here) Abel, Peng, Could you please take a look at this? Thanks
diff --git a/board/freescale/mx6sabresd/mx6sabresd.c b/board/freescale/mx6sabresd/mx6sabresd.c index 0824a05..385a18e 100644 --- a/board/freescale/mx6sabresd/mx6sabresd.c +++ b/board/freescale/mx6sabresd/mx6sabresd.c @@ -94,13 +94,6 @@ static iomux_v3_cfg_t const enet_pads[] = { static void setup_iomux_enet(void) { SETUP_IOMUX_PADS(enet_pads); - - /* Reset AR8031 PHY */ - gpio_request(IMX_GPIO_NR(1, 25), "ENET PHY Reset"); - gpio_direction_output(IMX_GPIO_NR(1, 25) , 0); - mdelay(10); - gpio_set_value(IMX_GPIO_NR(1, 25), 1); - udelay(100); } static iomux_v3_cfg_t const usdhc2_pads[] = {
Rely on the phy-reset-gpios which is set in imx6qdl-sabresd dtsi and get rid of the enet reset gpio handling from the board file. Signed-off-by: Abel Vesa <abel.vesa@nxp.com> --- board/freescale/mx6sabresd/mx6sabresd.c | 7 ------- 1 file changed, 7 deletions(-)