diff mbox series

[U-Boot] arm: stm32mp1: deploy spl in root folder

Message ID 1548670407-13315-1-git-send-email-patrick.delaunay@st.com
State Accepted
Commit 1b35c90836e5660a37ed33581f06ebb0b36b01ad
Delegated to: Tom Rini
Headers show
Series [U-Boot] arm: stm32mp1: deploy spl in root folder | expand

Commit Message

Patrick DELAUNAY Jan. 28, 2019, 10:13 a.m. UTC
Update generation of spl binaries
- continue to generate all SPL files in spl sub-directory
- copy in root folder the needed file for user (YOCTO, buildroot):
  u-boot-spl.stm32



Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com>
---
Hi,

This patch update http://patchwork.ozlabs.org/patch/1020706 already merged
in u-boot/master.

In fact, it is my v2 proposal to avoid to change the current behavior:
I prefer to keep all the spl generation in spl directory
but I agree to copy the generated file in root folder:
it can be easier for end-user.

This patch avoid to break current behavior, and current upstream effort
of stm32mp1 bsp in YOCTO.

Patrick


 arch/arm/mach-stm32mp/config.mk | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

Comments

Sean Nyekjaer Jan. 28, 2019, 10:23 a.m. UTC | #1
On 28.01.2019 11.13, Patrick Delaunay wrote:
> Update generation of spl binaries
> - continue to generate all SPL files in spl sub-directory
> - copy in root folder the needed file for user (YOCTO, buildroot):
>    u-boot-spl.stm32
> 
> 
> 
> Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com>
> ---
> Hi,
> 
> This patch update http://patchwork.ozlabs.org/patch/1020706 already merged
> in u-boot/master.
> 
> In fact, it is my v2 proposal to avoid to change the current behavior:
> I prefer to keep all the spl generation in spl directory
> but I agree to copy the generated file in root folder:
> it can be easier for end-user.
> 
> This patch avoid to break current behavior, and current upstream effort
> of stm32mp1 bsp in YOCTO.
> 
> Patrick
> 

Just ask Tom to revert the change or have him remove the commit before 
pushing :-)

/Sean
Tom Rini Jan. 30, 2019, 2:20 a.m. UTC | #2
On Mon, Jan 28, 2019 at 11:13:27AM +0100, Patrick Delaunay wrote:

> Update generation of spl binaries
> - continue to generate all SPL files in spl sub-directory
> - copy in root folder the needed file for user (YOCTO, buildroot):
>   u-boot-spl.stm32
> 
> 
> 
> Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com>

Applied to u-boot/master, thanks!
diff mbox series

Patch

diff --git a/arch/arm/mach-stm32mp/config.mk b/arch/arm/mach-stm32mp/config.mk
index 124729c..f371aac 100644
--- a/arch/arm/mach-stm32mp/config.mk
+++ b/arch/arm/mach-stm32mp/config.mk
@@ -7,7 +7,10 @@  ALL-$(CONFIG_SPL_BUILD) += u-boot-spl.stm32
 
 MKIMAGEFLAGS_u-boot-spl.stm32 = -T stm32image -a $(CONFIG_SPL_TEXT_BASE) -e $(CONFIG_SPL_TEXT_BASE)
 
-u-boot-spl.stm32: MKIMAGEOUTPUT = u-boot-spl.stm32.log
+spl/u-boot-spl.stm32: MKIMAGEOUTPUT = spl/u-boot-spl.stm32.log
 
-u-boot-spl.stm32: spl/u-boot-spl.bin FORCE
+spl/u-boot-spl.stm32: spl/u-boot-spl.bin FORCE
 	$(call if_changed,mkimage)
+
+u-boot-spl.stm32 : spl/u-boot-spl.stm32
+	$(call if_changed,copy)