[RESEND,PULL,Regression,SRU,Cosmic] Fix kdump for arm64 GICv3 platforms

Message ID 20190110200440.GA29383@xps13.dannf
State New
Headers show
Series
  • [RESEND,PULL,Regression,SRU,Cosmic] Fix kdump for arm64 GICv3 platforms
Related show

Pull-request

git://git.launchpad.net/~dannf/ubuntu/+source/linux/+git/linux d05-kdump-c

Message

dann frazier Jan. 10, 2019, 8:04 p.m.
Since last-commit for this cycle is tomorrow, I thought I'd reping
about this one from early Dec. Note I did send a v2 for Disco, but it
wasn't necessary for Cosmic, as it did not have the same v1 issue. I
also verified that this series still applies on top of current cosmic.

BugLink: https://bugs.launchpad.net/bugs/1806766

This required a little bit more backporting than Disco, but all pretty
straightforward. Details are in the associated s-o-b sections.

The following changes since commit a2e993524ff91e4ceb2bd577f20b5f150b9f3ade:

  UBUNTU: [Packaging] buildinfo -- add buildinfo support to getabis (2018-12-04 18:58:27 +0100)

are available in the Git repository at:

  git://git.launchpad.net/~dannf/ubuntu/+source/linux/+git/linux d05-kdump-c

for you to fetch changes up to 00dcb574b43fce7285e89972d6b4ecb292d5db9c:

  efi: Prevent GICv3 WARN() by mapping the memreserve table before first use (2018-12-05 08:49:32 -0700)

----------------------------------------------------------------
Ard Biesheuvel (7):
      efi: honour memory reservations passed via a linux specific config table
      efi/arm: libstub: add a root memreserve config table
      efi: add API to reserve memory persistently across kexec reboot
      arm64: memblock: don't permit memblock resizing until linear mapping is up
      efi/arm: Defer persistent reservations until after paging_init()
      efi: Permit calling efi_mem_reserve_persistent() from atomic context
      efi: Prevent GICv3 WARN() by mapping the memreserve table before first use

Marc Zyngier (10):
      irqchip/gic-v3-its: Change initialization ordering for LPIs
      irqchip/gic-v3-its: Simplify LPI_PENDBASE_SZ usage
      irqchip/gic-v3-its: Split property table clearing from allocation
      irqchip/gic-v3-its: Move pending table allocation to init time
      irqchip/gic-v3-its: Keep track of property table's PA and VA
      irqchip/gic-v3-its: Allow use of pre-programmed LPI tables
      irqchip/gic-v3-its: Use pre-programmed redistributor tables with kdump kernels
      irqchip/gic-v3-its: Check that all RDs have the same property table
      irqchip/gic-v3-its: Register LPI tables with EFI config table
      irqchip/gic-v3-its: Allow use of LPI tables in reserved memory

 arch/arm64/kernel/setup.c               |   1 +
 arch/arm64/mm/init.c                    |   2 -
 arch/arm64/mm/mmu.c                     |   2 +
 drivers/firmware/efi/efi.c              |  86 ++++++++++-
 drivers/firmware/efi/libstub/arm-stub.c |  30 ++++
 drivers/irqchip/irq-gic-v3-its.c        | 245 +++++++++++++++++++++++++-------
 drivers/irqchip/irq-gic-v3.c            |  20 +--
 include/linux/efi.h                     |  16 +++
 include/linux/irqchip/arm-gic-v3.h      |   4 +-
 9 files changed, 340 insertions(+), 66 deletions(-)

Comments

Stefan Bader Jan. 11, 2019, 8:26 a.m. | #1
On 10.01.19 21:04, dann frazier wrote:
> Since last-commit for this cycle is tomorrow, I thought I'd reping
> about this one from early Dec. Note I did send a v2 for Disco, but it
> wasn't necessary for Cosmic, as it did not have the same v1 issue. I
> also verified that this series still applies on top of current cosmic.
> 
> BugLink: https://bugs.launchpad.net/bugs/1806766
> 
> This required a little bit more backporting than Disco, but all pretty
> straightforward. Details are in the associated s-o-b sections.
> 
> The following changes since commit a2e993524ff91e4ceb2bd577f20b5f150b9f3ade:
> 
>   UBUNTU: [Packaging] buildinfo -- add buildinfo support to getabis (2018-12-04 18:58:27 +0100)
> 
> are available in the Git repository at:
> 
>   git://git.launchpad.net/~dannf/ubuntu/+source/linux/+git/linux d05-kdump-c
> 
> for you to fetch changes up to 00dcb574b43fce7285e89972d6b4ecb292d5db9c:
> 
>   efi: Prevent GICv3 WARN() by mapping the memreserve table before first use (2018-12-05 08:49:32 -0700)
> 
> ----------------------------------------------------------------
> Ard Biesheuvel (7):
>       efi: honour memory reservations passed via a linux specific config table
>       efi/arm: libstub: add a root memreserve config table
>       efi: add API to reserve memory persistently across kexec reboot
>       arm64: memblock: don't permit memblock resizing until linear mapping is up
>       efi/arm: Defer persistent reservations until after paging_init()
>       efi: Permit calling efi_mem_reserve_persistent() from atomic context
>       efi: Prevent GICv3 WARN() by mapping the memreserve table before first use
> 
> Marc Zyngier (10):
>       irqchip/gic-v3-its: Change initialization ordering for LPIs
>       irqchip/gic-v3-its: Simplify LPI_PENDBASE_SZ usage
>       irqchip/gic-v3-its: Split property table clearing from allocation
>       irqchip/gic-v3-its: Move pending table allocation to init time
>       irqchip/gic-v3-its: Keep track of property table's PA and VA
>       irqchip/gic-v3-its: Allow use of pre-programmed LPI tables
>       irqchip/gic-v3-its: Use pre-programmed redistributor tables with kdump kernels
>       irqchip/gic-v3-its: Check that all RDs have the same property table
>       irqchip/gic-v3-its: Register LPI tables with EFI config table
>       irqchip/gic-v3-its: Allow use of LPI tables in reserved memory
> 
>  arch/arm64/kernel/setup.c               |   1 +
>  arch/arm64/mm/init.c                    |   2 -
>  arch/arm64/mm/mmu.c                     |   2 +
>  drivers/firmware/efi/efi.c              |  86 ++++++++++-
>  drivers/firmware/efi/libstub/arm-stub.c |  30 ++++
>  drivers/irqchip/irq-gic-v3-its.c        | 245 +++++++++++++++++++++++++-------
>  drivers/irqchip/irq-gic-v3.c            |  20 +--
>  include/linux/efi.h                     |  16 +++
>  include/linux/irqchip/arm-gic-v3.h      |   4 +-
>  9 files changed, 340 insertions(+), 66 deletions(-)
> 
By sending out your pull requests you end up us only seeing the Disco one and
likely ignore the rest. Better would be to have a cover email which has all
included series in the subject.

Acked-by: Stefan Bader <stefan.bader@canonical.com>
Colin King Jan. 11, 2019, 9:36 a.m. | #2
On 10/01/2019 20:04, dann frazier wrote:
> Since last-commit for this cycle is tomorrow, I thought I'd reping
> about this one from early Dec. Note I did send a v2 for Disco, but it
> wasn't necessary for Cosmic, as it did not have the same v1 issue. I
> also verified that this series still applies on top of current cosmic.
> 
> BugLink: https://bugs.launchpad.net/bugs/1806766
> 
> This required a little bit more backporting than Disco, but all pretty
> straightforward. Details are in the associated s-o-b sections.
> 
> The following changes since commit a2e993524ff91e4ceb2bd577f20b5f150b9f3ade:
> 
>   UBUNTU: [Packaging] buildinfo -- add buildinfo support to getabis (2018-12-04 18:58:27 +0100)
> 
> are available in the Git repository at:
> 
>   git://git.launchpad.net/~dannf/ubuntu/+source/linux/+git/linux d05-kdump-c
> 
> for you to fetch changes up to 00dcb574b43fce7285e89972d6b4ecb292d5db9c:
> 
>   efi: Prevent GICv3 WARN() by mapping the memreserve table before first use (2018-12-05 08:49:32 -0700)
> 
> ----------------------------------------------------------------
> Ard Biesheuvel (7):
>       efi: honour memory reservations passed via a linux specific config table
>       efi/arm: libstub: add a root memreserve config table
>       efi: add API to reserve memory persistently across kexec reboot
>       arm64: memblock: don't permit memblock resizing until linear mapping is up
>       efi/arm: Defer persistent reservations until after paging_init()
>       efi: Permit calling efi_mem_reserve_persistent() from atomic context
>       efi: Prevent GICv3 WARN() by mapping the memreserve table before first use
> 
> Marc Zyngier (10):
>       irqchip/gic-v3-its: Change initialization ordering for LPIs
>       irqchip/gic-v3-its: Simplify LPI_PENDBASE_SZ usage
>       irqchip/gic-v3-its: Split property table clearing from allocation
>       irqchip/gic-v3-its: Move pending table allocation to init time
>       irqchip/gic-v3-its: Keep track of property table's PA and VA
>       irqchip/gic-v3-its: Allow use of pre-programmed LPI tables
>       irqchip/gic-v3-its: Use pre-programmed redistributor tables with kdump kernels
>       irqchip/gic-v3-its: Check that all RDs have the same property table
>       irqchip/gic-v3-its: Register LPI tables with EFI config table
>       irqchip/gic-v3-its: Allow use of LPI tables in reserved memory
> 
>  arch/arm64/kernel/setup.c               |   1 +
>  arch/arm64/mm/init.c                    |   2 -
>  arch/arm64/mm/mmu.c                     |   2 +
>  drivers/firmware/efi/efi.c              |  86 ++++++++++-
>  drivers/firmware/efi/libstub/arm-stub.c |  30 ++++
>  drivers/irqchip/irq-gic-v3-its.c        | 245 +++++++++++++++++++++++++-------
>  drivers/irqchip/irq-gic-v3.c            |  20 +--
>  include/linux/efi.h                     |  16 +++
>  include/linux/irqchip/arm-gic-v3.h      |   4 +-
>  9 files changed, 340 insertions(+), 66 deletions(-)
> 

Thanks Dann, looks good.

Acked-by: Colin Ian King <colin.king@canonical.com>
Kleber Souza Jan. 11, 2019, 10:21 a.m. | #3
On 1/10/19 9:04 PM, dann frazier wrote:
> Since last-commit for this cycle is tomorrow, I thought I'd reping
> about this one from early Dec. Note I did send a v2 for Disco, but it
> wasn't necessary for Cosmic, as it did not have the same v1 issue. I
> also verified that this series still applies on top of current cosmic.
>
> BugLink: https://bugs.launchpad.net/bugs/1806766
>
> This required a little bit more backporting than Disco, but all pretty
> straightforward. Details are in the associated s-o-b sections.
>
> The following changes since commit a2e993524ff91e4ceb2bd577f20b5f150b9f3ade:
>
>   UBUNTU: [Packaging] buildinfo -- add buildinfo support to getabis (2018-12-04 18:58:27 +0100)
>
> are available in the Git repository at:
>
>   git://git.launchpad.net/~dannf/ubuntu/+source/linux/+git/linux d05-kdump-c
>
> for you to fetch changes up to 00dcb574b43fce7285e89972d6b4ecb292d5db9c:
>
>   efi: Prevent GICv3 WARN() by mapping the memreserve table before first use (2018-12-05 08:49:32 -0700)
>
> ----------------------------------------------------------------
> Ard Biesheuvel (7):
>       efi: honour memory reservations passed via a linux specific config table
>       efi/arm: libstub: add a root memreserve config table
>       efi: add API to reserve memory persistently across kexec reboot
>       arm64: memblock: don't permit memblock resizing until linear mapping is up
>       efi/arm: Defer persistent reservations until after paging_init()
>       efi: Permit calling efi_mem_reserve_persistent() from atomic context
>       efi: Prevent GICv3 WARN() by mapping the memreserve table before first use
>
> Marc Zyngier (10):
>       irqchip/gic-v3-its: Change initialization ordering for LPIs
>       irqchip/gic-v3-its: Simplify LPI_PENDBASE_SZ usage
>       irqchip/gic-v3-its: Split property table clearing from allocation
>       irqchip/gic-v3-its: Move pending table allocation to init time
>       irqchip/gic-v3-its: Keep track of property table's PA and VA
>       irqchip/gic-v3-its: Allow use of pre-programmed LPI tables
>       irqchip/gic-v3-its: Use pre-programmed redistributor tables with kdump kernels
>       irqchip/gic-v3-its: Check that all RDs have the same property table
>       irqchip/gic-v3-its: Register LPI tables with EFI config table
>       irqchip/gic-v3-its: Allow use of LPI tables in reserved memory
>
>  arch/arm64/kernel/setup.c               |   1 +
>  arch/arm64/mm/init.c                    |   2 -
>  arch/arm64/mm/mmu.c                     |   2 +
>  drivers/firmware/efi/efi.c              |  86 ++++++++++-
>  drivers/firmware/efi/libstub/arm-stub.c |  30 ++++
>  drivers/irqchip/irq-gic-v3-its.c        | 245 +++++++++++++++++++++++++-------
>  drivers/irqchip/irq-gic-v3.c            |  20 +--
>  include/linux/efi.h                     |  16 +++
>  include/linux/irqchip/arm-gic-v3.h      |   4 +-
>  9 files changed, 340 insertions(+), 66 deletions(-)
>
Applied to cosmic/master-next branch.

Thanks,
Kleber
dann frazier Jan. 11, 2019, 5:09 p.m. | #4
On Fri, Jan 11, 2019 at 1:26 AM Stefan Bader <stefan.bader@canonical.com> wrote:
>
> On 10.01.19 21:04, dann frazier wrote:
> > Since last-commit for this cycle is tomorrow, I thought I'd reping
> > about this one from early Dec. Note I did send a v2 for Disco, but it
> > wasn't necessary for Cosmic, as it did not have the same v1 issue. I
> > also verified that this series still applies on top of current cosmic.
> >
> > BugLink: https://bugs.launchpad.net/bugs/1806766
> >
> > This required a little bit more backporting than Disco, but all pretty
> > straightforward. Details are in the associated s-o-b sections.
> >
> > The following changes since commit a2e993524ff91e4ceb2bd577f20b5f150b9f3ade:
> >
> >   UBUNTU: [Packaging] buildinfo -- add buildinfo support to getabis (2018-12-04 18:58:27 +0100)
> >
> > are available in the Git repository at:
> >
> >   git://git.launchpad.net/~dannf/ubuntu/+source/linux/+git/linux d05-kdump-c
> >
> > for you to fetch changes up to 00dcb574b43fce7285e89972d6b4ecb292d5db9c:
> >
> >   efi: Prevent GICv3 WARN() by mapping the memreserve table before first use (2018-12-05 08:49:32 -0700)
> >
> > ----------------------------------------------------------------
> > Ard Biesheuvel (7):
> >       efi: honour memory reservations passed via a linux specific config table
> >       efi/arm: libstub: add a root memreserve config table
> >       efi: add API to reserve memory persistently across kexec reboot
> >       arm64: memblock: don't permit memblock resizing until linear mapping is up
> >       efi/arm: Defer persistent reservations until after paging_init()
> >       efi: Permit calling efi_mem_reserve_persistent() from atomic context
> >       efi: Prevent GICv3 WARN() by mapping the memreserve table before first use
> >
> > Marc Zyngier (10):
> >       irqchip/gic-v3-its: Change initialization ordering for LPIs
> >       irqchip/gic-v3-its: Simplify LPI_PENDBASE_SZ usage
> >       irqchip/gic-v3-its: Split property table clearing from allocation
> >       irqchip/gic-v3-its: Move pending table allocation to init time
> >       irqchip/gic-v3-its: Keep track of property table's PA and VA
> >       irqchip/gic-v3-its: Allow use of pre-programmed LPI tables
> >       irqchip/gic-v3-its: Use pre-programmed redistributor tables with kdump kernels
> >       irqchip/gic-v3-its: Check that all RDs have the same property table
> >       irqchip/gic-v3-its: Register LPI tables with EFI config table
> >       irqchip/gic-v3-its: Allow use of LPI tables in reserved memory
> >
> >  arch/arm64/kernel/setup.c               |   1 +
> >  arch/arm64/mm/init.c                    |   2 -
> >  arch/arm64/mm/mmu.c                     |   2 +
> >  drivers/firmware/efi/efi.c              |  86 ++++++++++-
> >  drivers/firmware/efi/libstub/arm-stub.c |  30 ++++
> >  drivers/irqchip/irq-gic-v3-its.c        | 245 +++++++++++++++++++++++++-------
> >  drivers/irqchip/irq-gic-v3.c            |  20 +--
> >  include/linux/efi.h                     |  16 +++
> >  include/linux/irqchip/arm-gic-v3.h      |   4 +-
> >  9 files changed, 340 insertions(+), 66 deletions(-)
> >
> By sending out your pull requests you end up us only seeing the Disco one and
> likely ignore the rest. Better would be to have a cover email which has all
> included series in the subject.

OK, sorry about that. Should the cover letter have "[PULL
0/3][X][Y][Z]" w/ "[PULL 1/3][X]" for each? If not, is there an
example in the archive you could suggest as a model to follow?

> Acked-by: Stefan Bader <stefan.bader@canonical.com>

Thanks!

 -dann