| Message ID | 1546878450-20341-14-git-send-email-andrew.murray@arm.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | perf/core: Generalise event exclusion checking | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | next/apply_patch Successfully applied |
| snowpatch_ozlabs/build-ppc64le | fail | build failed! |
| snowpatch_ozlabs/build-ppc64be | fail | build failed! |
| snowpatch_ozlabs/build-ppc64e | success | build succeeded & removed 0 sparse warning(s) |
| snowpatch_ozlabs/build-pmac32 | success | build succeeded & removed 0 sparse warning(s) |
| snowpatch_ozlabs/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 22 lines checked |
On Mon, Jan 07, 2019 at 04:27:30PM +0000, Andrew Murray wrote: > The Cavium ThunderX2 UNCORE PMU driver doesn't support any event > filtering. Let's advertise the PERF_PMU_CAP_NO_EXCLUDE capability to > simplify the code. > > Signed-off-by: Andrew Murray <andrew.murray@arm.com> > --- > drivers/perf/thunderx2_pmu.c | 10 +--------- > 1 file changed, 1 insertion(+), 9 deletions(-) Acked-by: Will Deacon <will.deacon@arm.com> Thanks for fixing this up. Will
diff --git a/drivers/perf/thunderx2_pmu.c b/drivers/perf/thunderx2_pmu.c index c9a1701..43d76c8 100644 --- a/drivers/perf/thunderx2_pmu.c +++ b/drivers/perf/thunderx2_pmu.c @@ -424,15 +424,6 @@ static int tx2_uncore_event_init(struct perf_event *event) if (is_sampling_event(event) || event->attach_state & PERF_ATTACH_TASK) return -EINVAL; - /* We have no filtering of any kind */ - if (event->attr.exclude_user || - event->attr.exclude_kernel || - event->attr.exclude_hv || - event->attr.exclude_idle || - event->attr.exclude_host || - event->attr.exclude_guest) - return -EINVAL; - if (event->cpu < 0) return -EINVAL; @@ -572,6 +563,7 @@ static int tx2_uncore_pmu_register( .start = tx2_uncore_event_start, .stop = tx2_uncore_event_stop, .read = tx2_uncore_event_read, + .capabilities = PERF_PMU_CAP_NO_EXCLUDE, }; tx2_pmu->pmu.name = devm_kasprintf(dev, GFP_KERNEL,
The Cavium ThunderX2 UNCORE PMU driver doesn't support any event filtering. Let's advertise the PERF_PMU_CAP_NO_EXCLUDE capability to simplify the code. Signed-off-by: Andrew Murray <andrew.murray@arm.com> --- drivers/perf/thunderx2_pmu.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-)