| Message ID | 1543518777-16208-1-git-send-email-trini@konsulko.com |
|---|---|
| State | Superseded |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | [U-Boot,PATCHv2,1/4] dm: MIGRATION: Add migration plan for DM_MMC | expand |
On Thu, 29 Nov 2018 at 12:13, Tom Rini <trini@konsulko.com> wrote: > > Given that at this point the MMC subsystem itself has been migrated > along with a number of subsystem drivers, formalize a deadline for > migration. > > Cc: Simon Glass <sjg@chromium.org> > Cc: Jaehoon Chung <jh80.chung@samsung.com> > Signed-off-by: Tom Rini <trini@konsulko.com> > --- > Changes in v2: > - Note that failure to migration may lead to removal. > --- > Makefile | 8 ++++++++ > doc/driver-model/MIGRATION.txt | 9 +++++++++ > 2 files changed, 17 insertions(+) Reviewed-by: Simon Glass <sjg@chromium.org> Would be good to get Marek and a few of the others that didn't notice the migration to ack this. - Simon
On 29.11.2018 20:12, Tom Rini wrote: > Given that at this point the MMC subsystem itself has been migrated > along with a number of subsystem drivers, formalize a deadline for > migration. > > Cc: Simon Glass <sjg@chromium.org> > Cc: Jaehoon Chung <jh80.chung@samsung.com> > Signed-off-by: Tom Rini <trini@konsulko.com> > --- > Changes in v2: > - Note that failure to migration may lead to removal. > --- > Makefile | 8 ++++++++ > doc/driver-model/MIGRATION.txt | 9 +++++++++ > 2 files changed, 17 insertions(+) > > diff --git a/Makefile b/Makefile > index a4b1d1db5241..0ab48f9ac97f 100644 > --- a/Makefile > +++ b/Makefile > @@ -920,6 +920,14 @@ ifeq ($(CONFIG_DM_I2C_COMPAT)$(CONFIG_SANDBOX),y) > @echo "before sending patches to the mailing list." > @echo "====================================================" > endif > +ifneq ($(CONFIG_DM_MMC)$(CONFIG_OF_CONTROL)$(CONFIG_BLK),yyy) This might not be a too widespread use of U-Boot, but I do have one configuration that boots from FPGA and loads Linux via TFTP. Due to size constraints in FPGA onchip RAM, I have MMC disabled completely. This patch gives me a warning in this case. I can live with that as I know I have MMC disabled and don't this warning for my other configs though. Just wanted to let you know, as you complained about getting no replies to this thread ;-) Simon > + @echo "===================== WARNING ======================" > + @echo "This board does not use CONFIG_DM_MMC. Please update" > + @echo "the board to use CONFIG_DM_MMC before the v2019.04 release." > + @echo "Failure to update by the deadline may result in board removal." > + @echo "See doc/driver-model/MIGRATION.txt for more info." > + @echo "====================================================" > +endif > @# Check that this build does not use CONFIG options that we do not > @# know about unless they are in Kconfig. All the existing CONFIG > @# options are whitelisted, so new ones should not be added. > diff --git a/doc/driver-model/MIGRATION.txt b/doc/driver-model/MIGRATION.txt > index 5ebefd608b99..71c26571828a 100644 > --- a/doc/driver-model/MIGRATION.txt > +++ b/doc/driver-model/MIGRATION.txt > @@ -5,6 +5,15 @@ U-Boot has been migrating to a new driver model since its introduction in > 2014. This file describes the schedule for deprecation of pre-driver-model > features. > > +CONFIG_DM_MMC > +------------- > + > +Status: In progress > +Deadline: 2019.04 > + > +The subsystem itself has been converted and maintainers should submit patches > +switching over to using CONFIG_DM_MMC and other base driver model options in > +time for inclusion in the 2019.04 rerelease. > > CONFIG_BLK > ----------
On Thu, Nov 29, 2018 at 08:51:17PM +0100, Simon Goldschmidt wrote: > On 29.11.2018 20:12, Tom Rini wrote: > >Given that at this point the MMC subsystem itself has been migrated > >along with a number of subsystem drivers, formalize a deadline for > >migration. > > > >Cc: Simon Glass <sjg@chromium.org> > >Cc: Jaehoon Chung <jh80.chung@samsung.com> > >Signed-off-by: Tom Rini <trini@konsulko.com> > >--- > >Changes in v2: > >- Note that failure to migration may lead to removal. > >--- > > Makefile | 8 ++++++++ > > doc/driver-model/MIGRATION.txt | 9 +++++++++ > > 2 files changed, 17 insertions(+) > > > >diff --git a/Makefile b/Makefile > >index a4b1d1db5241..0ab48f9ac97f 100644 > >--- a/Makefile > >+++ b/Makefile > >@@ -920,6 +920,14 @@ ifeq ($(CONFIG_DM_I2C_COMPAT)$(CONFIG_SANDBOX),y) > > @echo "before sending patches to the mailing list." > > @echo "====================================================" > > endif > >+ifneq ($(CONFIG_DM_MMC)$(CONFIG_OF_CONTROL)$(CONFIG_BLK),yyy) > > This might not be a too widespread use of U-Boot, but I do have one > configuration that boots from FPGA and loads Linux via TFTP. Due to size > constraints in FPGA onchip RAM, I have MMC disabled completely. This patch > gives me a warning in this case. > > I can live with that as I know I have MMC disabled and don't this warning > for my other configs though. Just wanted to let you know, as you complained > about getting no replies to this thread ;-) Ah, thanks. That means I should have put a test for CONFIG_MMC in there somewhere. I need to re-work the USB one too I think to confirm CONFIG_USB is set. Thanks! I'll post a v3 once I've given folks a chance in general to chime in with this having re-hit their inbox.
On 29.11.2018 21:02, Tom Rini wrote: > On Thu, Nov 29, 2018 at 08:51:17PM +0100, Simon Goldschmidt wrote: >> On 29.11.2018 20:12, Tom Rini wrote: >>> Given that at this point the MMC subsystem itself has been migrated >>> along with a number of subsystem drivers, formalize a deadline for >>> migration. >>> >>> Cc: Simon Glass <sjg@chromium.org> >>> Cc: Jaehoon Chung <jh80.chung@samsung.com> >>> Signed-off-by: Tom Rini <trini@konsulko.com> >>> --- >>> Changes in v2: >>> - Note that failure to migration may lead to removal. >>> --- >>> Makefile | 8 ++++++++ >>> doc/driver-model/MIGRATION.txt | 9 +++++++++ >>> 2 files changed, 17 insertions(+) >>> >>> diff --git a/Makefile b/Makefile >>> index a4b1d1db5241..0ab48f9ac97f 100644 >>> --- a/Makefile >>> +++ b/Makefile >>> @@ -920,6 +920,14 @@ ifeq ($(CONFIG_DM_I2C_COMPAT)$(CONFIG_SANDBOX),y) >>> @echo "before sending patches to the mailing list." >>> @echo "====================================================" >>> endif >>> +ifneq ($(CONFIG_DM_MMC)$(CONFIG_OF_CONTROL)$(CONFIG_BLK),yyy) >> This might not be a too widespread use of U-Boot, but I do have one >> configuration that boots from FPGA and loads Linux via TFTP. Due to size >> constraints in FPGA onchip RAM, I have MMC disabled completely. This patch >> gives me a warning in this case. >> >> I can live with that as I know I have MMC disabled and don't this warning >> for my other configs though. Just wanted to let you know, as you complained >> about getting no replies to this thread ;-) > Ah, thanks. That means I should have put a test for CONFIG_MMC in there > somewhere. I need to re-work the USB one too I think to confirm > CONFIG_USB is set. Thanks! I'll post a v3 once I've given folks a > chance in general to chime in with this having re-hit their inbox. I would have suggested that, but I hesitated since I can enable CONFIG_DM_MMC without enabling CONFIG_MMC... Regards, Simon
On 29.11.2018 21:02, Tom Rini wrote: > On Thu, Nov 29, 2018 at 08:51:17PM +0100, Simon Goldschmidt wrote: >> On 29.11.2018 20:12, Tom Rini wrote: >>> Given that at this point the MMC subsystem itself has been migrated >>> along with a number of subsystem drivers, formalize a deadline for >>> migration. >>> >>> Cc: Simon Glass <sjg@chromium.org> >>> Cc: Jaehoon Chung <jh80.chung@samsung.com> >>> Signed-off-by: Tom Rini <trini@konsulko.com> >>> --- >>> Changes in v2: >>> - Note that failure to migration may lead to removal. >>> --- >>> Makefile | 8 ++++++++ >>> doc/driver-model/MIGRATION.txt | 9 +++++++++ >>> 2 files changed, 17 insertions(+) >>> >>> diff --git a/Makefile b/Makefile >>> index a4b1d1db5241..0ab48f9ac97f 100644 >>> --- a/Makefile >>> +++ b/Makefile >>> @@ -920,6 +920,14 @@ ifeq ($(CONFIG_DM_I2C_COMPAT)$(CONFIG_SANDBOX),y) >>> @echo "before sending patches to the mailing list." >>> @echo "====================================================" >>> endif >>> +ifneq ($(CONFIG_DM_MMC)$(CONFIG_OF_CONTROL)$(CONFIG_BLK),yyy) >> This might not be a too widespread use of U-Boot, but I do have one >> configuration that boots from FPGA and loads Linux via TFTP. Due to size >> constraints in FPGA onchip RAM, I have MMC disabled completely. This patch >> gives me a warning in this case. >> >> I can live with that as I know I have MMC disabled and don't this warning >> for my other configs though. Just wanted to let you know, as you complained >> about getting no replies to this thread ;-) > Ah, thanks. That means I should have put a test for CONFIG_MMC in there > somewhere. I need to re-work the USB one too I think to confirm > CONFIG_USB is set. Thanks! I'll post a v3 once I've given folks a > chance in general to chime in with this having re-hit their inbox. And you're right, I get the same problem for USB, which I have always disabled on our boards. But with CONFIG_USB, it's more clear to be than with CONFIG_MMC. Maybe CONFIG_DM_MMC should depend on CONFIG_MMC? Simon
On Thu, Nov 29, 2018 at 09:04:30PM +0100, Simon Goldschmidt wrote: > On 29.11.2018 21:02, Tom Rini wrote: > >On Thu, Nov 29, 2018 at 08:51:17PM +0100, Simon Goldschmidt wrote: > >>On 29.11.2018 20:12, Tom Rini wrote: > >>>Given that at this point the MMC subsystem itself has been migrated > >>>along with a number of subsystem drivers, formalize a deadline for > >>>migration. > >>> > >>>Cc: Simon Glass <sjg@chromium.org> > >>>Cc: Jaehoon Chung <jh80.chung@samsung.com> > >>>Signed-off-by: Tom Rini <trini@konsulko.com> > >>>--- > >>>Changes in v2: > >>>- Note that failure to migration may lead to removal. > >>>--- > >>> Makefile | 8 ++++++++ > >>> doc/driver-model/MIGRATION.txt | 9 +++++++++ > >>> 2 files changed, 17 insertions(+) > >>> > >>>diff --git a/Makefile b/Makefile > >>>index a4b1d1db5241..0ab48f9ac97f 100644 > >>>--- a/Makefile > >>>+++ b/Makefile > >>>@@ -920,6 +920,14 @@ ifeq ($(CONFIG_DM_I2C_COMPAT)$(CONFIG_SANDBOX),y) > >>> @echo "before sending patches to the mailing list." > >>> @echo "====================================================" > >>> endif > >>>+ifneq ($(CONFIG_DM_MMC)$(CONFIG_OF_CONTROL)$(CONFIG_BLK),yyy) > >>This might not be a too widespread use of U-Boot, but I do have one > >>configuration that boots from FPGA and loads Linux via TFTP. Due to size > >>constraints in FPGA onchip RAM, I have MMC disabled completely. This patch > >>gives me a warning in this case. > >> > >>I can live with that as I know I have MMC disabled and don't this warning > >>for my other configs though. Just wanted to let you know, as you complained > >>about getting no replies to this thread ;-) > >Ah, thanks. That means I should have put a test for CONFIG_MMC in there > >somewhere. I need to re-work the USB one too I think to confirm > >CONFIG_USB is set. Thanks! I'll post a v3 once I've given folks a > >chance in general to chime in with this having re-hit their inbox. > > I would have suggested that, but I hesitated since I can enable > CONFIG_DM_MMC without enabling CONFIG_MMC... Ha. I bet it won't work in the end 'tho, we only traverse drivers/mmc/ with CONFIG_MMC=y. Thanks!
On Thu, Nov 29, 2018 at 09:10:50PM +0100, Simon Goldschmidt wrote: > On 29.11.2018 21:02, Tom Rini wrote: > >On Thu, Nov 29, 2018 at 08:51:17PM +0100, Simon Goldschmidt wrote: > >>On 29.11.2018 20:12, Tom Rini wrote: > >>>Given that at this point the MMC subsystem itself has been migrated > >>>along with a number of subsystem drivers, formalize a deadline for > >>>migration. > >>> > >>>Cc: Simon Glass <sjg@chromium.org> > >>>Cc: Jaehoon Chung <jh80.chung@samsung.com> > >>>Signed-off-by: Tom Rini <trini@konsulko.com> > >>>--- > >>>Changes in v2: > >>>- Note that failure to migration may lead to removal. > >>>--- > >>> Makefile | 8 ++++++++ > >>> doc/driver-model/MIGRATION.txt | 9 +++++++++ > >>> 2 files changed, 17 insertions(+) > >>> > >>>diff --git a/Makefile b/Makefile > >>>index a4b1d1db5241..0ab48f9ac97f 100644 > >>>--- a/Makefile > >>>+++ b/Makefile > >>>@@ -920,6 +920,14 @@ ifeq ($(CONFIG_DM_I2C_COMPAT)$(CONFIG_SANDBOX),y) > >>> @echo "before sending patches to the mailing list." > >>> @echo "====================================================" > >>> endif > >>>+ifneq ($(CONFIG_DM_MMC)$(CONFIG_OF_CONTROL)$(CONFIG_BLK),yyy) > >>This might not be a too widespread use of U-Boot, but I do have one > >>configuration that boots from FPGA and loads Linux via TFTP. Due to size > >>constraints in FPGA onchip RAM, I have MMC disabled completely. This patch > >>gives me a warning in this case. > >> > >>I can live with that as I know I have MMC disabled and don't this warning > >>for my other configs though. Just wanted to let you know, as you complained > >>about getting no replies to this thread ;-) > >Ah, thanks. That means I should have put a test for CONFIG_MMC in there > >somewhere. I need to re-work the USB one too I think to confirm > >CONFIG_USB is set. Thanks! I'll post a v3 once I've given folks a > >chance in general to chime in with this having re-hit their inbox. > > And you're right, I get the same problem for USB, which I have always > disabled on our boards. But with CONFIG_USB, it's more clear to be than with > CONFIG_MMC. Maybe CONFIG_DM_MMC should depend on CONFIG_MMC? I suspect a small re-work to the Kconfig file to turn MMC into a menuconfig so that everything else is grouped under it would help, yes. Thanks!
diff --git a/Makefile b/Makefile index a4b1d1db5241..0ab48f9ac97f 100644 --- a/Makefile +++ b/Makefile @@ -920,6 +920,14 @@ ifeq ($(CONFIG_DM_I2C_COMPAT)$(CONFIG_SANDBOX),y) @echo "before sending patches to the mailing list." @echo "====================================================" endif +ifneq ($(CONFIG_DM_MMC)$(CONFIG_OF_CONTROL)$(CONFIG_BLK),yyy) + @echo "===================== WARNING ======================" + @echo "This board does not use CONFIG_DM_MMC. Please update" + @echo "the board to use CONFIG_DM_MMC before the v2019.04 release." + @echo "Failure to update by the deadline may result in board removal." + @echo "See doc/driver-model/MIGRATION.txt for more info." + @echo "====================================================" +endif @# Check that this build does not use CONFIG options that we do not @# know about unless they are in Kconfig. All the existing CONFIG @# options are whitelisted, so new ones should not be added. diff --git a/doc/driver-model/MIGRATION.txt b/doc/driver-model/MIGRATION.txt index 5ebefd608b99..71c26571828a 100644 --- a/doc/driver-model/MIGRATION.txt +++ b/doc/driver-model/MIGRATION.txt @@ -5,6 +5,15 @@ U-Boot has been migrating to a new driver model since its introduction in 2014. This file describes the schedule for deprecation of pre-driver-model features. +CONFIG_DM_MMC +------------- + +Status: In progress +Deadline: 2019.04 + +The subsystem itself has been converted and maintainers should submit patches +switching over to using CONFIG_DM_MMC and other base driver model options in +time for inclusion in the 2019.04 rerelease. CONFIG_BLK ----------
Given that at this point the MMC subsystem itself has been migrated along with a number of subsystem drivers, formalize a deadline for migration. Cc: Simon Glass <sjg@chromium.org> Cc: Jaehoon Chung <jh80.chung@samsung.com> Signed-off-by: Tom Rini <trini@konsulko.com> --- Changes in v2: - Note that failure to migration may lead to removal. --- Makefile | 8 ++++++++ doc/driver-model/MIGRATION.txt | 9 +++++++++ 2 files changed, 17 insertions(+)