| Message ID | 20181120131513.20333-1-guillaume.gardet@free.fr |
|---|---|
| State | Accepted |
| Commit | c96d90367a6a229210b8b16681cfe9e5c8aeced1 |
| Delegated to: | Minkyu Kang |
| Headers | show |
| Series | [U-Boot] exynos: imply SYS_THUMB_BUILD | expand |
Hi Guillaume, > This patch allows smaller binaries. > This is needed for and has been tested on Arndale board, as > u-boot.bin is now bigger than the 512K load limit, with GCC8, without > thumb mode. > Acked-by: Lukasz Majewski <lukma@denx.de> > Signed-off-by: Guillaume GARDET <guillaume.gardet@free.fr> > > Cc: Albert Aribaud <albert.u.boot@aribaud.net> > Cc: Minkyu Kang <mk7.kang@samsung.com> > Cc: Tom Rini <trini@konsulko.com> > --- > arch/arm/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > index f5d4d39683..1ccd53fd0b 100644 > --- a/arch/arm/Kconfig > +++ b/arch/arm/Kconfig > @@ -607,6 +607,7 @@ config ARCH_EXYNOS > select DM_SPI > select DM_SPI_FLASH > select SPI > + imply SYS_THUMB_BUILD > imply CMD_DM > imply FAT_WRITE > Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
Hi, not sure through which tree it should go and who should take care of it? Guillaume ----- Lukasz Majewski <lukma@denx.de> a écrit : > Hi Guillaume, > > > This patch allows smaller binaries. > > This is needed for and has been tested on Arndale board, as > > u-boot.bin is now bigger than the 512K load limit, with GCC8, without > > thumb mode. > > > > Acked-by: Lukasz Majewski <lukma@denx.de> > > > Signed-off-by: Guillaume GARDET <guillaume.gardet@free.fr> > > > > Cc: Albert Aribaud <albert.u.boot@aribaud.net> > > Cc: Minkyu Kang <mk7.kang@samsung.com> > > Cc: Tom Rini <trini@konsulko.com> > > --- > > arch/arm/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > > index f5d4d39683..1ccd53fd0b 100644 > > --- a/arch/arm/Kconfig > > +++ b/arch/arm/Kconfig > > @@ -607,6 +607,7 @@ config ARCH_EXYNOS > > select DM_SPI > > select DM_SPI_FLASH > > select SPI > > + imply SYS_THUMB_BUILD > > imply CMD_DM > > imply FAT_WRITE > > > > > > > Best regards, > > Lukasz Majewski > > -- > > DENX Software Engineering GmbH, Managing Director: Wolfgang Denk > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
On Mon, Dec 03, 2018 at 08:57:21PM +0100, Guillaume GARDET wrote: > > Hi, > > not sure through which tree it should go and who should take care of it? I will likely pick this up "soon" if I don't seen an overall Samsung PR, thanks! > > Guillaume > > ----- Lukasz Majewski <lukma@denx.de> a écrit : > > Hi Guillaume, > > > > > This patch allows smaller binaries. > > > This is needed for and has been tested on Arndale board, as > > > u-boot.bin is now bigger than the 512K load limit, with GCC8, without > > > thumb mode. > > > > > > > Acked-by: Lukasz Majewski <lukma@denx.de> > > > > > Signed-off-by: Guillaume GARDET <guillaume.gardet@free.fr> > > > > > > Cc: Albert Aribaud <albert.u.boot@aribaud.net> > > > Cc: Minkyu Kang <mk7.kang@samsung.com> > > > Cc: Tom Rini <trini@konsulko.com> > > > --- > > > arch/arm/Kconfig | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > > > index f5d4d39683..1ccd53fd0b 100644 > > > --- a/arch/arm/Kconfig > > > +++ b/arch/arm/Kconfig > > > @@ -607,6 +607,7 @@ config ARCH_EXYNOS > > > select DM_SPI > > > select DM_SPI_FLASH > > > select SPI > > > + imply SYS_THUMB_BUILD > > > imply CMD_DM > > > imply FAT_WRITE > > > > > > > > > > > > > Best regards, > > > > Lukasz Majewski > > > > -- > > > > DENX Software Engineering GmbH, Managing Director: Wolfgang Denk > > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > > Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de >
Hi Guillaume, > Hi, > > not sure through which tree it should go and who should take care of > it? Please rebase on top of u-boot/master branch. Then Minkyu will take the patch to his tree. > > Guillaume > > ----- Lukasz Majewski <lukma@denx.de> a écrit : > > Hi Guillaume, > > > > > This patch allows smaller binaries. > > > This is needed for and has been tested on Arndale board, as > > > u-boot.bin is now bigger than the 512K load limit, with GCC8, > > > without thumb mode. > > > > > > > Acked-by: Lukasz Majewski <lukma@denx.de> > > > > > Signed-off-by: Guillaume GARDET <guillaume.gardet@free.fr> > > > > > > Cc: Albert Aribaud <albert.u.boot@aribaud.net> > > > Cc: Minkyu Kang <mk7.kang@samsung.com> > > > Cc: Tom Rini <trini@konsulko.com> > > > --- > > > arch/arm/Kconfig | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > > > index f5d4d39683..1ccd53fd0b 100644 > > > --- a/arch/arm/Kconfig > > > +++ b/arch/arm/Kconfig > > > @@ -607,6 +607,7 @@ config ARCH_EXYNOS > > > select DM_SPI > > > select DM_SPI_FLASH > > > select SPI > > > + imply SYS_THUMB_BUILD > > > imply CMD_DM > > > imply FAT_WRITE > > > > > > > > > > > > > Best regards, > > > > Lukasz Majewski > > > > -- > > > > DENX Software Engineering GmbH, Managing Director: Wolfgang > > Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, > > Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: > > lukma@denx.de > Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
Dear Tom, On 04/12/18 05:23, Tom Rini wrote: > On Mon, Dec 03, 2018 at 08:57:21PM +0100, Guillaume GARDET wrote: > >> >> Hi, >> >> not sure through which tree it should go and who should take care of it? > > I will likely pick this up "soon" if I don't seen an overall Samsung PR, > thanks! > It's OK to take this patch by you. Acked-by: Minkyu Kang <mk7.kang@samsung.com> Thanks, Minkyu Kang.
----- Lukasz Majewski <lukma@denx.de> a écrit : > Hi Guillaume, > > > Hi, > > > > not sure through which tree it should go and who should take care of > > it? > > Please rebase on top of u-boot/master branch. No need, it applies just fine. > > Then Minkyu will take the patch to his tree. Tom should take it (see Minkyu e-mail). Thanks, Guillaume > > > > > Guillaume > > > > ----- Lukasz Majewski <lukma@denx.de> a écrit : > > > Hi Guillaume, > > > > > > > This patch allows smaller binaries. > > > > This is needed for and has been tested on Arndale board, as > > > > u-boot.bin is now bigger than the 512K load limit, with GCC8, > > > > without thumb mode. > > > > > > > > > > Acked-by: Lukasz Majewski <lukma@denx.de> > > > > > > > Signed-off-by: Guillaume GARDET <guillaume.gardet@free.fr> > > > > > > > > Cc: Albert Aribaud <albert.u.boot@aribaud.net> > > > > Cc: Minkyu Kang <mk7.kang@samsung.com> > > > > Cc: Tom Rini <trini@konsulko.com> > > > > --- > > > > arch/arm/Kconfig | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > > > > index f5d4d39683..1ccd53fd0b 100644 > > > > --- a/arch/arm/Kconfig > > > > +++ b/arch/arm/Kconfig > > > > @@ -607,6 +607,7 @@ config ARCH_EXYNOS > > > > select DM_SPI > > > > select DM_SPI_FLASH > > > > select SPI > > > > + imply SYS_THUMB_BUILD > > > > imply CMD_DM > > > > imply FAT_WRITE > > > > > > > > > > > > > > > > > > > Best regards, > > > > > > Lukasz Majewski > > > > > > -- > > > > > > DENX Software Engineering GmbH, Managing Director: Wolfgang > > > Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, > > > Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: > > > lukma@denx.de > > > > > > > Best regards, > > Lukasz Majewski > > -- > > DENX Software Engineering GmbH, Managing Director: Wolfgang Denk > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
Hi Tom, Le 04/12/2018 à 05:47, Minkyu Kang a écrit : > Dear Tom, > > On 04/12/18 05:23, Tom Rini wrote: >> On Mon, Dec 03, 2018 at 08:57:21PM +0100, Guillaume GARDET wrote: >> >>> Hi, >>> >>> not sure through which tree it should go and who should take care of it? >> I will likely pick this up "soon" if I don't seen an overall Samsung PR, >> thanks! >> > It's OK to take this patch by you. > > Acked-by: Minkyu Kang <mk7.kang@samsung.com> It seems you missed it for -rc2. Could you take it before the release, please? Thanks, Guillaume > > Thanks, > Minkyu Kang. >
Hi, On 21/12/18 22:57, Guillaume Gardet wrote: > Hi Tom, > > Le 04/12/2018 à 05:47, Minkyu Kang a écrit : >> Dear Tom, >> >> On 04/12/18 05:23, Tom Rini wrote: >>> On Mon, Dec 03, 2018 at 08:57:21PM +0100, Guillaume GARDET wrote: >>> >>>> Hi, >>>> >>>> not sure through which tree it should go and who should take care of it? >>> I will likely pick this up "soon" if I don't seen an overall Samsung PR, >>> thanks! >>> >> It's OK to take this patch by you. >> >> Acked-by: Minkyu Kang <mk7.kang@samsung.com> > > > It seems you missed it for -rc2. Could you take it before the release, please? > applied to u-boot-samsung. Thanks, Minkyu Kang.
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index f5d4d39683..1ccd53fd0b 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -607,6 +607,7 @@ config ARCH_EXYNOS select DM_SPI select DM_SPI_FLASH select SPI + imply SYS_THUMB_BUILD imply CMD_DM imply FAT_WRITE
This patch allows smaller binaries. This is needed for and has been tested on Arndale board, as u-boot.bin is now bigger than the 512K load limit, with GCC8, without thumb mode. Signed-off-by: Guillaume GARDET <guillaume.gardet@free.fr> Cc: Albert Aribaud <albert.u.boot@aribaud.net> Cc: Minkyu Kang <mk7.kang@samsung.com> Cc: Tom Rini <trini@konsulko.com> --- arch/arm/Kconfig | 1 + 1 file changed, 1 insertion(+)