| Message ID | 20181120085526.35281-2-wen.he_1@nxp.com |
|---|---|
| State | Changes Requested |
| Delegated to: | York Sun |
| Headers | show |
| Series | [U-Boot,1/2] armv8: ls1043ardb: Add the nand_bootcmd definition | expand |
On 11/20/18 12:55 AM, Wen He wrote: > Fix the kernel offset of qspi_bootcmd scripts, followed > the qoriq_memory_layout definition. > > Signed-off-by: Wen He <wen.he_1@nxp.com> > --- > include/configs/ls1043a_common.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/configs/ls1043a_common.h b/include/configs/ls1043a_common.h > index 795e904..7b2f31c 100644 > --- a/include/configs/ls1043a_common.h > +++ b/include/configs/ls1043a_common.h > @@ -302,8 +302,8 @@ > "source ${scriptaddr}\0" \ > "qspi_bootcmd=echo Trying load from qspi..;" \ > "sf probe && sf read $load_addr " \ > - "$kernel_addr $kernel_size; env exists secureboot " \ > - "&& sf read $kernelheader_addr_r $kernelheader_addr " \ > + "$kernel_start $kernel_size; env exists secureboot " \ > + "&& sf read $kernelheader_addr_r $kernelheader_start " \ > "$kernelheader_size && esbc_validate ${kernelheader_addr_r}; " \ > "bootm $load_addr#$board\0" \ > "nor_bootcmd=echo Trying load from nor..;" \ > Why do you need to copy the images from QSPI flash? It is directly readable. It has been this way and it is not your fault. Can you fix it? York
> -----Original Message----- > From: York Sun > Sent: 2018年11月21日 0:58 > To: Wen He <wen.he_1@nxp.com>; u-boot@lists.denx.de > Cc: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>; Alison Wang > <alison.wang@nxp.com> > Subject: Re: [PATCH 2/2] armv8: ls1043aqds: modify the qspi_bootcmd > definition > > On 11/20/18 12:55 AM, Wen He wrote: > > Fix the kernel offset of qspi_bootcmd scripts, followed the > > qoriq_memory_layout definition. > > > > Signed-off-by: Wen He <wen.he_1@nxp.com> > > --- > > include/configs/ls1043a_common.h | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/include/configs/ls1043a_common.h > > b/include/configs/ls1043a_common.h > > index 795e904..7b2f31c 100644 > > --- a/include/configs/ls1043a_common.h > > +++ b/include/configs/ls1043a_common.h > > @@ -302,8 +302,8 @@ > > "source ${scriptaddr}\0" \ > > "qspi_bootcmd=echo Trying load from qspi..;" \ > > "sf probe && sf read $load_addr " \ > > - "$kernel_addr $kernel_size; env exists secureboot " \ > > - "&& sf read $kernelheader_addr_r $kernelheader_addr " \ > > + "$kernel_start $kernel_size; env exists secureboot " \ > > + "&& sf read $kernelheader_addr_r $kernelheader_start " \ > > "$kernelheader_size && esbc_validate ${kernelheader_addr_r}; " \ > > "bootm $load_addr#$board\0" \ > > "nor_bootcmd=echo Trying load from nor..;" \ > > > > Why do you need to copy the images from QSPI flash? It is directly readable. It > has been this way and it is not your fault. Can you fix it? > For now, we only supported DDR loading that need copy the images from QSPI/NAND/SD/NOR flash. Will add support directly readable from QSPI and NOR flash in next LSDK. Best Regards, Wen > York
diff --git a/include/configs/ls1043a_common.h b/include/configs/ls1043a_common.h index 795e904..7b2f31c 100644 --- a/include/configs/ls1043a_common.h +++ b/include/configs/ls1043a_common.h @@ -302,8 +302,8 @@ "source ${scriptaddr}\0" \ "qspi_bootcmd=echo Trying load from qspi..;" \ "sf probe && sf read $load_addr " \ - "$kernel_addr $kernel_size; env exists secureboot " \ - "&& sf read $kernelheader_addr_r $kernelheader_addr " \ + "$kernel_start $kernel_size; env exists secureboot " \ + "&& sf read $kernelheader_addr_r $kernelheader_start " \ "$kernelheader_size && esbc_validate ${kernelheader_addr_r}; " \ "bootm $load_addr#$board\0" \ "nor_bootcmd=echo Trying load from nor..;" \
Fix the kernel offset of qspi_bootcmd scripts, followed the qoriq_memory_layout definition. Signed-off-by: Wen He <wen.he_1@nxp.com> --- include/configs/ls1043a_common.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)