mbox series

[U-Boot,v12,0/6] efi_loader: Code refactoring and improvement

Message ID 20181106225744.139945-1-sjg@chromium.org
Headers show
Series efi_loader: Code refactoring and improvement | expand

Message

Simon Glass Nov. 6, 2018, 10:57 p.m. UTC 
This collects the patches previously sent to break up the very large
functions in efi_loader into smaller pieces. Now that the other sandbox
stuff is applied, perhaps it is time to apply these patches.

This also adds a few new patches to fix more recent breakages.
Unfortunately we still cannot enable the efi loader tests since one of
the tests fails. Thus we should expect additional failures to appear
until that is resolved.

Changes in v12:
- Rename image to image_prot
- Update CPU nodes to comply with the DT spec

Changes in v11:
- Add a new patch to drop setup_ok
- Add a new patch to put CPUs under a cpu-bus node
- Drop patches previously applied
- Fix the EFI code that has since been added and relies on broken behaviour

Changes in v9:
- Add comments to bootefi_test_prepare() about the memset()s

Changes in v7:
- Drop patch "efi: Init the 'rows' and 'cols' variables"
- Drop patches previous applied

Changes in v5:
- Drop call to efi_init_obj_list() which is now done in do_bootefi()
- Introduce load_options_path to specifyc U-Boot env var for load_options_path
- Rebase to master

Changes in v4:
- Rebase to master

Changes in v3:
- Add new patch to rename bootefi_test_finish() to bootefi_run_finish()
- Add new patch to split out test init/uninit into functions
- Add patch to create a function to set up for running EFI code
- Drop incorrect map_sysmem() in write_smbios_table()

Simon Glass (6):
  sandbox: Put CPUs under a cpu-bus node
  efi_loader: Drop setup_ok
  sandbox: smbios: Update to support sandbox
  efi: Split out test init/uninit into functions
  efi: Create a function to set up for running EFI code
  efi: Rename bootefi_test_finish() to bootefi_run_finish()

 arch/sandbox/dts/test.dts       |  38 +++++++--
 cmd/bootefi.c                   | 135 ++++++++++++++++++++++----------
 include/efi_selftest.h          |   2 -
 lib/efi_loader/efi_smbios.c     |  20 +++--
 lib/efi_selftest/efi_selftest.c |  14 ++--
 lib/smbios.c                    |  32 ++++++--
 6 files changed, 169 insertions(+), 72 deletions(-)

Comments

Simon Glass Nov. 13, 2018, 7:53 p.m. UTC | #1 
Hi,

On 6 November 2018 at 14:57, Simon Glass <sjg@chromium.org> wrote:
> This collects the patches previously sent to break up the very large
> functions in efi_loader into smaller pieces. Now that the other sandbox
> stuff is applied, perhaps it is time to apply these patches.
>
> This also adds a few new patches to fix more recent breakages.
> Unfortunately we still cannot enable the efi loader tests since one of
> the tests fails. Thus we should expect additional failures to appear
> until that is resolved.
>
> Changes in v12:
> - Rename image to image_prot
> - Update CPU nodes to comply with the DT spec

Any comments / reviews on this please?

Regards,
Simon