mbox series

[v4,0/2,SRU,Bionic] Dell AIO UART backlight driver

Message ID 20180920084115.1895-1-acelan.kao@canonical.com
Headers show
Series Dell AIO UART backlight driver | expand

Message

AceLan Kao Sept. 20, 2018, 8:41 a.m. UTC 
BugLink: https://bugs.launchpad.net/bugs/1727235

[Impact]
New Dell AIO platforms requires a driver that can communicate with the
scalar IC FW through UART interface to get and set the brightness level.

[Test]
Verified on some new Dell AIO machines and confirmed it works.

[Fix]
Write a new driver to handle this task.

[Regression Potential]
Low, it's a new driver for new interface.

[Misc]
Upstream maintainer ask use to re-implement this driver by the new
interface, serdev, but serdev seems doesn't work with ACPI, so submit
this driver as Ubuntu sauce patch for now. I'll try re-write it when I'm
available.

AceLan Kao (2):
  UBUNTU: SAUCE: platform/x86: dell-uart-backlight: new backlight driver
    for DELL AIO
  UBUNTU: updateconfigs for Dell UART backlight driver

 debian.master/config/config.common.ubuntu  |   1 +
 drivers/platform/x86/Kconfig               |  14 +
 drivers/platform/x86/Makefile              |   1 +
 drivers/platform/x86/dell-uart-backlight.c | 471 +++++++++++++++++++++
 drivers/platform/x86/dell-uart-backlight.h |  36 ++
 5 files changed, 523 insertions(+)
 create mode 100644 drivers/platform/x86/dell-uart-backlight.c
 create mode 100644 drivers/platform/x86/dell-uart-backlight.h

Comments

Colin Ian King Sept. 23, 2018, 9:56 a.m. UTC | #1 
On 20/09/18 10:41, AceLan Kao wrote:
> BugLink: https://bugs.launchpad.net/bugs/1727235
> 
> [Impact]
> New Dell AIO platforms requires a driver that can communicate with the
> scalar IC FW through UART interface to get and set the brightness level.
> 
> [Test]
> Verified on some new Dell AIO machines and confirmed it works.
> 
> [Fix]
> Write a new driver to handle this task.
> 
> [Regression Potential]
> Low, it's a new driver for new interface.
> 
> [Misc]
> Upstream maintainer ask use to re-implement this driver by the new
> interface, serdev, but serdev seems doesn't work with ACPI, so submit
> this driver as Ubuntu sauce patch for now. I'll try re-write it when I'm
> available.
> 
> AceLan Kao (2):
>   UBUNTU: SAUCE: platform/x86: dell-uart-backlight: new backlight driver
>     for DELL AIO
>   UBUNTU: updateconfigs for Dell UART backlight driver
> 
>  debian.master/config/config.common.ubuntu  |   1 +
>  drivers/platform/x86/Kconfig               |  14 +
>  drivers/platform/x86/Makefile              |   1 +
>  drivers/platform/x86/dell-uart-backlight.c | 471 +++++++++++++++++++++
>  drivers/platform/x86/dell-uart-backlight.h |  36 ++
>  5 files changed, 523 insertions(+)
>  create mode 100644 drivers/platform/x86/dell-uart-backlight.c
>  create mode 100644 drivers/platform/x86/dell-uart-backlight.h
> 

Thanks AceLan, looks good to me.

Acked-by: Colin Ian King <colin.king@canonical.com>
Stefan Bader Sept. 27, 2018, 4:36 p.m. UTC | #2 
On 20.09.2018 10:41, AceLan Kao wrote:
> BugLink: https://bugs.launchpad.net/bugs/1727235
> 
> [Impact]
> New Dell AIO platforms requires a driver that can communicate with the
> scalar IC FW through UART interface to get and set the brightness level.
> 
> [Test]
> Verified on some new Dell AIO machines and confirmed it works.
> 
> [Fix]
> Write a new driver to handle this task.
> 
> [Regression Potential]
> Low, it's a new driver for new interface.
> 
> [Misc]
> Upstream maintainer ask use to re-implement this driver by the new
> interface, serdev, but serdev seems doesn't work with ACPI, so submit
> this driver as Ubuntu sauce patch for now. I'll try re-write it when I'm
> available.
> 
> AceLan Kao (2):
>   UBUNTU: SAUCE: platform/x86: dell-uart-backlight: new backlight driver
>     for DELL AIO
>   UBUNTU: updateconfigs for Dell UART backlight driver
> 
>  debian.master/config/config.common.ubuntu  |   1 +
>  drivers/platform/x86/Kconfig               |  14 +
>  drivers/platform/x86/Makefile              |   1 +
>  drivers/platform/x86/dell-uart-backlight.c | 471 +++++++++++++++++++++
>  drivers/platform/x86/dell-uart-backlight.h |  36 ++
>  5 files changed, 523 insertions(+)
>  create mode 100644 drivers/platform/x86/dell-uart-backlight.c
>  create mode 100644 drivers/platform/x86/dell-uart-backlight.h
> 
Acked-by: Stefan Bader <stefan.bader@canonical.com>
Stefan Bader Oct. 1, 2018, 2:59 p.m. UTC | #3 
On 20.09.2018 10:41, AceLan Kao wrote:
> BugLink: https://bugs.launchpad.net/bugs/1727235
> 
> [Impact]
> New Dell AIO platforms requires a driver that can communicate with the
> scalar IC FW through UART interface to get and set the brightness level.
> 
> [Test]
> Verified on some new Dell AIO machines and confirmed it works.
> 
> [Fix]
> Write a new driver to handle this task.
> 
> [Regression Potential]
> Low, it's a new driver for new interface.
> 
> [Misc]
> Upstream maintainer ask use to re-implement this driver by the new
> interface, serdev, but serdev seems doesn't work with ACPI, so submit
> this driver as Ubuntu sauce patch for now. I'll try re-write it when I'm
> available.
> 
> AceLan Kao (2):
>   UBUNTU: SAUCE: platform/x86: dell-uart-backlight: new backlight driver
>     for DELL AIO
>   UBUNTU: updateconfigs for Dell UART backlight driver
> 
>  debian.master/config/config.common.ubuntu  |   1 +
>  drivers/platform/x86/Kconfig               |  14 +
>  drivers/platform/x86/Makefile              |   1 +
>  drivers/platform/x86/dell-uart-backlight.c | 471 +++++++++++++++++++++
>  drivers/platform/x86/dell-uart-backlight.h |  36 ++
>  5 files changed, 523 insertions(+)
>  create mode 100644 drivers/platform/x86/dell-uart-backlight.c
>  create mode 100644 drivers/platform/x86/dell-uart-backlight.h
> 
Applied to bionic/master-next. Thanks.

-Stefan
Seth Forshee Oct. 2, 2018, 2:20 p.m. UTC | #4 
On Thu, Sep 20, 2018 at 04:41:13PM +0800, AceLan Kao wrote:
> BugLink: https://bugs.launchpad.net/bugs/1727235
> 
> [Impact]
> New Dell AIO platforms requires a driver that can communicate with the
> scalar IC FW through UART interface to get and set the brightness level.
> 
> [Test]
> Verified on some new Dell AIO machines and confirmed it works.
> 
> [Fix]
> Write a new driver to handle this task.
> 
> [Regression Potential]
> Low, it's a new driver for new interface.
> 
> [Misc]
> Upstream maintainer ask use to re-implement this driver by the new
> interface, serdev, but serdev seems doesn't work with ACPI, so submit
> this driver as Ubuntu sauce patch for now. I'll try re-write it when I'm
> available.

I assume this will also be wanted in cosmic?
Seth Forshee Oct. 4, 2018, 4:19 p.m. UTC | #5 
On Thu, Sep 20, 2018 at 04:41:13PM +0800, AceLan Kao wrote:
> BugLink: https://bugs.launchpad.net/bugs/1727235
> 
> [Impact]
> New Dell AIO platforms requires a driver that can communicate with the
> scalar IC FW through UART interface to get and set the brightness level.
> 
> [Test]
> Verified on some new Dell AIO machines and confirmed it works.
> 
> [Fix]
> Write a new driver to handle this task.
> 
> [Regression Potential]
> Low, it's a new driver for new interface.
> 
> [Misc]
> Upstream maintainer ask use to re-implement this driver by the new
> interface, serdev, but serdev seems doesn't work with ACPI, so submit
> this driver as Ubuntu sauce patch for now. I'll try re-write it when I'm
> available.

Applied to cosmic/master-next, with trivial conflict resolution. Thanks!