mbox series

[v08,0/5] powerpc/hotplug: Update affinity for migrated CPUs

Message ID 9573dc30-01ad-2650-c247-28df08875cef@linux.vnet.ibm.com (mailing list archive)
Headers show
Series powerpc/hotplug: Update affinity for migrated CPUs | expand

Message

Michael Bringmann July 29, 2018, 1:18 p.m. UTC
The migration of LPARs across Power systems affects many attributes
including that of the associativity of CPUs.  The patches in this
set execute when a system is coming up fresh upon a migration target.
They are intended to,

* Recognize changes to the associativity of CPUs recorded in internal
  data structures when compared to the latest copies in the device tree.
* Generate calls to other code layers to reset the data structures
  related to associativity of the CPUs.
* Re-register the 'changed' entities into the target system.
  Re-registration of CPUs mostly entails acting as if they have been
  newly hot-added into the target system.

Signed-off-by: Michael Bringmann <mwb@linux.vnet.ibm.com>

Michael Bringmann (9):
  hotplug/cpu: Conditionally acquire/release DRC index
  hotplug/cpu: Add operation queuing function
  hotplug/cpu: Provide CPU readd operation
  mobility/numa: Ensure numa update does not overlap
  numa: Disable/enable arch_update_cpu_topology
  pmt/numa: Disable arch_update_cpu_topology during CPU readd
  powerpc/rtas: Allow disabling rtas_event_scan
  hotplug/rtas: No rtas_event_scan during PMT update
  hotplug/pmt: Update topology after PMT
---
Changes in patch:
  -- Restructure and rearrange content of patches to co-locate
     similar or related modifications
  -- Rename pseries_update_drconf_cpu to pseries_update_processor
  -- Simplify code to update CPU nodes during mobility checks.
     Remove functions to generate extra HP_ELOG messages in favor
     of direct function calls to dlpar_cpu_readd_by_index.
  -- Revise code order in dlpar_cpu_readd_by_index() to present
     more appropriate error codes from underlying layers of the
     implementation.
  -- Add hotplug device lock around all property updates
  -- Add call to rebuild_sched_domains in case of changes
  -- Various code cleanups and compaction
  -- Rebase to 4.18 kernel
  -- Change operation to run CPU readd after end of migration store.
  -- Improve descriptive text
  -- Cleanup patch reference to outdated function
  -- Code cleanup a 'acquire_drc' check in dlpar_cpu_add.
  -- Code cleanup a 'release_drc' check in dlpar_cpu_remove.
  -- Add more information to patch descriptions.
  -- More code cleanup
  -- Rearrange call to rebuild_sched_domains to allow removal
     of some locking code.

Comments

Michal Suchánek Oct. 29, 2018, 7:51 p.m. UTC | #1
On Sun, 29 Jul 2018 08:18:34 -0500
Michael Bringmann <mwb@linux.vnet.ibm.com> wrote:

> The migration of LPARs across Power systems affects many attributes
> including that of the associativity of CPUs.  The patches in this
> set execute when a system is coming up fresh upon a migration target.
> They are intended to,
> 
> * Recognize changes to the associativity of CPUs recorded in internal
>   data structures when compared to the latest copies in the device
> tree.
> * Generate calls to other code layers to reset the data structures
>   related to associativity of the CPUs.
> * Re-register the 'changed' entities into the target system.
>   Re-registration of CPUs mostly entails acting as if they have been
>   newly hot-added into the target system.
> 
> Signed-off-by: Michael Bringmann <mwb@linux.vnet.ibm.com>
> 
Hello,

what is the status of this patchset other than it no longer applies?

Thanks

Michal
Michael Bringmann Nov. 5, 2018, 5:50 p.m. UTC | #2
On 10/29/2018 02:51 PM, Michal Suchánek wrote:
> On Sun, 29 Jul 2018 08:18:34 -0500
> Michael Bringmann <mwb@linux.vnet.ibm.com> wrote:
> 
>> The migration of LPARs across Power systems affects many attributes
>> including that of the associativity of CPUs.  The patches in this
>> set execute when a system is coming up fresh upon a migration target.
>> They are intended to,
>>
>> * Recognize changes to the associativity of CPUs recorded in internal
>>   data structures when compared to the latest copies in the device
>> tree.
>> * Generate calls to other code layers to reset the data structures
>>   related to associativity of the CPUs.
>> * Re-register the 'changed' entities into the target system.
>>   Re-registration of CPUs mostly entails acting as if they have been
>>   newly hot-added into the target system.
>>
>> Signed-off-by: Michael Bringmann <mwb@linux.vnet.ibm.com>
>>
> Hello,
> 
> what is the status of this patchset other than it no longer applies?

The current PowerPC systems already perform remove_processor /
add_processor operations during migration events that subsume
the necessary affinity changes.  This patchset was overkill,
so we pulled it.

Memory affinity on the other hand does need intervention, and that
patchset has been posted.  I was just about to ping Michael Ellerman
about the status from his end.
 
> 
> Thanks
> 
> Michal

Thanks.
Michael