mbox series

[SRU,Bionic,0/1] s390/zcrypt: Fix CCA and EP11 CPRB processing failure memory leak.

Message ID cover.1528314074.git.joseph.salisbury@canonical.com
Headers show
Series s390/zcrypt: Fix CCA and EP11 CPRB processing failure memory leak. | expand

Message

Joseph Salisbury June 13, 2018, 4:12 p.m. UTC
BugLink: http://bugs.launchpad.net/bugs/1775390

== SRU Justification ==
Description: kernel: Fix memory leak on CCA and EP11 CPRB processing.

Symptom: Kernel memory not freed when CCA or EP11 CPRB processing fails.
Problem: kfree() in code error path missing.

Solution: Slight rework of the malloc and free places.

Reproduction: Run application which sends CCA or EP11 crypto requests
              to the crypto card(s). Now switch the cards offline with
              the help of chzcrypt. Monitor top or free output.

== Fix ==
89a0c0ec0d2e ("s390/zcrypt: Fix CCA and EP11 CPRB processing failure memory leak.")

== Regression Potential ==
Low.  Limited to s390.

== Test Case ==
Verified upfront by IBM during upstream integration.

Harald Freudenberger (1):
  s390/zcrypt: Fix CCA and EP11 CPRB processing failure memory leak.

 drivers/s390/crypto/ap_bus.h          | 17 ++++++++----
 drivers/s390/crypto/zcrypt_api.c      | 15 ++++++++---
 drivers/s390/crypto/zcrypt_msgtype6.c | 51 +++++++++++++----------------------
 3 files changed, 43 insertions(+), 40 deletions(-)

Comments

Khalid Elmously June 18, 2018, 5:45 p.m. UTC | #1
On 2018-06-13 12:12:58 , Joseph Salisbury wrote:
> BugLink: http://bugs.launchpad.net/bugs/1775390
> 
> == SRU Justification ==
> Description: kernel: Fix memory leak on CCA and EP11 CPRB processing.
> 
> Symptom: Kernel memory not freed when CCA or EP11 CPRB processing fails.
> Problem: kfree() in code error path missing.
> 
> Solution: Slight rework of the malloc and free places.
> 
> Reproduction: Run application which sends CCA or EP11 crypto requests
>               to the crypto card(s). Now switch the cards offline with
>               the help of chzcrypt. Monitor top or free output.
> 
> == Fix ==
> 89a0c0ec0d2e ("s390/zcrypt: Fix CCA and EP11 CPRB processing failure memory leak.")
> 
> == Regression Potential ==
> Low.  Limited to s390.
> 
> == Test Case ==
> Verified upfront by IBM during upstream integration.
> 
> Harald Freudenberger (1):
>   s390/zcrypt: Fix CCA and EP11 CPRB processing failure memory leak.
> 
>  drivers/s390/crypto/ap_bus.h          | 17 ++++++++----
>  drivers/s390/crypto/zcrypt_api.c      | 15 ++++++++---
>  drivers/s390/crypto/zcrypt_msgtype6.c | 51 +++++++++++++----------------------
>  3 files changed, 43 insertions(+), 40 deletions(-)
> 

Acked-by: Khalid Elmously <khalid.elmously@canonical.com>
Khalid Elmously June 19, 2018, 6:18 p.m. UTC | #2
Applied to Bionic


On 2018-06-13 12:12:58 , Joseph Salisbury wrote:
> BugLink: http://bugs.launchpad.net/bugs/1775390
> 
> == SRU Justification ==
> Description: kernel: Fix memory leak on CCA and EP11 CPRB processing.
> 
> Symptom: Kernel memory not freed when CCA or EP11 CPRB processing fails.
> Problem: kfree() in code error path missing.
> 
> Solution: Slight rework of the malloc and free places.
> 
> Reproduction: Run application which sends CCA or EP11 crypto requests
>               to the crypto card(s). Now switch the cards offline with
>               the help of chzcrypt. Monitor top or free output.
> 
> == Fix ==
> 89a0c0ec0d2e ("s390/zcrypt: Fix CCA and EP11 CPRB processing failure memory leak.")
> 
> == Regression Potential ==
> Low.  Limited to s390.
> 
> == Test Case ==
> Verified upfront by IBM during upstream integration.
> 
> Harald Freudenberger (1):
>   s390/zcrypt: Fix CCA and EP11 CPRB processing failure memory leak.
> 
>  drivers/s390/crypto/ap_bus.h          | 17 ++++++++----
>  drivers/s390/crypto/zcrypt_api.c      | 15 ++++++++---
>  drivers/s390/crypto/zcrypt_msgtype6.c | 51 +++++++++++++----------------------
>  3 files changed, 43 insertions(+), 40 deletions(-)
> 
> -- 
> 2.7.4
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team