mbox series

[SRU,Artful,0/2] Fixes for LP:1769027

Message ID cover.1526061932.git.joseph.salisbury@canonical.com
Headers show
Series Fixes for LP:1769027 | expand

Message

Joseph Salisbury May 11, 2018, 6:20 p.m. UTC
== SRU Justification ==
This SRU request is for two commits, that are needed for two bug reports.  The
first bug(1767204) is marked as a duplicate of the bug used for this SRU
request.  The commit(3d8bba9535ac) required to fix the first bug introduced the second
bug.  The second bug is then fixed buy commit cd8dd032f61a.

The first issue is perf crashes due to swapped xyarray function signatures and is
fixed by commit 3d8bba9535ac.

The second issue is a crash due to "refcount_inc assertion failed".
This second bug is introduced by picking commit 3d8bba9535ac without
picking commit cd8dd032f61a first.


== Fixes ==
cd8dd032f61a ("perf cgroup: Fix refcount usage") 
3d8bba9535ac ("perf xyarray: Fix wrong processing when closing evsel fd")

== Regression Potential ==
Low.  Limited to perf tool.

== Test Case ==
A test kernel was built with these patches and tested by the original bug reporter.
The bug reporter states the test kernel resolved the bug.

Arnaldo Carvalho de Melo (1):
  perf cgroup: Fix refcount usage

Jin Yao (1):
  perf xyarray: Fix wrong processing when closing evsel fd

 tools/perf/util/cgroup.c  | 8 +++++---
 tools/perf/util/xyarray.h | 4 ++--
 2 files changed, 7 insertions(+), 5 deletions(-)

Comments

Kleber Sacilotto de Souza May 16, 2018, 12:58 p.m. UTC | #1
On 05/11/18 20:20, Joseph Salisbury wrote:
> == SRU Justification ==
> This SRU request is for two commits, that are needed for two bug reports.  The
> first bug(1767204) is marked as a duplicate of the bug used for this SRU
> request.  The commit(3d8bba9535ac) required to fix the first bug introduced the second
> bug.  The second bug is then fixed buy commit cd8dd032f61a.
> 
> The first issue is perf crashes due to swapped xyarray function signatures and is
> fixed by commit 3d8bba9535ac.
> 
> The second issue is a crash due to "refcount_inc assertion failed".
> This second bug is introduced by picking commit 3d8bba9535ac without
> picking commit cd8dd032f61a first.
> 
> 
> == Fixes ==
> cd8dd032f61a ("perf cgroup: Fix refcount usage") 
> 3d8bba9535ac ("perf xyarray: Fix wrong processing when closing evsel fd")
> 
> == Regression Potential ==
> Low.  Limited to perf tool.
> 
> == Test Case ==
> A test kernel was built with these patches and tested by the original bug reporter.
> The bug reporter states the test kernel resolved the bug.
> 
> Arnaldo Carvalho de Melo (1):
>   perf cgroup: Fix refcount usage
> 
> Jin Yao (1):
>   perf xyarray: Fix wrong processing when closing evsel fd
> 
>  tools/perf/util/cgroup.c  | 8 +++++---
>  tools/perf/util/xyarray.h | 4 ++--
>  2 files changed, 7 insertions(+), 5 deletions(-)
> 

Scope limited to perftools, tested by the bug reporter.

Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
Khalid Elmously May 17, 2018, 2:40 a.m. UTC | #2
On 2018-05-11 14:20:50 , Joseph Salisbury wrote:
> == SRU Justification ==
> This SRU request is for two commits, that are needed for two bug reports.  The
> first bug(1767204) is marked as a duplicate of the bug used for this SRU
> request.  The commit(3d8bba9535ac) required to fix the first bug introduced the second
> bug.  The second bug is then fixed buy commit cd8dd032f61a.
> 
> The first issue is perf crashes due to swapped xyarray function signatures and is
> fixed by commit 3d8bba9535ac.
> 
> The second issue is a crash due to "refcount_inc assertion failed".
> This second bug is introduced by picking commit 3d8bba9535ac without
> picking commit cd8dd032f61a first.
> 
> 
> == Fixes ==
> cd8dd032f61a ("perf cgroup: Fix refcount usage") 
> 3d8bba9535ac ("perf xyarray: Fix wrong processing when closing evsel fd")
> 
> == Regression Potential ==
> Low.  Limited to perf tool.
> 
> == Test Case ==
> A test kernel was built with these patches and tested by the original bug reporter.
> The bug reporter states the test kernel resolved the bug.
> 
> Arnaldo Carvalho de Melo (1):
>   perf cgroup: Fix refcount usage
> 
> Jin Yao (1):
>   perf xyarray: Fix wrong processing when closing evsel fd
> 
>  tools/perf/util/cgroup.c  | 8 +++++---
>  tools/perf/util/xyarray.h | 4 ++--
>  2 files changed, 7 insertions(+), 5 deletions(-)
> 
Acked-by: Khalid Elmously <khalid.elmously@canonical.com>
Khalid Elmously May 17, 2018, 5:59 a.m. UTC | #3
Applied to A

On 2018-05-11 14:20:50 , Joseph Salisbury wrote:
> == SRU Justification ==
> This SRU request is for two commits, that are needed for two bug reports.  The
> first bug(1767204) is marked as a duplicate of the bug used for this SRU
> request.  The commit(3d8bba9535ac) required to fix the first bug introduced the second
> bug.  The second bug is then fixed buy commit cd8dd032f61a.
> 
> The first issue is perf crashes due to swapped xyarray function signatures and is
> fixed by commit 3d8bba9535ac.
> 
> The second issue is a crash due to "refcount_inc assertion failed".
> This second bug is introduced by picking commit 3d8bba9535ac without
> picking commit cd8dd032f61a first.
> 
> 
> == Fixes ==
> cd8dd032f61a ("perf cgroup: Fix refcount usage") 
> 3d8bba9535ac ("perf xyarray: Fix wrong processing when closing evsel fd")
> 
> == Regression Potential ==
> Low.  Limited to perf tool.
> 
> == Test Case ==
> A test kernel was built with these patches and tested by the original bug reporter.
> The bug reporter states the test kernel resolved the bug.
> 
> Arnaldo Carvalho de Melo (1):
>   perf cgroup: Fix refcount usage
> 
> Jin Yao (1):
>   perf xyarray: Fix wrong processing when closing evsel fd
> 
>  tools/perf/util/cgroup.c  | 8 +++++---
>  tools/perf/util/xyarray.h | 4 ++--
>  2 files changed, 7 insertions(+), 5 deletions(-)
> 
> -- 
> 2.7.4
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
Khalid Elmously May 17, 2018, 6:04 a.m. UTC | #4
Adding "APPLIED" to the subject


On 2018-05-11 14:20:50 , Joseph Salisbury wrote:
> == SRU Justification ==
> This SRU request is for two commits, that are needed for two bug reports.  The
> first bug(1767204) is marked as a duplicate of the bug used for this SRU
> request.  The commit(3d8bba9535ac) required to fix the first bug introduced the second
> bug.  The second bug is then fixed buy commit cd8dd032f61a.
> 
> The first issue is perf crashes due to swapped xyarray function signatures and is
> fixed by commit 3d8bba9535ac.
> 
> The second issue is a crash due to "refcount_inc assertion failed".
> This second bug is introduced by picking commit 3d8bba9535ac without
> picking commit cd8dd032f61a first.
> 
> 
> == Fixes ==
> cd8dd032f61a ("perf cgroup: Fix refcount usage") 
> 3d8bba9535ac ("perf xyarray: Fix wrong processing when closing evsel fd")
> 
> == Regression Potential ==
> Low.  Limited to perf tool.
> 
> == Test Case ==
> A test kernel was built with these patches and tested by the original bug reporter.
> The bug reporter states the test kernel resolved the bug.
> 
> Arnaldo Carvalho de Melo (1):
>   perf cgroup: Fix refcount usage
> 
> Jin Yao (1):
>   perf xyarray: Fix wrong processing when closing evsel fd
> 
>  tools/perf/util/cgroup.c  | 8 +++++---
>  tools/perf/util/xyarray.h | 4 ++--
>  2 files changed, 7 insertions(+), 5 deletions(-)
> 
> -- 
> 2.7.4
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team