mbox series

[Xenial,linux-firmware,0/2] adding rtl bt firmware to Xenial

Message ID 1517800717-5716-1-git-send-email-hui.wang@canonical.com
Headers show
Series adding rtl bt firmware to Xenial | expand

Message

Hui Wang Feb. 5, 2018, 3:18 a.m. UTC 
BugLink: https://launchpad.net/bugs/1747336

We have an OEM bug, the BT can't work on that machine, the root cause is the
bt driver can't find the firmware files.

These two firmware files are already in the artful and bionic, only xenial needs them.

[Test Case]
boot the system and connnect the bt devices, all works well

[Fix]
Backport the uptream patch

[Regression Potential]
No

Larry Finger (2):
  rtl_bt: Add firmware and config file for RTL8822BE
  rtl_bt: Update firmware for BT part of rtl8822be

 WHENCE                     |   4 ++++
 rtl_bt/rtl8822b_config.bin | Bin 0 -> 14 bytes
 rtl_bt/rtl8822b_fw.bin     | Bin 0 -> 51176 bytes
 3 files changed, 4 insertions(+)
 create mode 100644 rtl_bt/rtl8822b_config.bin
 create mode 100644 rtl_bt/rtl8822b_fw.bin

Comments

Seth Forshee Feb. 9, 2018, 2:38 p.m. UTC | #1 
On Mon, Feb 05, 2018 at 11:18:35AM +0800, Hui Wang wrote:
> BugLink: https://launchpad.net/bugs/1747336
> 
> We have an OEM bug, the BT can't work on that machine, the root cause is the
> bt driver can't find the firmware files.
> 
> These two firmware files are already in the artful and bionic, only xenial needs them.
> 
> [Test Case]
> boot the system and connnect the bt devices, all works well
> 
> [Fix]
> Backport the uptream patch
> 
> [Regression Potential]
> No

Applied, but a few comments:

 - Rather than just saying "No" for the regression potential, it would
   be better to say something about these being new files and so they
   will have no impact on already working devices.

 - You need to add the SRU justification to the bug report.

 - In the future please be sure that you add "BugLink:" before the links
   to the bugs in the commit messages. I have fixed this for you when
   applying the patches.

With the bug links fixed, applied to linux-firmware/xenial. Thanks!
Hui Wang Feb. 11, 2018, 8:58 a.m. UTC | #2 
On 2018年02月09日 22:38, Seth Forshee wrote:
> On Mon, Feb 05, 2018 at 11:18:35AM +0800, Hui Wang wrote:
>> BugLink: https://launchpad.net/bugs/1747336
>>
>> We have an OEM bug, the BT can't work on that machine, the root cause is the
>> bt driver can't find the firmware files.
>>
>> These two firmware files are already in the artful and bionic, only xenial needs them.
>>
>> [Test Case]
>> boot the system and connnect the bt devices, all works well
>>
>> [Fix]
>> Backport the uptream patch
>>
>> [Regression Potential]
>> No
> Applied, but a few comments:
>
>   - Rather than just saying "No" for the regression potential, it would
>     be better to say something about these being new files and so they
>     will have no impact on already working devices.
>
>   - You need to add the SRU justification to the bug report.
>
>   - In the future please be sure that you add "BugLink:" before the links
>     to the bugs in the commit messages. I have fixed this for you when
>     applying the patches.
>
> With the bug links fixed, applied to linux-firmware/xenial. Thanks!
Got it. Thanks.