| Message ID | 20171016155026.5588-1-aaron.ma@canonical.com |
|---|---|
| Headers | show |
| Series | Enable synaptics touchpad intertouch support on | expand |
On 2017年10月16日 23:50, Aaron Ma wrote: > BugLink: http://bugs.launchpad.net/bugs/1723986 > > [Impact] > Synaptics touchpad/trackpoint fail to work on Lenovo X1C5/6 and X280. > And they report they support intertouch mode through SMBus ver 3. > Current kernel driver limits RMI4 to SMBus 2. > > [Fix] > Enable SMBus ver 3 and set them to SMBus mode will make synaptics work > fine. > > [Test Case] > Tested on X1C5/6 and X280, confirm patches work fine. > > [Regression Potential] > Enable RMI4 support on specific device ID, no regression is supposed. > > Zesty and Xenial do not support this intertouch mode, so no need these > patches. > > Aaron Ma (1): > UBUNTU: SAUCE: Input: synaptics - add Intertouch support on X1 Carbon > 6th and X280 > > Yiannis Marangos (2): > UBUNTU: SAUCE: Input: synaptics-rmi4 - RMI4 can also use SMBUS version > 3 > UBUNTU: SAUCE: Input: synaptics - Lenovo X1 Carbon 5 should use > SMBUS/RMI > > drivers/input/mouse/synaptics.c | 3 +++ > drivers/input/rmi4/rmi_smbus.c | 4 ++-- > 2 files changed, 5 insertions(+), 2 deletions(-) > Looks fine. And if we really don't have time to wait for these patches being merged to upstream first, I give Ack here. Acked-by: Hui Wang<hui.wang@canonical.com>
Pretty simple and straightforward, should have no regression concern.
Acked-By: AceLan Kao <acelan.kao@canonical.com>
On Mon, Oct 16, 2017 at 11:50:23PM +0800, Aaron Ma wrote: > BugLink: http://bugs.launchpad.net/bugs/1723986 > > [Impact] > Synaptics touchpad/trackpoint fail to work on Lenovo X1C5/6 and X280. > And they report they support intertouch mode through SMBus ver 3. > Current kernel driver limits RMI4 to SMBus 2. > > [Fix] > Enable SMBus ver 3 and set them to SMBus mode will make synaptics work > fine. > > [Test Case] > Tested on X1C5/6 and X280, confirm patches work fine. > > [Regression Potential] > Enable RMI4 support on specific device ID, no regression is supposed. > > Zesty and Xenial do not support this intertouch mode, so no need these > patches. Have these been regression tested on other hardware which uses this driver?
On 10/18/2017 10:22 PM, Seth Forshee wrote: > On Mon, Oct 16, 2017 at 11:50:23PM +0800, Aaron Ma wrote: >> BugLink: http://bugs.launchpad.net/bugs/1723986 >> >> [Impact] >> Synaptics touchpad/trackpoint fail to work on Lenovo X1C5/6 and X280. >> And they report they support intertouch mode through SMBus ver 3. >> Current kernel driver limits RMI4 to SMBus 2. >> >> [Fix] >> Enable SMBus ver 3 and set them to SMBus mode will make synaptics work >> fine. >> >> [Test Case] >> Tested on X1C5/6 and X280, confirm patches work fine. >> >> [Regression Potential] >> Enable RMI4 support on specific device ID, no regression is supposed. >> >> Zesty and Xenial do not support this intertouch mode, so no need these >> patches. > > Have these been regression tested on other hardware which uses this > driver? > Yes, tested on X1 Carbon 5th with different touchpad pnp id LEN0072 and Raven2-3, Raven3-1, T460s those are using synaptics touchpad. All of them works fine. Regards, Aaron
On Wed, Oct 18, 2017 at 11:10:04PM +0800, Aaron Ma wrote: > > > On 10/18/2017 10:22 PM, Seth Forshee wrote: > > On Mon, Oct 16, 2017 at 11:50:23PM +0800, Aaron Ma wrote: > >> BugLink: http://bugs.launchpad.net/bugs/1723986 > >> > >> [Impact] > >> Synaptics touchpad/trackpoint fail to work on Lenovo X1C5/6 and X280. > >> And they report they support intertouch mode through SMBus ver 3. > >> Current kernel driver limits RMI4 to SMBus 2. > >> > >> [Fix] > >> Enable SMBus ver 3 and set them to SMBus mode will make synaptics work > >> fine. > >> > >> [Test Case] > >> Tested on X1C5/6 and X280, confirm patches work fine. > >> > >> [Regression Potential] > >> Enable RMI4 support on specific device ID, no regression is supposed. > >> > >> Zesty and Xenial do not support this intertouch mode, so no need these > >> patches. > > > > Have these been regression tested on other hardware which uses this > > driver? > > > > > Yes, tested on X1 Carbon 5th with different touchpad pnp id LEN0072 and > Raven2-3, Raven3-1, T460s those are using synaptics touchpad. > > All of them works fine. Thanks. Applied to artful/master-next and unstable/master.
BugLink: http://bugs.launchpad.net/bugs/1723986 [Impact] Synaptics touchpad/trackpoint fail to work on Lenovo X1C5/6 and X280. And they report they support intertouch mode through SMBus ver 3. Current kernel driver limits RMI4 to SMBus 2. [Fix] Enable SMBus ver 3 and set them to SMBus mode will make synaptics work fine. [Test Case] Tested on X1C5/6 and X280, confirm patches work fine. [Regression Potential] Enable RMI4 support on specific device ID, no regression is supposed. Zesty and Xenial do not support this intertouch mode, so no need these patches. Aaron Ma (1): UBUNTU: SAUCE: Input: synaptics - add Intertouch support on X1 Carbon 6th and X280 Yiannis Marangos (2): UBUNTU: SAUCE: Input: synaptics-rmi4 - RMI4 can also use SMBUS version 3 UBUNTU: SAUCE: Input: synaptics - Lenovo X1 Carbon 5 should use SMBUS/RMI drivers/input/mouse/synaptics.c | 3 +++ drivers/input/rmi4/rmi_smbus.c | 4 ++-- 2 files changed, 5 insertions(+), 2 deletions(-)