mbox series

[0/2] ARM: dts: iwg20d-q7: New DT architecture

Message ID 1507108713-10686-1-git-send-email-fabrizio.castro@bp.renesas.com
Headers show
Series ARM: dts: iwg20d-q7: New DT architecture | expand

Message

Fabrizio Castro Oct. 4, 2017, 9:18 a.m. UTC 
Some of the serial interfaces are exposed on the camera daughter board.
The camera daughter board can be connected to the carrier board
by means of expansion connectors 1, 2 and 3. The carrier board may host
an RZ/G1M or an RZ/G1N based SoM.
While adding support for the serial interfaces on the camera daughter
board we faced the dilemma of how to properly describe all of the
possible HW configurations and how to maximize code reuse.
The best option would be to use device tree overlays, however there is
still some work to be done on that front before actually using them,
therefore for the time being we decided to provide .dtsi files to
describe the carrier board and the camera daughter board, and provide
.dts files to describe the HW configurations we need to support.

Best regards,

Fabrizio Castro (2):
  ARM: dts: iwg20d-q7: Rework DT architecture
  ARM: dts: iwg20d-q7-dbcm-ca: Add device trees for camera DB

 arch/arm/boot/dts/Makefile                      |   1 +
 arch/arm/boot/dts/iwg20d-q7-common.dtsi         | 147 ++++++++++++++++++++++++
 arch/arm/boot/dts/iwg20d-q7-dbcm-ca.dtsi        |  44 +++++++
 arch/arm/boot/dts/r8a7743-iwg20d-q7-dbcm-ca.dts |  19 +++
 arch/arm/boot/dts/r8a7743-iwg20d-q7.dts         | 139 +---------------------
 5 files changed, 213 insertions(+), 137 deletions(-)
 create mode 100644 arch/arm/boot/dts/iwg20d-q7-common.dtsi
 create mode 100644 arch/arm/boot/dts/iwg20d-q7-dbcm-ca.dtsi
 create mode 100644 arch/arm/boot/dts/r8a7743-iwg20d-q7-dbcm-ca.dts

Comments

Geert Uytterhoeven Oct. 6, 2017, 7:57 a.m. UTC | #1 
Hi Fabrizio,

On Wed, Oct 4, 2017 at 11:18 AM, Fabrizio Castro
<fabrizio.castro@bp.renesas.com> wrote:
> This patch adds a .dtsi that describes the camera daughter board
> and a .dts to describe the HW made of iWave's RZ/G1M SoM, iWave's
> RZ/G1M/G1N Qseven carrier board, and the camera daughter board.
> The camera daughter board .dtsi adds support for ttySC[14].
>
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Signed-off-by: Chris Paterson <chris.paterson2@renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

> --- /dev/null
> +++ b/arch/arm/boot/dts/iwg20d-q7-dbcm-ca.dtsi

> +/ {
> +       aliases {
> +               serial1 = &scif1;
> +               serial4 = &hscif1;

BTW, what's the reason you picked serial4 for the third serial port?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Fabrizio Castro Oct. 6, 2017, 9:06 a.m. UTC | #2 
Hi Geert,

> Hi Fabrizio,
>
> On Wed, Oct 4, 2017 at 11:18 AM, Fabrizio Castro
> <fabrizio.castro@bp.renesas.com> wrote:
> > This patch adds a .dtsi that describes the camera daughter board
> > and a .dts to describe the HW made of iWave's RZ/G1M SoM, iWave's
> > RZ/G1M/G1N Qseven carrier board, and the camera daughter board.
> > The camera daughter board .dtsi adds support for ttySC[14].
> >
> > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > Signed-off-by: Chris Paterson <chris.paterson2@renesas.com>
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/iwg20d-q7-dbcm-ca.dtsi
>
> > +/ {
> > +       aliases {
> > +               serial1 = &scif1;
> > +               serial4 = &hscif1;
>
> BTW, what's the reason you picked serial4 for the third serial port?

Because it matches the configuration iWave had in their official release based on
kernel 3.10. We decided to keep the same numbering scheme as a precaution to
avoid breaking existing code.

Thanks,
Fab

>
> Gr{oetje,eeting}s,
>
>                         Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds



Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.